Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: xfa/fxfa/app/xfa_ffpushbutton.cpp

Issue 2031873003: Get rid of NULLs in xfa/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@nullptr_fpdfsdk
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fxfa/app/xfa_ffpushbutton.h ('k') | xfa/fxfa/app/xfa_ffsignature.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fxfa/app/xfa_ffpushbutton.h" 7 #include "xfa/fxfa/app/xfa_ffpushbutton.h"
8 8
9 #include "xfa/fwl/core/cfwl_widgetmgr.h" 9 #include "xfa/fwl/core/cfwl_widgetmgr.h"
10 #include "xfa/fwl/core/fwl_noteimp.h" 10 #include "xfa/fwl/core/fwl_noteimp.h"
11 #include "xfa/fwl/lightwidget/cfwl_pushbutton.h" 11 #include "xfa/fwl/lightwidget/cfwl_pushbutton.h"
12 #include "xfa/fxfa/app/xfa_fffield.h" 12 #include "xfa/fxfa/app/xfa_fffield.h"
13 #include "xfa/fxfa/app/xfa_ffwidgetacc.h" 13 #include "xfa/fxfa/app/xfa_ffwidgetacc.h"
14 #include "xfa/fxfa/app/xfa_textlayout.h" 14 #include "xfa/fxfa/app/xfa_textlayout.h"
15 #include "xfa/fxfa/include/xfa_ffapp.h" 15 #include "xfa/fxfa/include/xfa_ffapp.h"
16 #include "xfa/fxfa/include/xfa_ffpageview.h" 16 #include "xfa/fxfa/include/xfa_ffpageview.h"
17 #include "xfa/fxfa/include/xfa_ffwidget.h" 17 #include "xfa/fxfa/include/xfa_ffwidget.h"
18 #include "xfa/fxgraphics/cfx_color.h" 18 #include "xfa/fxgraphics/cfx_color.h"
19 #include "xfa/fxgraphics/cfx_path.h" 19 #include "xfa/fxgraphics/cfx_path.h"
20 20
21 CXFA_FFPushButton::CXFA_FFPushButton(CXFA_FFPageView* pPageView, 21 CXFA_FFPushButton::CXFA_FFPushButton(CXFA_FFPageView* pPageView,
22 CXFA_WidgetAcc* pDataAcc) 22 CXFA_WidgetAcc* pDataAcc)
23 : CXFA_FFField(pPageView, pDataAcc), 23 : CXFA_FFField(pPageView, pDataAcc),
24 m_pRolloverTextLayout(NULL), 24 m_pRolloverTextLayout(nullptr),
25 m_pDownTextLayout(NULL), 25 m_pDownTextLayout(nullptr),
26 m_pDownProvider(NULL), 26 m_pDownProvider(nullptr),
27 m_pRollProvider(NULL), 27 m_pRollProvider(nullptr),
28 m_pOldDelegate(NULL) {} 28 m_pOldDelegate(nullptr) {}
29 CXFA_FFPushButton::~CXFA_FFPushButton() { 29 CXFA_FFPushButton::~CXFA_FFPushButton() {
30 CXFA_FFPushButton::UnloadWidget(); 30 CXFA_FFPushButton::UnloadWidget();
31 } 31 }
32 void CXFA_FFPushButton::RenderWidget(CFX_Graphics* pGS, 32 void CXFA_FFPushButton::RenderWidget(CFX_Graphics* pGS,
33 CFX_Matrix* pMatrix, 33 CFX_Matrix* pMatrix,
34 uint32_t dwStatus, 34 uint32_t dwStatus,
35 int32_t iRotate) { 35 int32_t iRotate) {
36 if (!IsMatchVisibleStatus(dwStatus)) { 36 if (!IsMatchVisibleStatus(dwStatus)) {
37 return; 37 return;
38 } 38 }
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 FX_ARGB CXFA_FFPushButton::GetFillColor() { 133 FX_ARGB CXFA_FFPushButton::GetFillColor() {
134 return 0xFFFFFFFF; 134 return 0xFFFFFFFF;
135 } 135 }
136 void CXFA_FFPushButton::LoadHighlightCaption() { 136 void CXFA_FFPushButton::LoadHighlightCaption() {
137 CXFA_Caption caption = m_pDataAcc->GetCaption(); 137 CXFA_Caption caption = m_pDataAcc->GetCaption();
138 if (caption && caption.GetPresence() != XFA_ATTRIBUTEENUM_Hidden) { 138 if (caption && caption.GetPresence() != XFA_ATTRIBUTEENUM_Hidden) {
139 { 139 {
140 CFX_WideString wsRollover; 140 CFX_WideString wsRollover;
141 FX_BOOL bRichText; 141 FX_BOOL bRichText;
142 if (m_pDataAcc->GetButtonRollover(wsRollover, bRichText)) { 142 if (m_pDataAcc->GetButtonRollover(wsRollover, bRichText)) {
143 if (m_pRollProvider == NULL) { 143 if (!m_pRollProvider) {
144 m_pRollProvider = 144 m_pRollProvider =
145 new CXFA_TextProvider(m_pDataAcc, XFA_TEXTPROVIDERTYPE_Rollover); 145 new CXFA_TextProvider(m_pDataAcc, XFA_TEXTPROVIDERTYPE_Rollover);
146 } 146 }
147 m_pRolloverTextLayout = new CXFA_TextLayout(m_pRollProvider); 147 m_pRolloverTextLayout = new CXFA_TextLayout(m_pRollProvider);
148 } 148 }
149 CFX_WideString wsDown; 149 CFX_WideString wsDown;
150 if (m_pDataAcc->GetButtonDown(wsDown, bRichText)) { 150 if (m_pDataAcc->GetButtonDown(wsDown, bRichText)) {
151 if (m_pDownProvider == NULL) { 151 if (!m_pDownProvider) {
152 m_pDownProvider = 152 m_pDownProvider =
153 new CXFA_TextProvider(m_pDataAcc, XFA_TEXTPROVIDERTYPE_Down); 153 new CXFA_TextProvider(m_pDataAcc, XFA_TEXTPROVIDERTYPE_Down);
154 } 154 }
155 m_pDownTextLayout = new CXFA_TextLayout(m_pDownProvider); 155 m_pDownTextLayout = new CXFA_TextLayout(m_pDownProvider);
156 } 156 }
157 } 157 }
158 } 158 }
159 } 159 }
160 void CXFA_FFPushButton::LayoutHighlightCaption() { 160 void CXFA_FFPushButton::LayoutHighlightCaption() {
161 CFX_SizeF sz(m_rtCaption.width, m_rtCaption.height); 161 CFX_SizeF sz(m_rtCaption.width, m_rtCaption.height);
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 pGraphics->SetLineWidth(fLineWidth); 238 pGraphics->SetLineWidth(fLineWidth);
239 CFX_Path path; 239 CFX_Path path;
240 path.Create(); 240 path.Create();
241 CFX_RectF rect; 241 CFX_RectF rect;
242 m_pNormalWidget->GetWidgetRect(rect); 242 m_pNormalWidget->GetWidgetRect(rect);
243 path.AddRectangle(0, 0, rect.width, rect.height); 243 path.AddRectangle(0, 0, rect.width, rect.height);
244 pGraphics->StrokePath(&path, (CFX_Matrix*)pMatrix); 244 pGraphics->StrokePath(&path, (CFX_Matrix*)pMatrix);
245 } 245 }
246 } 246 }
247 } 247 }
OLDNEW
« no previous file with comments | « xfa/fxfa/app/xfa_ffpushbutton.h ('k') | xfa/fxfa/app/xfa_ffsignature.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698