Get rid of NULLs in xfa/

xfa/fxfa/app/xfa_checksum.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/include/xfa_checksum.h"
 
 #include "core/fdrm/crypto/include/fx_crypt.h"
 
@@ skipping 36 matching lines @@
       dst[3] = g_FXBase64EncoderMap[src.data5];
     } else {
       dst[3] = '=';
     }
   } else {
     dst[2] = dst[3] = '=';
   }
 }
 
 int32_t Base64EncodeA(const uint8_t* pSrc, int32_t iSrcLen, FX_CHAR* pDst) {
-  ASSERT(pSrc != NULL);
+  ASSERT(pSrc);
   if (iSrcLen < 1) {
     return 0;
   }
-  if (pDst == NULL) {
+  if (!pDst) {
     int32_t iDstLen = iSrcLen / 3 * 4;
     if ((iSrcLen % 3) != 0) {
       iDstLen += 4;
     }
     return iDstLen;
   }
   FX_BASE64DATA srcData;
   int32_t iBytes = 3;
   FX_CHAR* pDstEnd = pDst;
   while (iSrcLen > 0) {
@@ skipping 23 matching lines @@
     : m_pContext(pContext) {
   ASSERT(m_pContext);
 }
 CXFA_SAXReaderHandler::~CXFA_SAXReaderHandler() {}
 void* CXFA_SAXReaderHandler::OnTagEnter(const CFX_ByteStringC& bsTagName,
                                         CFX_SAXItem::Type eType,
                                         uint32_t dwStartPos) {
   UpdateChecksum(TRUE);
   if (eType != CFX_SAXItem::Type::Tag &&
       eType != CFX_SAXItem::Type::Instruction) {
-    return NULL;
+    return nullptr;
   }
   m_SAXContext.m_eNode = eType;
   CFX_ByteTextBuf& textBuf = m_SAXContext.m_TextBuf;
   textBuf << "<";
   if (eType == CFX_SAXItem::Type::Instruction) {
     textBuf << "?";
   }
   textBuf << bsTagName;
   m_SAXContext.m_bsTagName = bsTagName;
   return &m_SAXContext;
 }
 void CXFA_SAXReaderHandler::OnTagAttribute(void* pTag,
                                            const CFX_ByteStringC& bsAttri,
                                            const CFX_ByteStringC& bsValue) {
-  if (pTag == NULL) {
+  if (!pTag)
     return;
-  }
+
   CFX_ByteTextBuf& textBuf = ((CXFA_SAXContext*)pTag)->m_TextBuf;
   textBuf << " " << bsAttri << "=\"" << bsValue << "\"";
 }
 void CXFA_SAXReaderHandler::OnTagBreak(void* pTag) {
-  if (pTag == NULL) {
+  if (!pTag)
     return;
-  }
+
   CFX_ByteTextBuf& textBuf = ((CXFA_SAXContext*)pTag)->m_TextBuf;
   textBuf << ">";
   UpdateChecksum(FALSE);
 }
 void CXFA_SAXReaderHandler::OnTagData(void* pTag,
                                       CFX_SAXItem::Type eType,
                                       const CFX_ByteStringC& bsData,
                                       uint32_t dwStartPos) {
-  if (pTag == NULL) {
+  if (!pTag)
     return;
-  }
+
   CFX_ByteTextBuf& textBuf = ((CXFA_SAXContext*)pTag)->m_TextBuf;
   if (eType == CFX_SAXItem::Type::CharData) {
     textBuf << "<![CDATA[";
   }
   textBuf << bsData;
   if (eType == CFX_SAXItem::Type::CharData) {
     textBuf << "]]>";
   }
 }
 void CXFA_SAXReaderHandler::OnTagClose(void* pTag, uint32_t dwEndPos) {
-  if (pTag == NULL) {
+  if (!pTag)
     return;
-  }
+
   CXFA_SAXContext* pSAXContext = (CXFA_SAXContext*)pTag;
   CFX_ByteTextBuf& textBuf = pSAXContext->m_TextBuf;
   if (pSAXContext->m_eNode == CFX_SAXItem::Type::Instruction) {
     textBuf << "?>";
   } else if (pSAXContext->m_eNode == CFX_SAXItem::Type::Tag) {
     textBuf << "></" << pSAXContext->m_bsTagName.AsStringC() << ">";
   }
   UpdateChecksum(FALSE);
 }
 void CXFA_SAXReaderHandler::OnTagEnd(void* pTag,
                                      const CFX_ByteStringC& bsTagName,
                                      uint32_t dwEndPos) {
-  if (pTag == NULL) {
+  if (!pTag)
     return;
-  }
+
   CFX_ByteTextBuf& textBuf = ((CXFA_SAXContext*)pTag)->m_TextBuf;
   textBuf << "</" << bsTagName << ">";
   UpdateChecksum(FALSE);
 }
 void CXFA_SAXReaderHandler::OnTargetData(void* pTag,
                                          CFX_SAXItem::Type eType,
                                          const CFX_ByteStringC& bsData,
                                          uint32_t dwStartPos) {
-  if (pTag == NULL && eType != CFX_SAXItem::Type::Comment) {
+  if (!pTag && eType != CFX_SAXItem::Type::Comment)
     return;
-  }
+
   if (eType == CFX_SAXItem::Type::Comment) {
     CFX_ByteTextBuf& textBuf = m_SAXContext.m_TextBuf;
     textBuf << "<!--" << bsData << "-->";
     UpdateChecksum(FALSE);
   } else {
     CFX_ByteTextBuf& textBuf = ((CXFA_SAXContext*)pTag)->m_TextBuf;
     textBuf << " " << bsData;
   }
 }
 void CXFA_SAXReaderHandler::UpdateChecksum(FX_BOOL bCheckSpace) {
@@ skipping 43 matching lines @@
 
   CXFA_SAXReaderHandler handler(this);
   m_pSAXReader->SetHandler(&handler);
   if (m_pSAXReader->StartParse(
           pSrcFile, (uint32_t)offset, (uint32_t)size,
           CFX_SaxParseMode_NotSkipSpace | CFX_SaxParseMode_NotConvert_amp |
               CFX_SaxParseMode_NotConvert_lt | CFX_SaxParseMode_NotConvert_gt |
               CFX_SaxParseMode_NotConvert_sharp) < 0) {
     return FALSE;
   }
-  return m_pSAXReader->ContinueParse(NULL) > 99;
+  return m_pSAXReader->ContinueParse(nullptr) > 99;
 }
 
 void CXFA_ChecksumContext::FinishChecksum() {
   delete m_pSAXReader;
   m_pSAXReader = nullptr;
   if (m_pByteContext) {
     uint8_t digest[20];
     FXSYS_memset(digest, 0, 20);
     CRYPT_SHA1Finish(m_pByteContext, digest);
-    int32_t nLen = Base64EncodeA(digest, 20, NULL);
+    int32_t nLen = Base64EncodeA(digest, 20, nullptr);
     FX_CHAR* pBuffer = m_bsChecksum.GetBuffer(nLen);
     Base64EncodeA(digest, 20, pBuffer);
     m_bsChecksum.ReleaseBuffer(nLen);
     FX_Free(m_pByteContext);
-    m_pByteContext = NULL;
+    m_pByteContext = nullptr;
   }
 }
 
 CFX_ByteString CXFA_ChecksumContext::GetChecksum() const {
   return m_bsChecksum;
 }
 
 void CXFA_ChecksumContext::Update(const CFX_ByteStringC& bsText) {
   if (m_pByteContext) {
     CRYPT_SHA1Update(m_pByteContext, bsText.raw_str(), bsText.GetLength());
   }
 }