Get rid of NULLs in xfa/

xfa/fwl/basewidget/fwl_listboximp.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fwl/basewidget/fwl_listboximp.h"
 
 #include "xfa/fde/tto/fde_textout.h"
 #include "xfa/fwl/basewidget/fwl_comboboximp.h"
@@ skipping 50 matching lines @@
 }
 FWL_Error IFWL_ListBox::GetScrollPos(FX_FLOAT& fPos, FX_BOOL bVert) {
   return static_cast<CFWL_ListBoxImp*>(GetImpl())->GetScrollPos(fPos, bVert);
 }
 
 CFWL_ListBoxImp::CFWL_ListBoxImp(const CFWL_WidgetImpProperties& properties,
                                  IFWL_Widget* pOuter)
     : CFWL_WidgetImp(properties, pOuter),
       m_dwTTOStyles(0),
       m_iTTOAligns(0),
-      m_hAnchor(NULL),
+      m_hAnchor(nullptr),
       m_fScorllBarWidth(0),
       m_bLButtonDown(FALSE),
-      m_pScrollBarTP(NULL) {
+      m_pScrollBarTP(nullptr) {
   m_rtClient.Reset();
   m_rtConent.Reset();
   m_rtStatic.Reset();
 }
 
 CFWL_ListBoxImp::~CFWL_ListBoxImp() {}
 
 FWL_Error CFWL_ListBoxImp::GetClassName(CFX_WideString& wsClass) const {
   wsClass = FWL_CLASS_ListBox;
   return FWL_Error::Succeeded;
@@ skipping 138 matching lines @@
     }
     uint32_t dwStyle = pData->GetItemStyles(m_pInterface, pItem);
     if (dwStyle & FWL_ITEMSTATE_LTB_Selected) {
       iRet++;
     }
   }
   return iRet;
 }
 IFWL_ListItem* CFWL_ListBoxImp::GetSelItem(int32_t nIndexSel) {
   if (!m_pProperties->m_pDataProvider)
-    return NULL;
+    return nullptr;
   int32_t index = 0;
   IFWL_ListBoxDP* pData =
       static_cast<IFWL_ListBoxDP*>(m_pProperties->m_pDataProvider);
   int32_t iCount = pData->CountItems(m_pInterface);
   for (int32_t i = 0; i < iCount; i++) {
     IFWL_ListItem* pItem = pData->GetItem(m_pInterface, i);
-    if (!pItem) {
-      return NULL;
-    }
+    if (!pItem)
+      return nullptr;
+
     uint32_t dwStyle = pData->GetItemStyles(m_pInterface, pItem);
     if (dwStyle & FWL_ITEMSTATE_LTB_Selected) {
       if (index == nIndexSel) {
         return pItem;
       } else {
         index++;
       }
     }
   }
-  return NULL;
+  return nullptr;
 }
 int32_t CFWL_ListBoxImp::GetSelIndex(int32_t nIndex) {
   if (!m_pProperties->m_pDataProvider)
     return -1;
   int32_t index = 0;
   IFWL_ListBoxDP* pData =
       static_cast<IFWL_ListBoxDP*>(m_pProperties->m_pDataProvider);
   int32_t iCount = pData->CountItems(m_pInterface);
   for (int32_t i = 0; i < iCount; i++) {
     IFWL_ListItem* pItem = pData->GetItem(m_pInterface, i);
@@ skipping 12 matching lines @@
   return -1;
 }
 FWL_Error CFWL_ListBoxImp::SetSelItem(IFWL_ListItem* pItem, FX_BOOL bSelect) {
   if (!m_pProperties->m_pDataProvider)
     return FWL_Error::Indefinite;
   if (!pItem) {
     if (bSelect) {
       SelectAll();
     } else {
       ClearSelection();
-      SetFocusItem(NULL);
+      SetFocusItem(nullptr);
     }
     return FWL_Error::Indefinite;
   }
   if (m_pProperties->m_dwStyleExes & FWL_STYLEEXT_LTB_MultiSelection) {
     SetSelectionDirect(pItem, bSelect);
   } else {
     SetSelection(pItem, pItem, bSelect);
   }
   return FWL_Error::Succeeded;
 }
@@ skipping 14 matching lines @@
     IFWL_ScrollBar* pScrollBar =
         bVert ? m_pVertScrollBar.get() : m_pHorzScrollBar.get();
     fPos = pScrollBar->GetPos();
     return FWL_Error::Succeeded;
   }
   return FWL_Error::Indefinite;
 }
 
 IFWL_ListItem* CFWL_ListBoxImp::GetItem(IFWL_ListItem* pItem,
                                         uint32_t dwKeyCode) {
-  IFWL_ListItem* hRet = NULL;
   switch (dwKeyCode) {
     case FWL_VKEY_Up:
     case FWL_VKEY_Down:
     case FWL_VKEY_Home:
     case FWL_VKEY_End: {
       const bool bUp = dwKeyCode == FWL_VKEY_Up;
       const bool bDown = dwKeyCode == FWL_VKEY_Down;
       const bool bHome = dwKeyCode == FWL_VKEY_Home;
       IFWL_ListBoxDP* pData =
           static_cast<IFWL_ListBoxDP*>(m_pProperties->m_pDataProvider);
       int32_t iDstItem = -1;
       if (bUp || bDown) {
         int32_t index = pData->GetItemIndex(m_pInterface, pItem);
         iDstItem = dwKeyCode == FWL_VKEY_Up ? index - 1 : index + 1;
       } else if (bHome) {
         iDstItem = 0;
       } else {
         int32_t iCount = pData->CountItems(m_pInterface);
         iDstItem = iCount - 1;
       }
-      hRet = pData->GetItem(m_pInterface, iDstItem);
-      break;
+      return pData->GetItem(m_pInterface, iDstItem);
     }
-    default: {}
+    default:
+      return nullptr;
   }
-  return hRet;
 }
 void CFWL_ListBoxImp::SetSelection(IFWL_ListItem* hStart,
                                    IFWL_ListItem* hEnd,
                                    FX_BOOL bSelected) {
   IFWL_ListBoxDP* pData =
       static_cast<IFWL_ListBoxDP*>(m_pProperties->m_pDataProvider);
   int32_t iStart = pData->GetItemIndex(m_pInterface, hStart);
   int32_t iEnd = pData->GetItemIndex(m_pInterface, hEnd);
   if (iStart > iEnd) {
     int32_t iTemp = iStart;
@@ skipping 58 matching lines @@
     SetSelection(pItemStart, pItemEnd, FALSE);
   }
 }
 IFWL_ListItem* CFWL_ListBoxImp::GetFocusedItem() {
   IFWL_ListBoxDP* pData =
       static_cast<IFWL_ListBoxDP*>(m_pProperties->m_pDataProvider);
   int32_t iCount = pData->CountItems(m_pInterface);
   for (int32_t i = 0; i < iCount; i++) {
     IFWL_ListItem* pItem = pData->GetItem(m_pInterface, i);
     if (!pItem)
-      return NULL;
+      return nullptr;
     if (pData->GetItemStyles(m_pInterface, pItem) & FWL_ITEMSTATE_LTB_Focused) {
       return pItem;
     }
   }
-  return NULL;
+  return nullptr;
 }
 void CFWL_ListBoxImp::SetFocusItem(IFWL_ListItem* pItem) {
   IFWL_ListBoxDP* pData =
       static_cast<IFWL_ListBoxDP*>(m_pProperties->m_pDataProvider);
   IFWL_ListItem* hFocus = GetFocusedItem();
   if (pItem != hFocus) {
     if (hFocus) {
       uint32_t dwStyle = pData->GetItemStyles(m_pInterface, hFocus);
       dwStyle &= ~FWL_ITEMSTATE_LTB_Focused;
       pData->SetItemStyles(m_pInterface, hFocus, dwStyle);
@@ skipping 23 matching lines @@
     if (!pItem) {
       continue;
     }
     CFX_RectF rtItem;
     pData->GetItemRect(m_pInterface, pItem, rtItem);
     rtItem.Offset(-fPosX, -fPosY);
     if (rtItem.Contains(fx, fy)) {
       return pItem;
     }
   }
-  return NULL;
+  return nullptr;
 }
 FX_BOOL CFWL_ListBoxImp::GetItemCheckRect(IFWL_ListItem* pItem,
                                           CFX_RectF& rtCheck) {
   if (!m_pProperties->m_pDataProvider)
     return FALSE;
   if (!(m_pProperties->m_dwStyleExes & FWL_STYLEEXT_LTB_Check)) {
     return FALSE;
   }
   IFWL_ListBoxDP* pData =
       static_cast<IFWL_ListBoxDP*>(m_pProperties->m_pDataProvider);
@@ skipping 465 matching lines @@
   return !(m_pProperties->m_dwStyleExes &
            FWL_STYLEEXT_LTB_ShowScrollBarFocus) ||
          (m_pProperties->m_dwStates & FWL_WGTSTATE_Focused);
 }
 void CFWL_ListBoxImp::ProcessSelChanged() {
   CFWL_EvtLtbSelChanged selEvent;
   selEvent.m_pSrcTarget = m_pInterface;
   CFX_Int32Array arrSels;
   int32_t iCount = CountSelItems();
   for (int32_t i = 0; i < iCount; i++) {
-    IFWL_ListItem* item = GetSelItem(i);
-    if (item == NULL) {
+    if (!GetSelItem(i))
       continue;
-    }
+
     selEvent.iarraySels.Add(i);
   }
   DispatchEvent(&selEvent);
 }
 
 CFWL_ListBoxImpDelegate::CFWL_ListBoxImpDelegate(CFWL_ListBoxImp* pOwner)
     : m_pOwner(pOwner) {}
 
 void CFWL_ListBoxImpDelegate::OnProcessMessage(CFWL_Message* pMessage) {
   if (!pMessage)
@@ skipping 136 matching lines @@
     m_pOwner->m_bLButtonDown = FALSE;
     m_pOwner->SetGrab(FALSE);
     DispatchSelChangedEv();
   }
 }
 void CFWL_ListBoxImpDelegate::OnMouseWheel(CFWL_MsgMouseWheel* pMsg) {
   if (!m_pOwner->IsShowScrollBar(TRUE)) {
     return;
   }
   IFWL_WidgetDelegate* pDelegate =
-      m_pOwner->m_pVertScrollBar->SetDelegate(NULL);
+      m_pOwner->m_pVertScrollBar->SetDelegate(nullptr);
   pDelegate->OnProcessMessage(pMsg);
 }
 void CFWL_ListBoxImpDelegate::OnKeyDown(CFWL_MsgKey* pMsg) {
   uint32_t dwKeyCode = pMsg->m_dwKeyCode;
   switch (dwKeyCode) {
     case FWL_VKEY_Tab:
     case FWL_VKEY_Up:
     case FWL_VKEY_Down:
     case FWL_VKEY_Home:
     case FWL_VKEY_End: {
@@ skipping 95 matching lines @@
     pScrollBar->SetTrackPos(fPos);
     m_pOwner->Repaint(&m_pOwner->m_rtClient);
   }
   return TRUE;
 }
 void CFWL_ListBoxImpDelegate::DispatchSelChangedEv() {
   CFWL_EvtLtbSelChanged ev;
   ev.m_pSrcTarget = m_pOwner->m_pInterface;
   m_pOwner->DispatchEvent(&ev);
 }