Get rid of NULLs in xfa/

xfa/fwl/basewidget/fwl_comboboximp.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fwl/basewidget/fwl_comboboximp.h"
 
 #include "xfa/fde/cfde_txtedtengine.h"
 #include "xfa/fde/tto/fde_textout.h"
@@ skipping 181 matching lines @@
     m_pProperties->m_dwStates &= ~FWL_WGTSTATE_Focused;
     ShowCaret(FALSE);
   }
 }
 void CFWL_ComboEditImp::SetComboBoxFocus(FX_BOOL bSet) {
   m_pOuter->SetFocus(bSet);
 }
 CFWL_ComboListImp::CFWL_ComboListImp(const CFWL_WidgetImpProperties& properties,
                                      IFWL_Widget* pOuter)
     : CFWL_ListBoxImp(properties, pOuter), m_bNotifyOwner(TRUE) {
-  ASSERT(pOuter != NULL);
+  ASSERT(pOuter);
 }
 FWL_Error CFWL_ComboListImp::Initialize() {
   if (CFWL_ListBoxImp::Initialize() != FWL_Error::Succeeded)
     return FWL_Error::Indefinite;
   delete m_pDelegate;
   m_pDelegate = new CFWL_ComboListImpDelegate(this);
   return FWL_Error::Succeeded;
 }
 FWL_Error CFWL_ComboListImp::Finalize() {
   delete m_pDelegate;
@@ skipping 83 matching lines @@
     OnDropListFocusChanged(pMessage, dwHashCode == CFWL_MessageType::SetFocus);
   } else if (dwHashCode == CFWL_MessageType::Mouse) {
     CFWL_MsgMouse* pMsg = static_cast<CFWL_MsgMouse*>(pMessage);
     if (m_pOwner->IsShowScrollBar(TRUE) && m_pOwner->m_pVertScrollBar) {
       CFX_RectF rect;
       m_pOwner->m_pVertScrollBar->GetWidgetRect(rect);
       if (rect.Contains(pMsg->m_fx, pMsg->m_fy)) {
         pMsg->m_fx -= rect.left;
         pMsg->m_fy -= rect.top;
         IFWL_WidgetDelegate* pDelegate =
-            m_pOwner->m_pVertScrollBar->SetDelegate(NULL);
+            m_pOwner->m_pVertScrollBar->SetDelegate(nullptr);
         pDelegate->OnProcessMessage(pMsg);
         return;
       }
     }
     switch (pMsg->m_dwCmd) {
       case FWL_MouseCommand::Move: {
         backDefault = FALSE;
         OnDropListMouseMove(pMsg);
         break;
       }
@@ skipping 148 matching lines @@
                        m_pOwner->m_pProperties->m_rtWidget.height);
       m_pOwner->Repaint(&rtInvalidate);
       break;
     }
     default: {}
   }
 }
 CFWL_ComboBoxImp::CFWL_ComboBoxImp(const CFWL_WidgetImpProperties& properties,
                                    IFWL_Widget* pOuter)
     : CFWL_WidgetImp(properties, pOuter),
-      m_pForm(NULL),
+      m_pForm(nullptr),
       m_bLButtonDown(FALSE),
       m_iCurSel(-1),
       m_iBtnState(CFWL_PartState_Normal),
       m_fComboFormHandler(0),
       m_bNeedShowList(FALSE) {
   m_rtClient.Reset();
   m_rtBtn.Reset();
   m_rtHandler.Reset();
 }
 
@@ skipping 94 matching lines @@
     return DisForm_Update();
   }
   if (IsLocked()) {
     return FWL_Error::Indefinite;
   }
   ReSetTheme();
   FX_BOOL bDropDown = IsDropDownStyle();
   if (bDropDown && m_pEdit) {
     ReSetEditAlignment();
   }
-  if (m_pProperties->m_pThemeProvider == NULL) {
+  if (!m_pProperties->m_pThemeProvider)
     m_pProperties->m_pThemeProvider = GetAvailableTheme();
-  }
+
   Layout();
   CFWL_ThemePart part;
   part.m_pWidget = m_pInterface;
   m_fComboFormHandler =
       *static_cast<FX_FLOAT*>(m_pProperties->m_pThemeProvider->GetCapacity(
           &part, CFWL_WidgetCapacity::ComboFormHandler));
   return FWL_Error::Succeeded;
 }
 FWL_WidgetHit CFWL_ComboBoxImp::HitTest(FX_FLOAT fx, FX_FLOAT fy) {
   if (m_pWidgetMgr->IsFormDisabled()) {
@@ skipping 28 matching lines @@
     if (pMatrix) {
       param.m_matrix.Concat(*pMatrix);
     }
     param.m_rtPart = rtTextBk;
     if (m_iCurSel >= 0) {
       IFWL_ListBoxDP* pData = static_cast<IFWL_ListBoxDP*>(
           static_cast<CFWL_ComboListImp*>(m_pListBox->GetImpl())
               ->m_pProperties->m_pDataProvider);
       void* p = pData->GetItemData(m_pListBox.get(),
                                    pData->GetItem(m_pListBox.get(), m_iCurSel));
-      if (p != NULL) {
+      if (p)
         param.m_pData = p;
-      }
     }
     if (m_pProperties->m_dwStates & FWL_WGTSTATE_Disabled) {
       param.m_dwStates = CFWL_PartState_Disabled;
     } else if ((m_pProperties->m_dwStates & FWL_WGTSTATE_Focused) &&
                (m_iCurSel >= 0)) {
       param.m_dwStates = CFWL_PartState_Selected;
     } else {
       param.m_dwStates = CFWL_PartState_Normal;
     }
     pTheme->DrawBackground(&param);
@@ skipping 212 matching lines @@
   if (m_pListBox && IsDropListShowed()) {
     CFX_RectF rtList;
     m_pListBox->GetWidgetRect(rtList);
     rtList.Offset(rect.left, rect.top);
     rect.Union(rtList);
   }
   return FWL_Error::Succeeded;
 }
 FWL_Error CFWL_ComboBoxImp::EditModifyStylesEx(uint32_t dwStylesExAdded,
                                                uint32_t dwStylesExRemoved) {
-  if (m_pEdit != NULL) {
+  if (m_pEdit)
     return m_pEdit->ModifyStylesEx(dwStylesExAdded, dwStylesExRemoved);
-  } else {
-    return FWL_Error::ParameterInvalid;
-  }
+  return FWL_Error::ParameterInvalid;
 }
 FX_FLOAT CFWL_ComboBoxImp::GetListHeight() {
   return static_cast<IFWL_ComboBoxDP*>(m_pProperties->m_pDataProvider)
       ->GetListHeight(m_pInterface);
 }
 void CFWL_ComboBoxImp::DrawStretchHandler(CFX_Graphics* pGraphics,
                                           const CFX_Matrix* pMatrix) {
   CFWL_ThemeBackground param;
   param.m_pGraphics = pGraphics;
   param.m_iPart = CFWL_Part::StretchHandler;
@@ skipping 40 matching lines @@
       m_rtList.width = m_rtClient.width;
     }
     m_rtProxy = m_rtList;
     if (m_pProperties->m_dwStyleExes & FWL_STYLEEXT_CMB_ListDrag) {
       m_rtProxy.height += m_fComboFormHandler;
     }
     GetPopupPos(fMinHeight, m_rtProxy.height, rtAnchor, m_rtProxy);
     if (m_pProperties->m_dwStyleExes & FWL_STYLEEXT_CMB_ListDrag) {
       FX_FLOAT fx = 0;
       FX_FLOAT fy = m_rtClient.top + m_rtClient.height / 2;
-      TransformTo(NULL, fx, fy);
+      TransformTo(nullptr, fx, fy);
       m_bUpFormHandler = fy > m_rtProxy.top;
       if (m_bUpFormHandler) {
         m_rtHandler.Set(0, 0, m_rtList.width, m_fComboFormHandler);
         m_rtList.top = m_fComboFormHandler;
       } else {
         m_rtHandler.Set(0, m_rtList.height, m_rtList.width,
                         m_fComboFormHandler);
       }
     }
     m_pForm->SetWidgetRect(m_rtProxy);
@@ skipping 639 matching lines @@
     m_pOwner->m_iCurSel = iCurSel;
     if (bDropDown && m_pOwner->m_pEdit) {
       m_pOwner->SynchrEditText(m_pOwner->m_iCurSel);
     } else {
       m_pOwner->Repaint(&m_pOwner->m_rtClient);
     }
     return;
   }
   FX_BOOL bDropDown = m_pOwner->IsDropDownStyle();
   if (bDropDown) {
-    IFWL_WidgetDelegate* pDelegate = m_pOwner->m_pEdit->SetDelegate(NULL);
+    IFWL_WidgetDelegate* pDelegate = m_pOwner->m_pEdit->SetDelegate(nullptr);
     pDelegate->OnProcessMessage(pMsg);
   }
 }
 void CFWL_ComboBoxImpDelegate::DisForm_OnProcessMessage(
     CFWL_Message* pMessage) {
   if (!pMessage)
     return;
 
   FX_BOOL backDefault = TRUE;
   switch (pMessage->GetClassID()) {
@@ skipping 30 matching lines @@
       if (pKey->m_dwCmd == FWL_KeyCommand::KeyUp)
         break;
       if (m_pOwner->DisForm_IsDropListShowed() &&
           pKey->m_dwCmd == FWL_KeyCommand::KeyDown) {
         FX_BOOL bListKey = pKey->m_dwKeyCode == FWL_VKEY_Up ||
                            pKey->m_dwKeyCode == FWL_VKEY_Down ||
                            pKey->m_dwKeyCode == FWL_VKEY_Return ||
                            pKey->m_dwKeyCode == FWL_VKEY_Escape;
         if (bListKey) {
           IFWL_WidgetDelegate* pDelegate =
-              m_pOwner->m_pListBox->SetDelegate(NULL);
+              m_pOwner->m_pListBox->SetDelegate(nullptr);
           pDelegate->OnProcessMessage(pMessage);
           break;
         }
       }
       DisForm_OnKey(pKey);
       break;
     }
     default:
       break;
   }
@@ skipping 18 matching lines @@
     }
   }
 }
 void CFWL_ComboBoxImpDelegate::DisForm_OnFocusChanged(CFWL_Message* pMsg,
                                                       FX_BOOL bSet) {
   if (bSet) {
     m_pOwner->m_pProperties->m_dwStates |= FWL_WGTSTATE_Focused;
     if ((m_pOwner->m_pEdit->GetStates() & FWL_WGTSTATE_Focused) == 0) {
       CFWL_MsgSetFocus msg;
       msg.m_pDstTarget = m_pOwner->m_pEdit.get();
-      msg.m_pSrcTarget = NULL;
-      IFWL_WidgetDelegate* pDelegate = m_pOwner->m_pEdit->SetDelegate(NULL);
+      msg.m_pSrcTarget = nullptr;
+      IFWL_WidgetDelegate* pDelegate = m_pOwner->m_pEdit->SetDelegate(nullptr);
       pDelegate->OnProcessMessage(&msg);
     }
   } else {
     m_pOwner->m_pProperties->m_dwStates &= ~FWL_WGTSTATE_Focused;
     m_pOwner->DisForm_ShowDropList(FALSE);
     CFWL_MsgKillFocus msg;
-    msg.m_pDstTarget = NULL;
+    msg.m_pDstTarget = nullptr;
     msg.m_pSrcTarget = m_pOwner->m_pEdit.get();
-    IFWL_WidgetDelegate* pDelegate = m_pOwner->m_pEdit->SetDelegate(NULL);
+    IFWL_WidgetDelegate* pDelegate = m_pOwner->m_pEdit->SetDelegate(nullptr);
     pDelegate->OnProcessMessage(&msg);
   }
 }
 void CFWL_ComboBoxImpDelegate::DisForm_OnKey(CFWL_MsgKey* pMsg) {
   uint32_t dwKeyCode = pMsg->m_dwKeyCode;
   const bool bUp = dwKeyCode == FWL_VKEY_Up;
   const bool bDown = dwKeyCode == FWL_VKEY_Down;
   if (bUp || bDown) {
     CFWL_ComboListImp* pComboList =
         static_cast<CFWL_ComboListImp*>(m_pOwner->m_pListBox->GetImpl());
@@ skipping 24 matching lines @@
         iCurSel--;
       } else {
         iCurSel++;
       }
     }
     m_pOwner->m_iCurSel = iCurSel;
     m_pOwner->SynchrEditText(m_pOwner->m_iCurSel);
     return;
   }
   if (m_pOwner->m_pEdit) {
-    IFWL_WidgetDelegate* pDelegate = m_pOwner->m_pEdit->SetDelegate(NULL);
+    IFWL_WidgetDelegate* pDelegate = m_pOwner->m_pEdit->SetDelegate(nullptr);
     pDelegate->OnProcessMessage(pMsg);
   }
 }
 
 CFWL_ComboProxyImpDelegate::CFWL_ComboProxyImpDelegate(
     IFWL_Form* pForm,
     CFWL_ComboBoxImp* pComboBox)
     : m_bLButtonDown(FALSE),
       m_bLButtonUpSelf(FALSE),
       m_fStartPos(0),
@@ skipping 87 matching lines @@
   } else {
     m_bLButtonUpSelf = TRUE;
   }
 }
 void CFWL_ComboProxyImpDelegate::OnMouseMove(CFWL_MsgMouse* pMsg) {}
 void CFWL_ComboProxyImpDelegate::OnDeactive(CFWL_MsgDeactivate* pMsg) {
   m_pComboBox->ShowDropList(FALSE);
 }
 void CFWL_ComboProxyImpDelegate::OnFocusChanged(CFWL_MsgKillFocus* pMsg,
                                                 FX_BOOL bSet) {
-  if (!bSet) {
-    if (pMsg->m_pSetFocus == NULL) {
-      m_pComboBox->ShowDropList(FALSE);
-    }
-  }
+  if (bSet)
+    return;
+  if (!pMsg->m_pSetFocus)
+    m_pComboBox->ShowDropList(FALSE);
 }