Get rid of NULLs in xfa/

xfa/fgas/localization/fgas_locale.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include <algorithm>
 
 #include "core/fxcrt/include/fx_ext.h"
 #include "core/fxcrt/include/fx_xml.h"
@@ skipping 460 matching lines @@
       }
       return wsLCID;
     }
     ccf++;
   }
   return CFX_WideString();
 }
 IFX_Locale* CFX_FormatString::GetTextFormat(const CFX_WideString& wsPattern,
                                             const CFX_WideStringC& wsCategory,
                                             CFX_WideString& wsPurgePattern) {
-  IFX_Locale* pLocale = NULL;
+  IFX_Locale* pLocale = nullptr;
   int32_t ccf = 0;
   int32_t iLenf = wsPattern.GetLength();
   const FX_WCHAR* pStr = wsPattern.c_str();
   FX_BOOL bBrackOpen = FALSE;
   CFX_WideStringC wsConstChars(gs_wsConstChars);
   while (ccf < iLenf) {
     if (pStr[ccf] == '\'') {
       int32_t iCurChar = ccf;
       FX_GetLiteralText(pStr, ccf, iLenf);
       wsPurgePattern += CFX_WideStringC(pStr + iCurChar, ccf - iCurChar + 1);
@@ skipping 36 matching lines @@
   return pLocale;
 }
 #define FX_NUMSTYLE_Percent 0x01
 #define FX_NUMSTYLE_Exponent 0x02
 #define FX_NUMSTYLE_DotVorv 0x04
 IFX_Locale* CFX_FormatString::GetNumericFormat(const CFX_WideString& wsPattern,
                                                int32_t& iDotIndex,
                                                uint32_t& dwStyle,
                                                CFX_WideString& wsPurgePattern) {
   dwStyle = 0;
-  IFX_Locale* pLocale = NULL;
+  IFX_Locale* pLocale = nullptr;
   int32_t ccf = 0;
   int32_t iLenf = wsPattern.GetLength();
   const FX_WCHAR* pStr = wsPattern.c_str();
   FX_BOOL bFindDot = FALSE;
   FX_BOOL bBrackOpen = FALSE;
   CFX_WideStringC wsConstChars(gs_wsConstChars);
   while (ccf < iLenf) {
     if (pStr[ccf] == '\'') {
       int32_t iCurChar = ccf;
       FX_GetLiteralText(pStr, ccf, iLenf);
@@ skipping 35 matching lines @@
             if (g_FXLocaleNumSubCatData[i].uHash == dwSubHash) {
               eSubCategory = (FX_LOCALENUMSUBCATEGORY)g_FXLocaleNumSubCatData[i]
                                  .eSubCategory;
               break;
             }
           }
           wsSubCategory.clear();
           if (!pLocale) {
             pLocale = m_pLocaleMgr->GetDefLocale();
           }
-          ASSERT(pLocale != NULL);
           pLocale->GetNumPattern(eSubCategory, wsSubCategory);
           iDotIndex = wsSubCategory.Find('.');
           if (iDotIndex > 0) {
             iDotIndex += wsPurgePattern.GetLength();
             bFindDot = TRUE;
             dwStyle |= FX_NUMSTYLE_DotVorv;
           }
           wsPurgePattern += wsSubCategory;
           if (eSubCategory == FX_LOCALENUMPATTERN_Percent) {
             dwStyle |= FX_NUMSTYLE_Percent;
@@ skipping 1310 matching lines @@
   if (bNeg) {
     wsValue = L'-' + wsValue;
   }
   return TRUE;
 }
 FX_DATETIMETYPE CFX_FormatString::GetDateTimeFormat(
     const CFX_WideString& wsPattern,
     IFX_Locale*& pLocale,
     CFX_WideString& wsDatePattern,
     CFX_WideString& wsTimePattern) {
-  pLocale = NULL;
+  pLocale = nullptr;
   CFX_WideString wsTempPattern;
   FX_LOCALECATEGORY eCategory = FX_LOCALECATEGORY_Unknown;
   int32_t ccf = 0;
   int32_t iLenf = wsPattern.GetLength();
   const FX_WCHAR* pStr = wsPattern.c_str();
   int32_t iFindCategory = 0;
   FX_BOOL bBraceOpen = FALSE;
   CFX_WideStringC wsConstChars(gs_wsConstChars);
   while (ccf < iLenf) {
     if (pStr[ccf] == '\'') {
@@ skipping 55 matching lines @@
           FX_LOCALEDATETIMESUBCATEGORY eSubCategory =
               FX_LOCALEDATETIMESUBCATEGORY_Medium;
           for (int32_t i = 0; i < g_iFXLocaleDateTimeSubCatCount; i++) {
             if (g_FXLocaleDateTimeSubCatData[i].uHash == dwSubHash) {
               eSubCategory =
                   (FX_LOCALEDATETIMESUBCATEGORY)g_FXLocaleDateTimeSubCatData[i]
                       .eSubCategory;
               break;
             }
           }
-          if (!pLocale) {
+          if (!pLocale)
             pLocale = m_pLocaleMgr->GetDefLocale();
-          }
-          ASSERT(pLocale != NULL);
           switch (eCategory) {
             case FX_LOCALECATEGORY_Date:
               pLocale->GetDatePattern(eSubCategory, wsDatePattern);
               wsDatePattern = wsTempPattern + wsDatePattern;
               break;
             case FX_LOCALECATEGORY_Time:
               pLocale->GetTimePattern(eSubCategory, wsTimePattern);
               wsTimePattern = wsTempPattern + wsTimePattern;
               break;
             case FX_LOCALECATEGORY_DateTime:
@@ skipping 454 matching lines @@
 }
 FX_BOOL CFX_FormatString::ParseDateTime(const CFX_WideString& wsSrcDateTime,
                                         const CFX_WideString& wsPattern,
                                         FX_DATETIMETYPE eDateTimeType,
                                         CFX_Unitime& dtValue) {
   dtValue.Set(0);
   if (wsSrcDateTime.IsEmpty() || wsPattern.IsEmpty()) {
     return FALSE;
   }
   CFX_WideString wsDatePattern, wsTimePattern;
-  IFX_Locale* pLocale = NULL;
+  IFX_Locale* pLocale = nullptr;
   FX_DATETIMETYPE eCategory =
       GetDateTimeFormat(wsPattern, pLocale, wsDatePattern, wsTimePattern);
   if (!pLocale) {
     return FALSE;
   }
   if (eCategory == FX_DATETIMETYPE_Unknown) {
     eCategory = eDateTimeType;
   }
   if (eCategory == FX_DATETIMETYPE_Unknown) {
     return FALSE;
@@ skipping 1494 matching lines @@
   wsOutput = bDateFirst ? wsDateOut + wsTimeOut : wsTimeOut + wsDateOut;
   return bRet;
 }
 FX_BOOL CFX_FormatString::FormatDateTime(const CFX_WideString& wsSrcDateTime,
                                          const CFX_WideString& wsPattern,
                                          CFX_WideString& wsOutput) {
   if (wsSrcDateTime.IsEmpty() || wsPattern.IsEmpty()) {
     return FALSE;
   }
   CFX_WideString wsDatePattern, wsTimePattern;
-  IFX_Locale* pLocale = NULL;
+  IFX_Locale* pLocale = nullptr;
   FX_DATETIMETYPE eCategory =
       GetDateTimeFormat(wsPattern, pLocale, wsDatePattern, wsTimePattern);
-  if (pLocale == NULL || eCategory == FX_DATETIMETYPE_Unknown) {
+  if (!pLocale || eCategory == FX_DATETIMETYPE_Unknown)
     return FALSE;
-  }
+
   CFX_Unitime dt(0);
   int32_t iT = wsSrcDateTime.Find(L"T");
   if (iT < 0) {
     if (eCategory == FX_DATETIMETYPE_Date) {
       FX_DateFromCanonical(wsSrcDateTime, dt);
     } else if (eCategory == FX_DATETIMETYPE_Time) {
       FX_TimeFromCanonical(wsSrcDateTime.AsStringC(), dt, pLocale);
     }
   } else {
     FX_DateFromCanonical(wsSrcDateTime.Left(iT), dt);
     FX_TimeFromCanonical(
         wsSrcDateTime.Right(wsSrcDateTime.GetLength() - iT - 1).AsStringC(), dt,
         pLocale);
   }
   return FX_FormatDateTime(dt, wsDatePattern, wsTimePattern,
                            eCategory != FX_DATETIMETYPE_TimeDate, pLocale,
                            wsOutput);
 }
 FX_BOOL CFX_FormatString::FormatDateTime(const CFX_WideString& wsSrcDateTime,
                                          const CFX_WideString& wsPattern,
                                          CFX_WideString& wsOutput,
                                          FX_DATETIMETYPE eDateTimeType) {
   if (wsSrcDateTime.IsEmpty() || wsPattern.IsEmpty()) {
     return FALSE;
   }
   CFX_WideString wsDatePattern, wsTimePattern;
-  IFX_Locale* pLocale = NULL;
+  IFX_Locale* pLocale = nullptr;
   FX_DATETIMETYPE eCategory =
       GetDateTimeFormat(wsPattern, pLocale, wsDatePattern, wsTimePattern);
   if (!pLocale) {
     return FALSE;
   }
   if (eCategory == FX_DATETIMETYPE_Unknown) {
     if (eDateTimeType == FX_DATETIMETYPE_Time) {
       wsTimePattern = wsDatePattern;
       wsDatePattern.clear();
     }
@@ skipping 30 matching lines @@
   }
   return FALSE;
 }
 FX_BOOL CFX_FormatString::FormatDateTime(const CFX_Unitime& dt,
                                          const CFX_WideString& wsPattern,
                                          CFX_WideString& wsOutput) {
   if (wsPattern.IsEmpty()) {
     return FALSE;
   }
   CFX_WideString wsDatePattern, wsTimePattern;
-  IFX_Locale* pLocale = NULL;
+  IFX_Locale* pLocale = nullptr;
   FX_DATETIMETYPE eCategory =
       GetDateTimeFormat(wsPattern, pLocale, wsDatePattern, wsTimePattern);
   if (!pLocale) {
     return FALSE;
   }
   return FX_FormatDateTime(dt, wsPattern, wsTimePattern,
                            eCategory != FX_DATETIMETYPE_TimeDate, pLocale,
                            wsOutput);
 }
 FX_BOOL CFX_FormatString::FormatZero(const CFX_WideString& wsPattern,
@@ skipping 680 matching lines @@
 }
 CFX_Decimal CFX_Decimal::operator*(const CFX_Decimal& val) const {
   return Multiply(val);
 }
 CFX_Decimal CFX_Decimal::operator/(const CFX_Decimal& val) const {
   return Divide(val);
 }
 CFX_Decimal CFX_Decimal::operator%(const CFX_Decimal& val) const {
   return Modulus(val);
 }