Get rid of NULLs in xfa/

xfa/fgas/layout/fgas_textbreak.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fgas/layout/fgas_textbreak.h"
 
 #include <algorithm>
 
 #include "core/fxcrt/include/fx_arabic.h"
 #include "core/fxcrt/include/fx_arb.h"
 #include "core/fxcrt/include/fx_memory.h"
 #include "xfa/fgas/layout/fgas_linebreak.h"
 #include "xfa/fgas/layout/fgas_unicode.h"
 
 CFX_TxtBreak::CFX_TxtBreak(uint32_t dwPolicies)
     : m_dwPolicies(dwPolicies),
       m_iLineWidth(2000000),
       m_dwLayoutStyles(0),
       m_bVertical(FALSE),
       m_bArabicContext(FALSE),
       m_bArabicShapes(FALSE),
       m_bRTL(FALSE),
       m_bSingleLine(FALSE),
       m_bCombText(FALSE),
       m_iArabicContext(1),
       m_iCurArabicContext(1),
-      m_pFont(NULL),
+      m_pFont(nullptr),
       m_iFontSize(240),
       m_bEquidistant(TRUE),
       m_iTabWidth(720000),
       m_wDefChar(0xFEFF),
       m_wParagBreakChar(L'\n'),
       m_iDefChar(0),
       m_iLineRotation(0),
       m_iCharRotation(0),
       m_iRotation(0),
       m_iAlignment(FX_TXTLINEALIGNMENT_Left),
       m_dwContextCharStyles(0),
       m_iCombWidth(360000),
-      m_pUserData(NULL),
+      m_pUserData(nullptr),
       m_eCharType(FX_CHARTYPE_Unknown),
       m_bArabicNumber(FALSE),
       m_bArabicComma(FALSE),
-      m_pCurLine(NULL),
+      m_pCurLine(nullptr),
       m_iReady(0),
       m_iTolerance(0),
       m_iHorScale(100),
       m_iVerScale(100),
       m_iCharSpace(0) {
   m_bPagination = (m_dwPolicies & FX_TXTBREAKPOLICY_Pagination) != 0;
   if (m_bPagination) {
     m_pTxtLine1 = new CFX_TxtLine(sizeof(CFX_Char));
     m_pTxtLine2 = new CFX_TxtLine(sizeof(CFX_Char));
   } else {
@@ skipping 30 matching lines @@
   m_bArabicShapes = (m_dwLayoutStyles & FX_TXTLAYOUTSTYLE_ArabicShapes) != 0;
   m_bRTL = (m_dwLayoutStyles & FX_TXTLAYOUTSTYLE_RTLReadingOrder) != 0;
   m_bSingleLine = (m_dwLayoutStyles & FX_TXTLAYOUTSTYLE_SingleLine) != 0;
   m_bCombText = (m_dwLayoutStyles & FX_TXTLAYOUTSTYLE_CombText) != 0;
   ResetArabicContext();
   m_iLineRotation = GetLineRotation(m_dwLayoutStyles);
   m_iRotation = m_iLineRotation + m_iCharRotation;
   m_iRotation %= 4;
 }
 void CFX_TxtBreak::SetFont(IFGAS_Font* pFont) {
-  if (pFont == NULL) {
+  if (!pFont || m_pFont == pFont)
     return;
-  }
-  if (m_pFont == pFont) {
-    return;
-  }
+
   SetBreakStatus();
   m_pFont = pFont;
   m_iDefChar = 0;
-  if (m_wDefChar != 0xFEFF && m_pFont != NULL) {
+  if (m_wDefChar != 0xFEFF && m_pFont) {
     m_pFont->GetCharWidth(m_wDefChar, m_iDefChar, FALSE);
     m_iDefChar *= m_iFontSize;
   }
 }
 void CFX_TxtBreak::SetFontSize(FX_FLOAT fFontSize) {
   int32_t iFontSize = FXSYS_round(fFontSize * 20.0f);
   if (m_iFontSize == iFontSize) {
     return;
   }
   SetBreakStatus();
   m_iFontSize = iFontSize;
   m_iDefChar = 0;
-  if (m_wDefChar != 0xFEFF && m_pFont != NULL) {
+  if (m_wDefChar != 0xFEFF && m_pFont) {
     m_pFont->GetCharWidth(m_wDefChar, m_iDefChar, FALSE);
     m_iDefChar *= m_iFontSize;
   }
 }
 void CFX_TxtBreak::SetTabWidth(FX_FLOAT fTabWidth, FX_BOOL bEquidistant) {
   m_iTabWidth = FXSYS_round(fTabWidth * 20000.0f);
   if (m_iTabWidth < FX_TXTBREAK_MinimumTabWidth) {
     m_iTabWidth = FX_TXTBREAK_MinimumTabWidth;
   }
   m_bEquidistant = bEquidistant;
 }
 void CFX_TxtBreak::SetDefaultChar(FX_WCHAR wch) {
   m_wDefChar = wch;
   m_iDefChar = 0;
-  if (m_wDefChar != 0xFEFF && m_pFont != NULL) {
+  if (m_wDefChar != 0xFEFF && m_pFont) {
     m_pFont->GetCharWidth(m_wDefChar, m_iDefChar, FALSE);
     if (m_iDefChar < 0) {
       m_iDefChar = 0;
     } else {
       m_iDefChar *= m_iFontSize;
     }
   }
 }
 void CFX_TxtBreak::SetParagraphBreakChar(FX_WCHAR wch) {
   if (wch != L'\r' && wch != L'\n') {
@@ skipping 95 matching lines @@
   m_iCharSpace = FXSYS_round(fCharSpace * 20000.0f);
 }
 static const int32_t gs_FX_TxtLineRotations[8] = {0, 3, 1, 0, 2, 1, 3, 2};
 int32_t CFX_TxtBreak::GetLineRotation(uint32_t dwStyles) const {
   return gs_FX_TxtLineRotations[(dwStyles & 0x0E) >> 1];
 }
 CFX_TxtChar* CFX_TxtBreak::GetLastChar(int32_t index, FX_BOOL bOmitChar) const {
   CFX_TxtCharArray& ca = *m_pCurLine->m_pLineChars;
   int32_t iCount = ca.GetSize();
   if (index < 0 || index >= iCount) {
-    return NULL;
+    return nullptr;
   }
   CFX_TxtChar* pTC;
   int32_t iStart = iCount - 1;
   while (iStart > -1) {
     pTC = ca.GetDataPtr(iStart--);
     if (bOmitChar && pTC->GetCharType() == FX_CHARTYPE_Combination) {
       continue;
     }
     if (--index < 0) {
       return pTC;
     }
   }
-  return NULL;
+  return nullptr;
 }
 CFX_TxtLine* CFX_TxtBreak::GetTxtLine(FX_BOOL bReady) const {
   if (!bReady) {
     return m_pCurLine;
   }
   if (m_iReady == 1) {
     return m_pTxtLine1;
   } else if (m_iReady == 2) {
     return m_pTxtLine2;
   } else {
-    return NULL;
+    return nullptr;
   }
 }
 CFX_TxtPieceArray* CFX_TxtBreak::GetTxtPieces(FX_BOOL bReady) const {
   CFX_TxtLine* pTxtLine = GetTxtLine(bReady);
-  if (pTxtLine == NULL) {
-    return NULL;
-  }
-  return pTxtLine->m_pLinePieces;
+  return pTxtLine ? pTxtLine->m_pLinePieces : nullptr;
 }
 inline FX_CHARTYPE CFX_TxtBreak::GetUnifiedCharType(
     FX_CHARTYPE chartype) const {
   return chartype >= FX_CHARTYPE_ArabicAlef ? FX_CHARTYPE_Arabic : chartype;
 }
 void CFX_TxtBreak::ResetArabicContext() {
   if (m_bArabicContext) {
     m_bCurRTL = m_iCurArabicContext > 1;
     m_iCurAlignment = m_iCurArabicContext > 1 ? FX_TXTLINEALIGNMENT_Right
                                               : FX_TXTLINEALIGNMENT_Left;
@@ skipping 30 matching lines @@
             : ((iBidiCls == FX_BIDICLASS_L || iBidiCls == FX_BIDICLASS_S) ? 0
                                                                           : 1);
     if (iArabicContext != m_iArabicContext && iArabicContext != 1) {
       m_iArabicContext = iArabicContext;
       if (m_iCurArabicContext == 1) {
         m_iCurArabicContext = iArabicContext;
       }
       ResetArabicContext();
       if (!m_bPagination) {
         CFX_TxtChar* pLastChar = (CFX_TxtChar*)GetLastChar(1, FALSE);
-        if (pLastChar != NULL && pLastChar->m_dwStatus < 1) {
+        if (pLastChar && pLastChar->m_dwStatus < 1) {
           pLastChar->m_dwStatus = FX_TXTBREAK_PieceBreak;
         }
       }
     }
   }
   pCurChar->m_dwCharStyles = m_dwContextCharStyles;
 }
 uint32_t CFX_TxtBreak::AppendChar_Combination(CFX_Char* pCurChar,
                                               int32_t iRotation) {
-  ASSERT(pCurChar != NULL);
   FX_WCHAR wch = pCurChar->m_wCharCode;
   FX_WCHAR wForm;
   int32_t iCharWidth = 0;
   CFX_Char* pLastChar;
   pCurChar->m_iCharWidth = -1;
   if (m_bCombText) {
     iCharWidth = m_iCombWidth;
   } else {
     if (m_bVertical != FX_IsOdd(iRotation)) {
       iCharWidth = 1000;
     } else {
       wForm = wch;
       if (!m_bPagination) {
         pLastChar = GetLastChar(0, FALSE);
-        if (pLastChar != NULL &&
+        if (pLastChar &&
             (((CFX_TxtChar*)pLastChar)->m_dwCharStyles &
              FX_TXTCHARSTYLE_ArabicShadda) == 0) {
           FX_BOOL bShadda = FALSE;
           if (wch == 0x0651) {
             FX_WCHAR wLast = pLastChar->m_wCharCode;
             if (wLast >= 0x064C && wLast <= 0x0650) {
               wForm = FX_GetArabicFromShaddaTable(wLast);
               bShadda = TRUE;
             }
           } else if (wch >= 0x064C && wch <= 0x0650) {
@@ skipping 76 matching lines @@
     }
   }
   return dwRet;
 }
 uint32_t CFX_TxtBreak::AppendChar_Arabic(CFX_Char* pCurChar,
                                          int32_t iRotation) {
   FX_CHARTYPE chartype = pCurChar->GetCharType();
   int32_t& iLineWidth = m_pCurLine->m_iWidth;
   FX_WCHAR wForm;
   int32_t iCharWidth = 0;
-  CFX_Char* pLastChar = NULL;
+  CFX_Char* pLastChar = nullptr;
   FX_BOOL bAlef = FALSE;
   if (!m_bCombText && m_eCharType >= FX_CHARTYPE_ArabicAlef &&
       m_eCharType <= FX_CHARTYPE_ArabicDistortion) {
     pLastChar = GetLastChar(1);
-    if (pLastChar != NULL) {
+    if (pLastChar) {
       iCharWidth = pLastChar->m_iCharWidth;
       if (iCharWidth > 0) {
         iLineWidth -= iCharWidth;
       }
       CFX_Char* pPrevChar = GetLastChar(2);
       wForm = pdfium::arabic::GetFormChar(pLastChar, pPrevChar, pCurChar);
       bAlef = (wForm == 0xFEFF &&
                pLastChar->GetCharType() == FX_CHARTYPE_ArabicAlef);
       int32_t iLastRotation = pLastChar->m_nRotation + m_iLineRotation;
       if (m_bVertical && (pLastChar->m_dwCharProps & 0x8000) != 0) {
         iLastRotation++;
       }
       if (m_bVertical != FX_IsOdd(iLastRotation)) {
         iCharWidth = 1000;
       } else {
         m_pFont->GetCharWidth(wForm, iCharWidth, FALSE);
       }
       if (wForm == 0xFEFF) {
         iCharWidth = m_iDefChar;
       }
       iCharWidth *= m_iFontSize;
       iCharWidth = iCharWidth * m_iHorScale / 100;
       pLastChar->m_iCharWidth = iCharWidth;
       iLineWidth += iCharWidth;
       iCharWidth = 0;
     }
   }
   m_eCharType = chartype;
-  wForm = pdfium::arabic::GetFormChar(pCurChar, bAlef ? NULL : pLastChar, NULL);
+  wForm = pdfium::arabic::GetFormChar(pCurChar, bAlef ? nullptr : pLastChar,
+                                      nullptr);
   if (m_bCombText) {
     iCharWidth = m_iCombWidth;
   } else {
     if (m_bVertical != FX_IsOdd(iRotation)) {
       iCharWidth = 1000;
     } else {
       m_pFont->GetCharWidth(wForm, iCharWidth, FALSE);
     }
     if (wForm == 0xFEFF) {
       iCharWidth = m_iDefChar;
@@ skipping 73 matching lines @@
   pCurChar->m_dwCharProps = dwProps;
   pCurChar->m_dwCharStyles = 0;
   pCurChar->m_iCharWidth = 0;
   pCurChar->m_iHorizontalScale = m_iHorScale;
   pCurChar->m_iVertialScale = m_iVerScale;
   pCurChar->m_dwStatus = 0;
   pCurChar->m_iBidiClass = 0;
   pCurChar->m_iBidiLevel = 0;
   pCurChar->m_iBidiPos = 0;
   pCurChar->m_iBidiOrder = 0;
-  pCurChar->m_pUserData = NULL;
+  pCurChar->m_pUserData = nullptr;
   AppendChar_PageLoad(pCurChar, dwProps);
   uint32_t dwRet1 = FX_TXTBREAK_None;
   if (chartype != FX_CHARTYPE_Combination &&
       GetUnifiedCharType(m_eCharType) != GetUnifiedCharType(chartype)) {
     if (m_eCharType != FX_CHARTYPE_Unknown &&
         m_pCurLine->m_iWidth > m_iLineWidth + m_iTolerance && !m_bSingleLine) {
       if (m_eCharType != FX_CHARTYPE_Space || chartype != FX_CHARTYPE_Control) {
         dwRet1 = EndBreak(FX_TXTBREAK_LineBreak);
         int32_t iCount = m_pCurLine->CountChars();
         if (iCount > 0) {
@@ skipping 24 matching lines @@
   pCur = m_pCurLine->GetCharPtr(1);
   FX_WCHAR wch, wForm;
   FX_BOOL bNextNum;
   int32_t i = 1, iCharWidth, iRotation;
   do {
     i++;
     if (i < iCount) {
       pNext = m_pCurLine->GetCharPtr(i);
       bNextNum = (pNext->m_dwCharStyles & FX_TXTCHARSTYLE_ArabicIndic) != 0;
     } else {
-      pNext = NULL;
+      pNext = nullptr;
       bNextNum = FALSE;
     }
     wch = pCur->m_wCharCode;
     if (wch == L'.') {
       if (bPrevNum && bNextNum) {
         iRotation = m_iRotation;
         if (m_bVertical && (pCur->m_dwCharProps & 0x8000) != 0) {
           iRotation = ((iRotation + 1) & 0x03);
         }
         wForm = wch == L'.' ? 0x066B : 0x066C;
@@ skipping 272 matching lines @@
   if (iCount > 0) {
     CFX_TxtPiece* pLastPiece = pCurPieces->GetPtrAt(--iCount);
     if (dwStatus > FX_TXTBREAK_PieceBreak) {
       pLastPiece->m_dwStatus = dwStatus;
     } else {
       dwStatus = pLastPiece->m_dwStatus;
     }
     return dwStatus;
   } else {
     CFX_TxtLine* pLastLine = GetTxtLine(TRUE);
-    if (pLastLine != NULL) {
+    if (pLastLine) {
       pCurPieces = pLastLine->m_pLinePieces;
       iCount = pCurPieces->GetSize();
       if (iCount-- > 0) {
         CFX_TxtPiece* pLastPiece = pCurPieces->GetPtrAt(iCount);
         if (dwStatus > FX_TXTBREAK_PieceBreak) {
           pLastPiece->m_dwStatus = dwStatus;
         } else {
           dwStatus = pLastPiece->m_dwStatus;
         }
         return dwStatus;
@@ skipping 132 matching lines @@
   }
   if (iLast > -1) {
     iEndPos = iLastPos;
     return iLast;
   }
   return 0;
 }
 void CFX_TxtBreak::SplitTextLine(CFX_TxtLine* pCurLine,
                                  CFX_TxtLine* pNextLine,
                                  FX_BOOL bAllChars) {
-  ASSERT(pCurLine != NULL && pNextLine != NULL);
   int32_t iCount = pCurLine->CountChars();
   if (iCount < 2) {
     return;
   }
   int32_t iEndPos = pCurLine->m_iWidth;
   CFX_TxtCharArray& curChars = *pCurLine->m_pLineChars;
   int32_t iCharPos = GetBreakPos(curChars, iEndPos, bAllChars, FALSE);
   if (iCharPos < 0) {
     iCharPos = 0;
   }
@@ skipping 29 matching lines @@
     }
     if (m_bPagination) {
       continue;
     }
     pTC->m_dwStatus = 0;
   }
   pNextLine->m_iWidth = iWidth;
 }
 int32_t CFX_TxtBreak::CountBreakChars() const {
   CFX_TxtLine* pTxtLine = GetTxtLine(TRUE);
-  return pTxtLine == NULL ? 0 : pTxtLine->CountChars();
+  return pTxtLine ? pTxtLine->CountChars() : 0;
 }
 int32_t CFX_TxtBreak::CountBreakPieces() const {
   CFX_TxtPieceArray* pTxtPieces = GetTxtPieces(TRUE);
-  if (pTxtPieces == NULL) {
-    return 0;
-  }
-  return pTxtPieces->GetSize();
+  return pTxtPieces ? pTxtPieces->GetSize() : 0;
 }
 const CFX_TxtPiece* CFX_TxtBreak::GetBreakPiece(int32_t index) const {
   CFX_TxtPieceArray* pTxtPieces = GetTxtPieces(TRUE);
-  if (pTxtPieces == NULL) {
-    return NULL;
-  }
-  if (index < 0 || index >= pTxtPieces->GetSize()) {
-    return NULL;
-  }
+  if (!pTxtPieces)
+    return nullptr;
+  if (index < 0 || index >= pTxtPieces->GetSize())
+    return nullptr;
   return pTxtPieces->GetPtrAt(index);
 }
 void CFX_TxtBreak::ClearBreakPieces() {
   CFX_TxtLine* pTxtLine = GetTxtLine(TRUE);
-  if (pTxtLine != NULL) {
+  if (pTxtLine)
     pTxtLine->RemoveAll(TRUE);
-  }
   m_iReady = 0;
 }
 void CFX_TxtBreak::Reset() {
   m_eCharType = FX_CHARTYPE_Unknown;
   m_iArabicContext = m_iCurArabicContext = 1;
   ResetArabicContext();
   m_pTxtLine1->RemoveAll(TRUE);
   m_pTxtLine2->RemoveAll(TRUE);
 }
 
 struct FX_FORMCHAR {
   uint16_t wch;
   uint16_t wForm;
   int32_t iWidth;
 };
 
 int32_t CFX_TxtBreak::GetDisplayPos(const FX_TXTRUN* pTxtRun,
                                     FXTEXT_CHARPOS* pCharPos,
                                     FX_BOOL bCharCode,
                                     CFX_WideString* pWSForms,
                                     FX_AdjustCharDisplayPos pAdjustPos) const {
-  if (pTxtRun == NULL || pTxtRun->iLength < 1) {
+  if (!pTxtRun || pTxtRun->iLength < 1)
     return 0;
-  }
+
   IFX_TxtAccess* pAccess = pTxtRun->pAccess;
   void* pIdentity = pTxtRun->pIdentity;
   const FX_WCHAR* pStr = pTxtRun->wsStr.c_str();
   int32_t* pWidths = pTxtRun->pWidths;
   int32_t iLength = pTxtRun->iLength - 1;
   IFGAS_Font* pFont = pTxtRun->pFont;
   uint32_t dwStyles = pTxtRun->dwStyles;
   CFX_RectF rtText(*pTxtRun->pRect);
   FX_BOOL bRTLPiece =
       (pTxtRun->dwCharStyles & FX_TXTCHARSTYLE_OddBidiLevel) != 0;
@@ skipping 34 matching lines @@
   int32_t iNext = 0;
   FX_WCHAR wPrev = 0xFEFF;
   FX_WCHAR wNext = 0xFEFF;
   FX_WCHAR wForm = 0xFEFF;
   FX_WCHAR wLast = 0xFEFF;
   FX_BOOL bShadda = FALSE;
   FX_BOOL bLam = FALSE;
   for (int32_t i = 0; i <= iLength; i++) {
     int32_t iWidth;
     FX_WCHAR wch;
-    if (pAccess != NULL) {
+    if (pAccess) {
       wch = pAccess->GetChar(pIdentity, i);
       iWidth = pAccess->GetWidth(pIdentity, i);
     } else {
       wch = *pStr++;
       iWidth = *pWidths++;
     }
     uint32_t dwProps = FX_GetUnicodeProperties(wch);
     FX_CHARTYPE chartype = GetCharTypeFromProp(dwProps);
     if (chartype == FX_CHARTYPE_ArabicAlef && iWidth == 0) {
       wPrev = 0xFEFF;
       wLast = wch;
       continue;
     }
     if (chartype >= FX_CHARTYPE_ArabicAlef) {
       if (i < iLength) {
-        if (pAccess != NULL) {
+        if (pAccess) {
           iNext = i + 1;
           while (iNext <= iLength) {
             wNext = pAccess->GetChar(pIdentity, iNext);
             dwProps = FX_GetUnicodeProperties(wNext);
             if ((dwProps & FX_CHARTYPEBITSMASK) != FX_CHARTYPE_Combination) {
               break;
             }
             iNext++;
           }
           if (iNext > iLength) {
@@ skipping 19 matching lines @@
       wForm = pdfium::arabic::GetFormChar(wch, wPrev, wNext);
       bLam = (wPrev == 0x0644 && wch == 0x0644 && wNext == 0x0647);
     } else if (chartype == FX_CHARTYPE_Combination) {
       wForm = wch;
       if (wch >= 0x064C && wch <= 0x0651) {
         if (bShadda) {
           wForm = 0xFEFF;
           bShadda = FALSE;
         } else {
           wNext = 0xFEFF;
-          if (pAccess != NULL) {
+          if (pAccess) {
             iNext = i + 1;
             if (iNext <= iLength) {
               wNext = pAccess->GetChar(pIdentity, iNext);
             }
           } else {
             if (i < iLength) {
               wNext = *pStr;
             }
           }
           if (wch == 0x0651) {
@@ skipping 13 matching lines @@
       }
     } else if (chartype == FX_CHARTYPE_Numeric) {
       wForm = wch;
       if (bArabicNumber) {
         wForm += 0x0630;
       }
     } else if (wch == L'.') {
       wForm = wch;
       if (bArabicNumber) {
         wNext = 0xFEFF;
-        if (pAccess != NULL) {
+        if (pAccess) {
           iNext = i + 1;
           if (iNext <= iLength) {
             wNext = pAccess->GetChar(pIdentity, iNext);
           }
         } else {
           if (i < iLength) {
             wNext = *pStr;
           }
         }
         if (wNext >= L'0' && wNext <= L'9') {
@@ skipping 22 matching lines @@
       iCharRotation++;
     }
     iCharRotation %= 4;
     FX_BOOL bEmptyChar =
         (chartype >= FX_CHARTYPE_Tab && chartype <= FX_CHARTYPE_Control);
     if (wForm == 0xFEFF) {
       bEmptyChar = TRUE;
     }
     int32_t iForms = bLam ? 3 : 1;
     iCount += (bEmptyChar && bSkipSpace) ? 0 : iForms;
-    if (pCharPos == NULL) {
+    if (!pCharPos) {
       if (iWidth > 0) {
         wPrev = wch;
       }
       wLast = wch;
       continue;
     }
     int32_t iCharWidth = iWidth;
     if (iCharWidth < 0) {
       iCharWidth = -iCharWidth;
     }
@@ skipping 174 matching lines @@
     if (iWidth > 0) {
       wPrev = (FX_WCHAR)formChars[0].wch;
     }
     wLast = wch;
   }
   return iCount;
 }
 int32_t CFX_TxtBreak::GetCharRects(const FX_TXTRUN* pTxtRun,
                                    CFX_RectFArray& rtArray,
                                    FX_BOOL bCharBBox) const {
-  if (pTxtRun == NULL || pTxtRun->iLength < 1) {
+  if (!pTxtRun || pTxtRun->iLength < 1)
     return 0;
-  }
+
   IFX_TxtAccess* pAccess = pTxtRun->pAccess;
   void* pIdentity = pTxtRun->pIdentity;
   const FX_WCHAR* pStr = pTxtRun->wsStr.c_str();
   int32_t* pWidths = pTxtRun->pWidths;
   int32_t iLength = pTxtRun->iLength;
   CFX_RectF rect(*pTxtRun->pRect);
   FX_BOOL bRTLPiece =
       (pTxtRun->dwCharStyles & FX_TXTCHARSTYLE_OddBidiLevel) != 0;
   FX_FLOAT fFontSize = pTxtRun->fFontSize;
   int32_t iFontSize = FXSYS_round(fFontSize * 20.0f);
   FX_FLOAT fScale = fFontSize / 1000.0f;
   IFGAS_Font* pFont = pTxtRun->pFont;
-  if (pFont == NULL) {
+  if (!pFont)
     bCharBBox = FALSE;
-  }
+
   CFX_Rect bbox;
   bbox.Set(0, 0, 0, 0);
   if (bCharBBox) {
     bCharBBox = pFont->GetBBox(bbox);
   }
   FX_FLOAT fLeft = std::max(0.0f, bbox.left * fScale);
   FX_FLOAT fHeight = FXSYS_fabs(bbox.height * fScale);
   rtArray.RemoveAll();
   rtArray.SetSize(iLength);
   FX_BOOL bVertical =
       (pTxtRun->dwStyles & FX_TXTLAYOUTSTYLE_VerticalLayout) != 0;
   FX_BOOL bSingleLine = (pTxtRun->dwStyles & FX_TXTLAYOUTSTYLE_SingleLine) != 0;
   FX_BOOL bCombText = (pTxtRun->dwStyles & FX_TXTLAYOUTSTYLE_CombText) != 0;
   FX_WCHAR wch, wLineBreakChar = pTxtRun->wLineBreakChar;
   int32_t iCharSize;
   FX_FLOAT fCharSize, fStart;
   if (bVertical) {
     fStart = bRTLPiece ? rect.bottom() : rect.top;
   } else {
     fStart = bRTLPiece ? rect.right() : rect.left;
   }
   for (int32_t i = 0; i < iLength; i++) {
-    if (pAccess != NULL) {
+    if (pAccess) {
       wch = pAccess->GetChar(pIdentity, i);
       iCharSize = pAccess->GetWidth(pIdentity, i);
     } else {
       wch = *pStr++;
       iCharSize = *pWidths++;
     }
     fCharSize = (FX_FLOAT)iCharSize / 20000.0f;
     FX_BOOL bRet = (!bSingleLine && FX_IsCtrlCode(wch));
     if (!(wch == L'\v' || wch == L'\f' || wch == 0x2028 || wch == 0x2029 ||
           (wLineBreakChar != 0xFEFF && wch == wLineBreakChar))) {
@@ skipping 47 matching lines @@
         rtBBoxF.height = fHeight;
         rtBBoxF.top = std::max(rtBBoxF.top, 0.0f);
       }
       rtArray.SetAt(i, rtBBoxF);
       continue;
     }
     rtArray.SetAt(i, rect);
   }
   return iLength;
 }