Get rid of NULLs in xfa/

xfa/fgas/font/fgas_gefont.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fgas/font/fgas_gefont.h"
 
 #include "xfa/fgas/crt/fgas_codepage.h"
 #include "xfa/fgas/font/fgas_fontutils.h"
 #include "xfa/fxfa/include/xfa_fontmgr.h"
 
 IFGAS_Font* IFGAS_Font::LoadFont(const FX_WCHAR* pszFontFamily,
                                  uint32_t dwFontStyles,
                                  uint16_t wCodePage,
                                  IFGAS_FontMgr* pFontMgr) {
 #if _FXM_PLATFORM_ != _FXM_PLATFORM_WINDOWS_
-  if (NULL != pFontMgr) {
+  if (pFontMgr)
     return pFontMgr->GetFontByCodePage(wCodePage, dwFontStyles, pszFontFamily);
-  }
-  return NULL;
+  return nullptr;
 #else
   CFGAS_GEFont* pFont = new CFGAS_GEFont(pFontMgr);
   if (!pFont->LoadFont(pszFontFamily, dwFontStyles, wCodePage)) {
     pFont->Release();
-    return NULL;
+    return nullptr;
   }
   return pFont;
 #endif
 }
 IFGAS_Font* IFGAS_Font::LoadFont(const uint8_t* pBuffer,
                                  int32_t iLength,
                                  IFGAS_FontMgr* pFontMgr) {
 #if _FXM_PLATFORM_ != _FXM_PLATFORM_WINDOWS_
-  if (NULL != pFontMgr) {
-    return pFontMgr->LoadFont(pBuffer, iLength, 0, NULL);
-  }
-  return NULL;
+  if (pFontMgr)
+    return pFontMgr->LoadFont(pBuffer, iLength, 0, nullptr);
+  return nullptr;
 #else
   CFGAS_GEFont* pFont = new CFGAS_GEFont(pFontMgr);
   if (!pFont->LoadFont(pBuffer, iLength)) {
     pFont->Release();
-    return NULL;
+    return nullptr;
   }
   return pFont;
 #endif
 }
 IFGAS_Font* IFGAS_Font::LoadFont(const FX_WCHAR* pszFileName,
                                  IFGAS_FontMgr* pFontMgr) {
 #if _FXM_PLATFORM_ != _FXM_PLATFORM_WINDOWS_
-  if (NULL != pFontMgr) {
-    return pFontMgr->LoadFont(pszFileName, 0, NULL);
-  }
-  return NULL;
+  if (pFontMgr)
+    return pFontMgr->LoadFont(pszFileName, 0, nullptr);
+  return nullptr;
 #else
   CFGAS_GEFont* pFont = new CFGAS_GEFont(pFontMgr);
   if (!pFont->LoadFont(pszFileName)) {
     pFont->Release();
-    return NULL;
+    return nullptr;
   }
   return pFont;
 #endif
 }
 IFGAS_Font* IFGAS_Font::LoadFont(IFX_Stream* pFontStream,
                                  IFGAS_FontMgr* pFontMgr,
                                  FX_BOOL bSaveStream) {
 #if _FXM_PLATFORM_ != _FXM_PLATFORM_WINDOWS_
-  if (NULL != pFontMgr) {
-    return pFontMgr->LoadFont(pFontStream, 0, NULL);
-  }
-  return NULL;
+  if (pFontMgr)
+    return pFontMgr->LoadFont(pFontStream, 0, nullptr);
+  return nullptr;
 #else
   CFGAS_GEFont* pFont = new CFGAS_GEFont(pFontMgr);
   if (!pFont->LoadFont(pFontStream, bSaveStream)) {
     pFont->Release();
-    return NULL;
+    return nullptr;
   }
   return pFont;
 #endif
 }
 IFGAS_Font* IFGAS_Font::LoadFont(CFX_Font* pExtFont,
                                  IFGAS_FontMgr* pFontMgr,
                                  FX_BOOL bTakeOver) {
   CFGAS_GEFont* pFont = new CFGAS_GEFont(pFontMgr);
   if (!pFont->LoadFont(pExtFont, bTakeOver)) {
     pFont->Release();
-    return NULL;
+    return nullptr;
   }
   return pFont;
 }
 
 CFGAS_GEFont::CFGAS_GEFont(IFGAS_FontMgr* pFontMgr)
     :
 #if _FXM_PLATFORM_ != _FXM_PLATFORM_WINDOWS_
       m_bUseLogFontStyle(FALSE),
       m_dwLogFontStyle(0),
 #endif
-      m_pFont(NULL),
+      m_pFont(nullptr),
       m_pFontMgr(pFontMgr),
       m_iRefCount(1),
       m_bExtFont(FALSE),
-      m_pStream(NULL),
-      m_pFileRead(NULL),
-      m_pFontEncoding(NULL),
-      m_pCharWidthMap(NULL),
-      m_pRectArray(NULL),
-      m_pBBoxMap(NULL),
-      m_pProvider(NULL),
+      m_pStream(nullptr),
+      m_pFileRead(nullptr),
+      m_pFontEncoding(nullptr),
+      m_pCharWidthMap(nullptr),
+      m_pRectArray(nullptr),
+      m_pBBoxMap(nullptr),
+      m_pProvider(nullptr),
       m_wCharSet(0xFFFF) {
 }
 
 CFGAS_GEFont::CFGAS_GEFont(const CFGAS_GEFont& src, uint32_t dwFontStyles)
     :
 #if _FXM_PLATFORM_ != _FXM_PLATFORM_WINDOWS_
       m_bUseLogFontStyle(FALSE),
       m_dwLogFontStyle(0),
 #endif
-      m_pFont(NULL),
+      m_pFont(nullptr),
       m_pFontMgr(src.m_pFontMgr),
       m_iRefCount(1),
       m_bExtFont(FALSE),
-      m_pStream(NULL),
-      m_pFileRead(NULL),
-      m_pFontEncoding(NULL),
-      m_pCharWidthMap(NULL),
-      m_pRectArray(NULL),
-      m_pBBoxMap(NULL),
-      m_pProvider(NULL),
+      m_pStream(nullptr),
+      m_pFileRead(nullptr),
+      m_pFontEncoding(nullptr),
+      m_pCharWidthMap(nullptr),
+      m_pRectArray(nullptr),
+      m_pBBoxMap(nullptr),
+      m_pProvider(nullptr),
       m_wCharSet(0xFFFF) {
   ASSERT(src.m_pFont);
   m_pFont = new CFX_Font;
   m_pFont->LoadClone(src.m_pFont);
   CFX_SubstFont* pSubst = m_pFont->GetSubstFont();
   if (!pSubst) {
     pSubst = new CFX_SubstFont;
     m_pFont->SetSubstFont(pSubst);
   }
   pSubst->m_Weight =
@@ skipping 19 matching lines @@
   delete m_pFontEncoding;
   delete m_pCharWidthMap;
   delete m_pRectArray;
   delete m_pBBoxMap;
   if (!m_bExtFont)
     delete m_pFont;
 }
 
 void CFGAS_GEFont::Release() {
   if (--m_iRefCount < 1) {
-    if (m_pFontMgr != NULL) {
+    if (m_pFontMgr)
       m_pFontMgr->RemoveFont(this);
-    }
     delete this;
   }
 }
 IFGAS_Font* CFGAS_GEFont::Retain() {
   ++m_iRefCount;
   return this;
 }
 FX_BOOL CFGAS_GEFont::LoadFont(const FX_WCHAR* pszFontFamily,
                                uint32_t dwFontStyles,
                                uint16_t wCodePage) {
   if (m_pFont) {
     return FALSE;
   }
   CFX_ByteString csFontFamily;
-  if (pszFontFamily != NULL) {
+  if (pszFontFamily)
     csFontFamily = CFX_ByteString::FromUnicode(pszFontFamily);
-  }
   uint32_t dwFlags = 0;
   if (dwFontStyles & FX_FONTSTYLE_FixedPitch) {
     dwFlags |= FXFONT_FIXED_PITCH;
   }
   if (dwFontStyles & FX_FONTSTYLE_Serif) {
     dwFlags |= FXFONT_SERIF;
   }
   if (dwFontStyles & FX_FONTSTYLE_Symbolic) {
     dwFlags |= FXFONT_SYMBOLIC;
   }
@@ skipping 18 matching lines @@
   m_wCharSet = wCharSet;
   m_pFont = new CFX_Font;
   if ((dwFlags & FXFONT_ITALIC) && (dwFlags & FXFONT_BOLD)) {
     csFontFamily += ",BoldItalic";
   } else if (dwFlags & FXFONT_BOLD) {
     csFontFamily += ",Bold";
   } else if (dwFlags & FXFONT_ITALIC) {
     csFontFamily += ",Italic";
   }
   m_pFont->LoadSubst(csFontFamily, TRUE, dwFlags, iWeight, 0, wCodePage);
-  FX_BOOL bRet = m_pFont->GetFace() != nullptr;
-  if (bRet) {
-    bRet = InitFont();
-  }
-  return bRet;
+  if (!m_pFont->GetFace())
+    return FALSE;
+
+  return InitFont();
 }
 FX_BOOL CFGAS_GEFont::LoadFont(const uint8_t* pBuffer, int32_t length) {
   if (m_pFont) {
     return FALSE;
   }
   m_pFont = new CFX_Font;
   FX_BOOL bRet = m_pFont->LoadEmbedded(pBuffer, length);
   if (bRet) {
     bRet = InitFont();
   }
@@ skipping 91 matching lines @@
   if (!m_pFont->GetSubstFont() ||
       m_pFont->GetSubstFont()->m_Family.GetLength() == 0) {
     wsFamily = CFX_WideString::FromLocal(m_pFont->GetFamilyName().AsStringC());
   } else {
     wsFamily = CFX_WideString::FromLocal(
         m_pFont->GetSubstFont()->m_Family.AsStringC());
   }
 }
 
 uint32_t CFGAS_GEFont::GetFontStyles() const {
-  ASSERT(m_pFont != NULL);
+  ASSERT(m_pFont);
 #if _FXM_PLATFORM_ != _FXM_PLATFORM_WINDOWS_
   if (m_bUseLogFontStyle) {
     return m_dwLogFontStyle;
   }
 #endif
   uint32_t dwStyles = 0;
   if (!m_pFont->GetSubstFont()) {
     if (m_pFont->IsBold()) {
       dwStyles |= FX_FONTSTYLE_Bold;
     }
@@ skipping 12 matching lines @@
 }
 FX_BOOL CFGAS_GEFont::GetCharWidth(FX_WCHAR wUnicode,
                                    int32_t& iWidth,
                                    FX_BOOL bCharCode) {
   return GetCharWidth(wUnicode, iWidth, TRUE, bCharCode);
 }
 FX_BOOL CFGAS_GEFont::GetCharWidth(FX_WCHAR wUnicode,
                                    int32_t& iWidth,
                                    FX_BOOL bRecursive,
                                    FX_BOOL bCharCode) {
-  ASSERT(m_pCharWidthMap != NULL);
   iWidth = m_pCharWidthMap->GetAt(wUnicode, 0);
   if (iWidth < 1) {
     if (!m_pProvider ||
         !m_pProvider->GetCharWidth(this, wUnicode, iWidth, bCharCode)) {
-      IFGAS_Font* pFont = NULL;
+      IFGAS_Font* pFont = nullptr;
       int32_t iGlyph = GetGlyphIndex(wUnicode, TRUE, &pFont, bCharCode);
-      if (iGlyph != 0xFFFF && pFont != NULL) {
+      if (iGlyph != 0xFFFF && pFont) {
         if (pFont == (IFGAS_Font*)this) {
           iWidth = m_pFont->GetGlyphWidth(iGlyph);
           if (iWidth < 0) {
             iWidth = -1;
           }
         } else if (((CFGAS_GEFont*)pFont)
                        ->GetCharWidth(wUnicode, iWidth, FALSE, bCharCode)) {
           return TRUE;
         }
       } else {
         iWidth = -1;
       }
     }
     m_pCharWidthMap->SetAtGrow(wUnicode, (int16_t)iWidth);
   } else if (iWidth == 65535) {
     iWidth = -1;
   }
   return iWidth > 0;
 }
 FX_BOOL CFGAS_GEFont::GetCharBBox(FX_WCHAR wUnicode,
                                   CFX_Rect& bbox,
                                   FX_BOOL bCharCode) {
   return GetCharBBox(wUnicode, bbox, TRUE, bCharCode);
 }
 FX_BOOL CFGAS_GEFont::GetCharBBox(FX_WCHAR wUnicode,
                                   CFX_Rect& bbox,
                                   FX_BOOL bRecursive,
                                   FX_BOOL bCharCode) {
-  ASSERT(m_pRectArray != NULL);
-  ASSERT(m_pBBoxMap != NULL);
-  void* pRect = NULL;
+  void* pRect = nullptr;
   if (!m_pBBoxMap->Lookup((void*)(uintptr_t)wUnicode, pRect)) {
-    IFGAS_Font* pFont = NULL;
+    IFGAS_Font* pFont = nullptr;
     int32_t iGlyph = GetGlyphIndex(wUnicode, TRUE, &pFont, bCharCode);
-    if (iGlyph != 0xFFFF && pFont != NULL) {
+    if (iGlyph != 0xFFFF && pFont) {
       if (pFont == (IFGAS_Font*)this) {
         FX_RECT rtBBox;
         if (m_pFont->GetGlyphBBox(iGlyph, rtBBox)) {
           CFX_Rect rt;
           rt.Set(rtBBox.left, rtBBox.top, rtBBox.Width(), rtBBox.Height());
           int32_t index = m_pRectArray->Add(rt);
           pRect = m_pRectArray->GetPtrAt(index);
           m_pBBoxMap->SetAt((void*)(uintptr_t)wUnicode, pRect);
         }
       } else if (((CFGAS_GEFont*)pFont)
@@ skipping 19 matching lines @@
   }
   return bRet;
 }
 int32_t CFGAS_GEFont::GetItalicAngle() const {
   if (!m_pFont->GetSubstFont()) {
     return 0;
   }
   return m_pFont->GetSubstFont()->m_ItalicAngle;
 }
 int32_t CFGAS_GEFont::GetGlyphIndex(FX_WCHAR wUnicode, FX_BOOL bCharCode) {
-  return GetGlyphIndex(wUnicode, TRUE, NULL, bCharCode);
+  return GetGlyphIndex(wUnicode, TRUE, nullptr, bCharCode);
 }
 int32_t CFGAS_GEFont::GetGlyphIndex(FX_WCHAR wUnicode,
                                     FX_BOOL bRecursive,
                                     IFGAS_Font** ppFont,
                                     FX_BOOL bCharCode) {
-  ASSERT(m_pFontEncoding != NULL);
   int32_t iGlyphIndex = m_pFontEncoding->GlyphFromCharCode(wUnicode);
   if (iGlyphIndex > 0) {
-    if (ppFont != NULL) {
+    if (ppFont)
       *ppFont = (IFGAS_Font*)this;
-    }
     return iGlyphIndex;
   }
   const FGAS_FONTUSB* pFontUSB = FGAS_GetUnicodeBitField(wUnicode);
-  if (pFontUSB == NULL) {
+  if (!pFontUSB)
     return 0xFFFF;
-  }
+
   uint16_t wBitField = pFontUSB->wBitField;
   if (wBitField >= 128) {
     return 0xFFFF;
   }
   auto it = m_FontMapper.find(wUnicode);
   IFGAS_Font* pFont = it != m_FontMapper.end() ? it->second : nullptr;
   if (pFont && pFont != this) {
-    iGlyphIndex =
-        ((CFGAS_GEFont*)pFont)->GetGlyphIndex(wUnicode, FALSE, NULL, bCharCode);
+    iGlyphIndex = ((CFGAS_GEFont*)pFont)
+                      ->GetGlyphIndex(wUnicode, FALSE, nullptr, bCharCode);
     if (iGlyphIndex != 0xFFFF) {
       int32_t i = m_SubstFonts.Find(pFont);
       if (i > -1) {
         iGlyphIndex |= ((i + 1) << 24);
         if (ppFont)
           *ppFont = pFont;
         return iGlyphIndex;
       }
     }
   }
   if (m_pFontMgr && bRecursive) {
     CFX_WideString wsFamily;
     GetFamilyName(wsFamily);
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_
     pFont = m_pFontMgr->GetDefFontByUnicode(wUnicode, GetFontStyles(),
                                             wsFamily.c_str());
 #else
     pFont = m_pFontMgr->GetFontByUnicode(wUnicode, GetFontStyles(),
                                          wsFamily.c_str());
     if (!pFont)
-      pFont = m_pFontMgr->GetFontByUnicode(wUnicode, GetFontStyles(), NULL);
+      pFont = m_pFontMgr->GetFontByUnicode(wUnicode, GetFontStyles(), nullptr);
 #endif
     if (pFont) {
       if (pFont == this) {
         pFont->Release();
         return 0xFFFF;
       }
       m_FontMapper[wUnicode] = pFont;
       int32_t i = m_SubstFonts.GetSize();
       m_SubstFonts.Add(pFont);
       iGlyphIndex = ((CFGAS_GEFont*)pFont)
-                        ->GetGlyphIndex(wUnicode, FALSE, NULL, bCharCode);
+                        ->GetGlyphIndex(wUnicode, FALSE, nullptr, bCharCode);
       if (iGlyphIndex != 0xFFFF) {
         iGlyphIndex |= ((i + 1) << 24);
         if (ppFont)
           *ppFont = pFont;
         return iGlyphIndex;
       }
     }
   }
   return 0xFFFF;
 }
 int32_t CFGAS_GEFont::GetAscent() const {
   return m_pFont->GetAscent();
 }
 int32_t CFGAS_GEFont::GetDescent() const {
   return m_pFont->GetDescent();
 }
 void CFGAS_GEFont::Reset() {
   int32_t iCount = m_SubstFonts.GetSize();
   for (int32_t i = 0; i < iCount; i++) {
     IFGAS_Font* pFont = m_SubstFonts[i];
     ((CFGAS_GEFont*)pFont)->Reset();
   }
-  if (m_pCharWidthMap != NULL) {
+  if (m_pCharWidthMap)
     m_pCharWidthMap->RemoveAll();
-  }
-  if (m_pBBoxMap != NULL) {
+  if (m_pBBoxMap)
     m_pBBoxMap->RemoveAll();
-  }
-  if (m_pRectArray != NULL) {
+  if (m_pRectArray)
     m_pRectArray->RemoveAll();
-  }
 }
 IFGAS_Font* CFGAS_GEFont::GetSubstFont(int32_t iGlyphIndex) const {
   iGlyphIndex = ((uint32_t)iGlyphIndex) >> 24;
   return iGlyphIndex == 0 ? const_cast<CFGAS_GEFont*>(this)
                           : m_SubstFonts[iGlyphIndex - 1];
 }