Get rid of NULLs in xfa/

xfa/fgas/crt/fgas_stream.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fgas/crt/fgas_stream.h"
 
 #if _FX_OS_ == _FX_WIN32_DESKTOP_ || _FX_OS_ == _FX_WIN32_MOBILE_ || \
     _FX_OS_ == _FX_WIN64_
@@ skipping 207 matching lines @@
   virtual IFX_Stream* Retain();
   virtual uint32_t GetAccessModes() const { return m_dwAccess; }
   virtual int32_t GetLength() const;
   virtual int32_t Seek(FX_STREAMSEEK eSeek, int32_t iOffset);
   virtual int32_t GetPosition();
   virtual FX_BOOL IsEOF() const;
   virtual int32_t ReadData(uint8_t* pBuffer, int32_t iBufferSize);
   virtual int32_t ReadString(FX_WCHAR* pStr,
                              int32_t iMaxLength,
                              FX_BOOL& bEOS,
-                             int32_t const* pByteSize = NULL);
+                             int32_t const* pByteSize = nullptr);
   virtual int32_t WriteData(const uint8_t* pBuffer, int32_t iBufferSize);
   virtual int32_t WriteString(const FX_WCHAR* pStr, int32_t iLength);
   virtual void Flush();
   virtual FX_BOOL SetLength(int32_t iLength);
   virtual int32_t GetBOM(uint8_t bom[4]) const;
   virtual uint16_t GetCodePage() const;
   virtual uint16_t SetCodePage(uint16_t wCodePage);
   virtual IFX_Stream* CreateSharedStream(uint32_t dwAccess,
                                          int32_t iOffset,
                                          int32_t iLength);
@@ skipping 19 matching lines @@
   virtual uint32_t GetAccessModes() const;
   virtual int32_t GetLength() const;
   virtual int32_t Seek(FX_STREAMSEEK eSeek, int32_t iOffset);
   virtual int32_t GetPosition();
   virtual FX_BOOL IsEOF() const;
 
   virtual int32_t ReadData(uint8_t* pBuffer, int32_t iBufferSize);
   virtual int32_t ReadString(FX_WCHAR* pStr,
                              int32_t iMaxLength,
                              FX_BOOL& bEOS,
-                             int32_t const* pByteSize = NULL);
+                             int32_t const* pByteSize = nullptr);
   virtual int32_t WriteData(const uint8_t* pBuffer, int32_t iBufferSize);
   virtual int32_t WriteString(const FX_WCHAR* pStr, int32_t iLength);
   virtual void Flush();
   virtual FX_BOOL SetLength(int32_t iLength);
 
   virtual int32_t GetBOM(uint8_t bom[4]) const;
   virtual uint16_t GetCodePage() const;
   virtual uint16_t SetCodePage(uint16_t wCodePage);
 
   virtual IFX_Stream* CreateSharedStream(uint32_t dwAccess,
@@ skipping 19 matching lines @@
   virtual void Release() { delete this; }
   virtual FX_FILESIZE GetSize();
   virtual FX_BOOL ReadBlock(void* buffer, FX_FILESIZE offset, size_t size);
 
  protected:
   FX_BOOL m_bReleaseStream;
   IFX_Stream* m_pStream;
 };
 
 int32_t FileLength(FXSYS_FILE* file) {
-  ASSERT(file != NULL);
+  ASSERT(file);
 #if _FX_OS_ == _FX_WIN32_DESKTOP_ || _FX_OS_ == _FX_WIN64_
   return _filelength(_fileno(file));
 #else
   int32_t iPos = FXSYS_ftell(file);
   FXSYS_fseek(file, 0, FXSYS_SEEK_END);
   int32_t iLen = FXSYS_ftell(file);
   FXSYS_fseek(file, iPos, FXSYS_SEEK_SET);
   return iLen;
 #endif
 }
 
 FX_BOOL FileSetSize(FXSYS_FILE* file, int32_t size) {
-  ASSERT(file != NULL);
+  ASSERT(file);
 #if _FX_OS_ == _FX_WIN32_DESKTOP_ || _FX_OS_ == _FX_WIN64_
   return _chsize(_fileno(file), size) == 0;
 #elif _FX_OS_ == _FX_WIN32_MOBILE_
   HANDLE hFile = _fileno(file);
   uint32_t dwPos = ::SetFilePointer(hFile, 0, 0, FILE_CURRENT);
   ::SetFilePointer(hFile, size, 0, FILE_BEGIN);
   FX_BOOL bRet = ::SetEndOfFile(hFile);
   ::SetFilePointer(hFile, (int32_t)dwPos, 0, FILE_BEGIN);
   return bRet;
 #else
   return FALSE;
 #endif
 }
 
 }  // namespace
 
 IFX_Stream* IFX_Stream::CreateStream(IFX_BufferRead* pBufferRead,
                                      uint32_t dwAccess,
                                      int32_t iFileSize,
                                      FX_BOOL bReleaseBufferRead) {
   CFX_Stream* pSR = new CFX_Stream;
   if (!pSR->LoadBufferRead(pBufferRead, iFileSize, dwAccess,
                            bReleaseBufferRead)) {
     pSR->Release();
-    return NULL;
+    return nullptr;
   }
   if (dwAccess & FX_STREAMACCESS_Text) {
     return new CFX_TextStream(pSR, TRUE);
   }
   return pSR;
 }
 IFX_Stream* IFX_Stream::CreateStream(IFX_FileRead* pFileRead,
                                      uint32_t dwAccess) {
   CFX_Stream* pSR = new CFX_Stream;
   if (!pSR->LoadFileRead(pFileRead, dwAccess)) {
     pSR->Release();
-    return NULL;
+    return nullptr;
   }
   if (dwAccess & FX_STREAMACCESS_Text) {
     return new CFX_TextStream(pSR, TRUE);
   }
   return pSR;
 }
 IFX_Stream* IFX_Stream::CreateStream(IFX_FileWrite* pFileWrite,
                                      uint32_t dwAccess) {
   CFX_Stream* pSR = new CFX_Stream;
   if (!pSR->LoadFileWrite(pFileWrite, dwAccess)) {
     pSR->Release();
-    return NULL;
+    return nullptr;
   }
   if (dwAccess & FX_STREAMACCESS_Text) {
     return new CFX_TextStream(pSR, TRUE);
   }
   return pSR;
 }
 IFX_Stream* IFX_Stream::CreateStream(const FX_WCHAR* pszFileName,
                                      uint32_t dwAccess) {
   CFX_Stream* pSR = new CFX_Stream;
   if (!pSR->LoadFile(pszFileName, dwAccess)) {
     pSR->Release();
-    return NULL;
+    return nullptr;
   }
   if (dwAccess & FX_STREAMACCESS_Text) {
     return new CFX_TextStream(pSR, TRUE);
   }
   return pSR;
 }
 IFX_Stream* IFX_Stream::CreateStream(uint8_t* pData,
                                      int32_t length,
                                      uint32_t dwAccess) {
   CFX_Stream* pSR = new CFX_Stream;
   if (!pSR->LoadBuffer(pData, length, dwAccess)) {
     pSR->Release();
-    return NULL;
+    return nullptr;
   }
   if (dwAccess & FX_STREAMACCESS_Text) {
     return new CFX_TextStream(pSR, TRUE);
   }
   return pSR;
 }
 
 IFX_StreamImp::IFX_StreamImp() : m_dwAccess(0) {}
 
 CFX_FileStreamImp::CFX_FileStreamImp() : m_hFile(nullptr), m_iLength(0) {}
 
 CFX_FileStreamImp::~CFX_FileStreamImp() {
   if (m_hFile)
     FXSYS_fclose(m_hFile);
 }
 
 FX_BOOL CFX_FileStreamImp::LoadFile(const FX_WCHAR* pszSrcFileName,
                                     uint32_t dwAccess) {
-  ASSERT(m_hFile == NULL);
-  ASSERT(pszSrcFileName != NULL && FXSYS_wcslen(pszSrcFileName) > 0);
+  ASSERT(!m_hFile);
+  ASSERT(pszSrcFileName && FXSYS_wcslen(pszSrcFileName) > 0);
 #if _FX_OS_ == _FX_WIN32_DESKTOP_ || _FX_OS_ == _FX_WIN32_MOBILE_ || \
     _FX_OS_ == _FX_WIN64_
   const FX_WCHAR* wsMode;
   if (dwAccess & FX_STREAMACCESS_Write) {
     if (dwAccess & FX_STREAMACCESS_Append) {
       wsMode = L"a+b";
     } else if (dwAccess & FX_STREAMACCESS_Truncate) {
       wsMode = L"w+b";
     } else {
       wsMode = L"r+b";
@@ skipping 26 matching lines @@
     if (dwAccess & FX_STREAMACCESS_Append) {
       wsMode = "a+b";
     } else if (dwAccess & FX_STREAMACCESS_Truncate) {
       wsMode = "w+b";
     } else {
       wsMode = "r+b";
     }
   }
   CFX_ByteString szFileName = CFX_ByteString::FromUnicode(pszSrcFileName);
   m_hFile = FXSYS_fopen(szFileName.c_str(), wsMode);
-  if (m_hFile == NULL) {
+  if (!m_hFile) {
     if (dwAccess & FX_STREAMACCESS_Write) {
       if (dwAccess & FX_STREAMACCESS_Create) {
         m_hFile = FXSYS_fopen(szFileName.c_str(), "w+b");
       }
-      if (m_hFile == NULL) {
+      if (!m_hFile) {
         m_hFile = FXSYS_fopen(szFileName.c_str(), "r+b");
-        if (m_hFile == NULL) {
+        if (!m_hFile)
           return FALSE;
-        }
+
         if (dwAccess & FX_STREAMACCESS_Truncate) {
           FileSetSize(m_hFile, 0);
         }
       }
     } else {
       return FALSE;
     }
   }
 #endif
   SetAccessModes(dwAccess);
   if ((dwAccess & (FX_STREAMACCESS_Write | FX_STREAMACCESS_Truncate)) ==
       (FX_STREAMACCESS_Write | FX_STREAMACCESS_Truncate)) {
     m_iLength = 0;
   } else {
     m_iLength = FileLength(m_hFile);
   }
   return TRUE;
 }
 int32_t CFX_FileStreamImp::GetLength() const {
-  ASSERT(m_hFile != NULL);
+  ASSERT(m_hFile);
   return m_iLength;
 }
 int32_t CFX_FileStreamImp::Seek(FX_STREAMSEEK eSeek, int32_t iOffset) {
-  ASSERT(m_hFile != NULL);
+  ASSERT(m_hFile);
   FXSYS_fseek(m_hFile, iOffset, eSeek);
   return FXSYS_ftell(m_hFile);
 }
 int32_t CFX_FileStreamImp::GetPosition() {
-  ASSERT(m_hFile != NULL);
+  ASSERT(m_hFile);
   return FXSYS_ftell(m_hFile);
 }
 FX_BOOL CFX_FileStreamImp::IsEOF() const {
-  ASSERT(m_hFile != NULL);
+  ASSERT(m_hFile);
   return FXSYS_ftell(m_hFile) >= m_iLength;
 }
 int32_t CFX_FileStreamImp::ReadData(uint8_t* pBuffer, int32_t iBufferSize) {
-  ASSERT(m_hFile != NULL);
-  ASSERT(pBuffer != NULL && iBufferSize > 0);
+  ASSERT(m_hFile);
+  ASSERT(pBuffer && iBufferSize > 0);
   return FXSYS_fread(pBuffer, 1, iBufferSize, m_hFile);
 }
 int32_t CFX_FileStreamImp::ReadString(FX_WCHAR* pStr,
                                       int32_t iMaxLength,
                                       FX_BOOL& bEOS) {
-  ASSERT(m_hFile != NULL);
-  ASSERT(pStr != NULL && iMaxLength > 0);
+  ASSERT(m_hFile);
+  ASSERT(pStr && iMaxLength > 0);
   if (m_iLength <= 0) {
     return 0;
   }
   int32_t iPosition = FXSYS_ftell(m_hFile);
   int32_t iLen = std::min((m_iLength - iPosition) / 2, iMaxLength);
   if (iLen <= 0) {
     return 0;
   }
   iLen = FXSYS_fread(pStr, 2, iLen, m_hFile);
   int32_t iCount = 0;
@@ skipping 36 matching lines @@
   ASSERT(m_hFile && (GetAccessModes() & FX_STREAMACCESS_Write) != 0);
   FXSYS_fflush(m_hFile);
 }
 FX_BOOL CFX_FileStreamImp::SetLength(int32_t iLength) {
   ASSERT(m_hFile && (GetAccessModes() & FX_STREAMACCESS_Write) != 0);
   FX_BOOL bRet = FileSetSize(m_hFile, iLength);
   m_iLength = FileLength(m_hFile);
   return bRet;
 }
 CFX_FileReadStreamImp::CFX_FileReadStreamImp()
-    : m_pFileRead(NULL), m_iPosition(0), m_iLength(0) {}
+    : m_pFileRead(nullptr), m_iPosition(0), m_iLength(0) {}
 FX_BOOL CFX_FileReadStreamImp::LoadFileRead(IFX_FileRead* pFileRead,
                                             uint32_t dwAccess) {
-  ASSERT(m_pFileRead == NULL && pFileRead != NULL);
+  ASSERT(!m_pFileRead && pFileRead);
   if (dwAccess & FX_STREAMACCESS_Write) {
     return FALSE;
   }
   m_pFileRead = pFileRead;
   m_iLength = m_pFileRead->GetSize();
   return TRUE;
 }
 int32_t CFX_FileReadStreamImp::GetLength() const {
   return m_iLength;
 }
@@ skipping 13 matching lines @@
     m_iPosition = 0;
   } else if (m_iPosition >= m_iLength) {
     m_iPosition = m_iLength;
   }
   return m_iPosition;
 }
 FX_BOOL CFX_FileReadStreamImp::IsEOF() const {
   return m_iPosition >= m_iLength;
 }
 int32_t CFX_FileReadStreamImp::ReadData(uint8_t* pBuffer, int32_t iBufferSize) {
-  ASSERT(m_pFileRead != NULL);
-  ASSERT(pBuffer != NULL && iBufferSize > 0);
+  ASSERT(m_pFileRead);
+  ASSERT(pBuffer && iBufferSize > 0);
   if (iBufferSize > m_iLength - m_iPosition) {
     iBufferSize = m_iLength - m_iPosition;
   }
   if (m_pFileRead->ReadBlock(pBuffer, m_iPosition, iBufferSize)) {
     m_iPosition += iBufferSize;
     return iBufferSize;
   }
   return 0;
 }
 int32_t CFX_FileReadStreamImp::ReadString(FX_WCHAR* pStr,
                                           int32_t iMaxLength,
                                           FX_BOOL& bEOS) {
-  ASSERT(m_pFileRead != NULL);
-  ASSERT(pStr != NULL && iMaxLength > 0);
+  ASSERT(m_pFileRead);
+  ASSERT(pStr && iMaxLength > 0);
   iMaxLength = ReadData((uint8_t*)pStr, iMaxLength * 2) / 2;
   if (iMaxLength <= 0) {
     return 0;
   }
   int32_t i = 0;
   while (i < iMaxLength && pStr[i] != L'\0') {
     ++i;
   }
   bEOS = (m_iPosition >= m_iLength) || pStr[i] == L'\0';
   return i;
 }
 CFX_BufferReadStreamImp::CFX_BufferReadStreamImp()
-    : m_pBufferRead(NULL),
+    : m_pBufferRead(nullptr),
       m_bReleaseBufferRead(FALSE),
       m_iPosition(0),
       m_iBufferSize(0) {}
 CFX_BufferReadStreamImp::~CFX_BufferReadStreamImp() {
-  if (m_bReleaseBufferRead && m_pBufferRead != NULL) {
+  if (m_bReleaseBufferRead && m_pBufferRead) {
     m_pBufferRead->Release();
   }
 }
 FX_BOOL CFX_BufferReadStreamImp::LoadBufferRead(IFX_BufferRead* pBufferRead,
                                                 int32_t iFileSize,
                                                 uint32_t dwAccess,
                                                 FX_BOOL bReleaseBufferRead) {
-  ASSERT(m_pBufferRead == NULL && pBufferRead != NULL);
+  ASSERT(!m_pBufferRead && pBufferRead);
   if (dwAccess & FX_STREAMACCESS_Write) {
     return FALSE;
   }
   m_bReleaseBufferRead = bReleaseBufferRead;
   m_pBufferRead = pBufferRead;
   m_iBufferSize = iFileSize;
   if (m_iBufferSize >= 0) {
     return TRUE;
   }
   if (!m_pBufferRead->ReadNextBlock(TRUE)) {
@@ skipping 27 matching lines @@
   } else if (m_iPosition >= iLength) {
     m_iPosition = iLength;
   }
   return m_iPosition;
 }
 FX_BOOL CFX_BufferReadStreamImp::IsEOF() const {
   return m_pBufferRead ? m_pBufferRead->IsEOF() : TRUE;
 }
 int32_t CFX_BufferReadStreamImp::ReadData(uint8_t* pBuffer,
                                           int32_t iBufferSize) {
-  ASSERT(m_pBufferRead != NULL);
-  ASSERT(pBuffer != NULL && iBufferSize > 0);
+  ASSERT(m_pBufferRead);
+  ASSERT(pBuffer && iBufferSize > 0);
   int32_t iLength = GetLength();
   if (m_iPosition >= iLength) {
     return 0;
   }
   if (iBufferSize > iLength - m_iPosition) {
     iBufferSize = iLength - m_iPosition;
   }
   uint32_t dwBlockOffset = m_pBufferRead->GetBlockOffset();
   uint32_t dwBlockSize = m_pBufferRead->GetBlockSize();
   if (m_iPosition < (int32_t)dwBlockOffset) {
@@ skipping 33 matching lines @@
     FXSYS_memcpy(pBuffer + dwOffsetTmp, pBufferTmp, dwCopySize);
     dwOffsetTmp += dwCopySize;
     iBufferSize -= dwCopySize;
   }
   m_iPosition += dwOffsetTmp;
   return dwOffsetTmp;
 }
 int32_t CFX_BufferReadStreamImp::ReadString(FX_WCHAR* pStr,
                                             int32_t iMaxLength,
                                             FX_BOOL& bEOS) {
-  ASSERT(m_pBufferRead != NULL);
-  ASSERT(pStr != NULL && iMaxLength > 0);
+  ASSERT(m_pBufferRead);
+  ASSERT(pStr && iMaxLength > 0);
   iMaxLength = ReadData((uint8_t*)pStr, iMaxLength * 2) / 2;
   if (iMaxLength <= 0) {
     return 0;
   }
   int32_t i = 0;
   while (i < iMaxLength && pStr[i] != L'\0') {
     ++i;
   }
   bEOS = (m_iPosition >= GetLength()) || pStr[i] == L'\0';
   return i;
 }
 CFX_FileWriteStreamImp::CFX_FileWriteStreamImp()
-    : m_pFileWrite(NULL), m_iPosition(0) {}
+    : m_pFileWrite(nullptr), m_iPosition(0) {}
 FX_BOOL CFX_FileWriteStreamImp::LoadFileWrite(IFX_FileWrite* pFileWrite,
                                               uint32_t dwAccess) {
-  ASSERT(m_pFileWrite == NULL && pFileWrite != NULL);
+  ASSERT(!m_pFileWrite && pFileWrite);
   if (dwAccess & FX_STREAMACCESS_Read) {
     return FALSE;
   }
   if (dwAccess & FX_STREAMACCESS_Append) {
     m_iPosition = pFileWrite->GetSize();
   }
   m_pFileWrite = pFileWrite;
   return TRUE;
 }
 int32_t CFX_FileWriteStreamImp::GetLength() const {
@@ skipping 52 matching lines @@
                                         uint32_t dwAccess) {
   ASSERT(!m_pData && pData && iTotalSize > 0);
   SetAccessModes(dwAccess);
   m_pData = pData;
   m_iTotalSize = iTotalSize;
   m_iPosition = 0;
   m_iLength = (dwAccess & FX_STREAMACCESS_Write) != 0 ? 0 : iTotalSize;
   return TRUE;
 }
 int32_t CFX_BufferStreamImp::GetLength() const {
-  ASSERT(m_pData != NULL);
+  ASSERT(m_pData);
   return m_iLength;
 }
 int32_t CFX_BufferStreamImp::Seek(FX_STREAMSEEK eSeek, int32_t iOffset) {
-  ASSERT(m_pData != NULL);
+  ASSERT(m_pData);
   if (eSeek == FX_STREAMSEEK_Begin) {
     m_iPosition = iOffset;
   } else if (eSeek == FX_STREAMSEEK_Current) {
     m_iPosition += iOffset;
   } else if (eSeek == FX_STREAMSEEK_End) {
     m_iPosition = m_iLength + iOffset;
   }
   if (m_iPosition > m_iLength) {
     m_iPosition = m_iLength;
   }
   if (m_iPosition < 0) {
     m_iPosition = 0;
   }
   return m_iPosition;
 }
 int32_t CFX_BufferStreamImp::GetPosition() {
-  ASSERT(m_pData != NULL);
+  ASSERT(m_pData);
   return m_iPosition;
 }
 FX_BOOL CFX_BufferStreamImp::IsEOF() const {
-  ASSERT(m_pData != NULL);
+  ASSERT(m_pData);
   return m_iPosition >= m_iLength;
 }
 int32_t CFX_BufferStreamImp::ReadData(uint8_t* pBuffer, int32_t iBufferSize) {
-  ASSERT(m_pData != NULL);
-  ASSERT(pBuffer != NULL && iBufferSize > 0);
+  ASSERT(m_pData);
+  ASSERT(pBuffer && iBufferSize > 0);
   int32_t iLen = std::min(m_iLength - m_iPosition, iBufferSize);
   if (iLen <= 0) {
     return 0;
   }
   FXSYS_memcpy(pBuffer, m_pData + m_iPosition, iLen);
   m_iPosition += iLen;
   return iLen;
 }
 int32_t CFX_BufferStreamImp::ReadString(FX_WCHAR* pStr,
                                         int32_t iMaxLength,
                                         FX_BOOL& bEOS) {
-  ASSERT(m_pData != NULL);
-  ASSERT(pStr != NULL && iMaxLength > 0);
+  ASSERT(m_pData);
+  ASSERT(pStr && iMaxLength > 0);
   int32_t iLen = std::min((m_iLength - m_iPosition) / 2, iMaxLength);
   if (iLen <= 0) {
     return 0;
   }
   const FX_WCHAR* pSrc = (const FX_WCHAR*)(FX_CHAR*)(m_pData + m_iPosition);
   int32_t iCount = 0;
   while (*pSrc && iCount < iLen) {
     *pStr++ = *pSrc++;
     iCount++;
   }
@@ skipping 26 matching lines @@
   }
   FXSYS_memcpy(m_pData + m_iPosition, pStr, iLen * 2);
   m_iPosition += iLen * 2;
   if (m_iPosition > m_iLength) {
     m_iLength = m_iPosition;
   }
   return iLen;
 }
 IFX_Stream* IFX_Stream::CreateTextStream(IFX_Stream* pBaseStream,
                                          FX_BOOL bDeleteOnRelease) {
-  ASSERT(pBaseStream != NULL);
+  ASSERT(pBaseStream);
   return new CFX_TextStream(pBaseStream, bDeleteOnRelease);
 }
 CFX_TextStream::CFX_TextStream(IFX_Stream* pStream, FX_BOOL bDelStream)
     : m_wCodePage(FX_CODEPAGE_DefANSI),
       m_wBOMLength(0),
       m_dwBOM(0),
-      m_pBuf(NULL),
+      m_pBuf(nullptr),
       m_iBufSize(0),
       m_bDelStream(bDelStream),
       m_pStreamImp(pStream),
       m_iRefCount(1) {
-  ASSERT(m_pStreamImp != NULL);
   m_pStreamImp->Retain();
   InitStream();
 }
 CFX_TextStream::~CFX_TextStream() {
   m_pStreamImp->Release();
   if (m_bDelStream) {
     m_pStreamImp->Release();
   }
-  if (m_pBuf != NULL) {
-    FX_Free(m_pBuf);
-  }
+  FX_Free(m_pBuf);
 }
 void CFX_TextStream::InitStream() {
   int32_t iPosition = m_pStreamImp->GetPosition();
   m_pStreamImp->Seek(FX_STREAMSEEK_Begin, 0);
   m_pStreamImp->ReadData((uint8_t*)&m_dwBOM, 3);
 #if _FX_ENDIAN_ == _FX_LITTLE_ENDIAN_
   m_dwBOM &= 0x00FFFFFF;
   if (m_dwBOM == 0x00BFBBEF) {
     m_wBOMLength = 3;
     m_wCodePage = FX_CODEPAGE_UTF8;
@@ skipping 70 matching lines @@
   return m_pStreamImp->SetLength(iLength);
 }
 uint16_t CFX_TextStream::GetCodePage() const {
   return m_wCodePage;
 }
 IFX_Stream* CFX_TextStream::CreateSharedStream(uint32_t dwAccess,
                                                int32_t iOffset,
                                                int32_t iLength) {
   IFX_Stream* pSR =
       m_pStreamImp->CreateSharedStream(dwAccess, iOffset, iLength);
-  if (pSR == NULL) {
-    return NULL;
-  }
+  if (!pSR)
+    return nullptr;
+
   if (dwAccess & FX_STREAMACCESS_Text) {
     return new CFX_TextStream(pSR, TRUE);
   }
   return pSR;
 }
 int32_t CFX_TextStream::GetBOM(uint8_t bom[4]) const {
   if (m_wBOMLength < 1) {
     return 0;
   }
   *(uint32_t*)bom = m_dwBOM;
   return m_wBOMLength;
 }
 uint16_t CFX_TextStream::SetCodePage(uint16_t wCodePage) {
   if (m_wBOMLength > 0) {
     return m_wCodePage;
   }
   uint16_t v = m_wCodePage;
   m_wCodePage = wCodePage;
   return v;
 }
 int32_t CFX_TextStream::ReadString(FX_WCHAR* pStr,
                                    int32_t iMaxLength,
                                    FX_BOOL& bEOS,
                                    int32_t const* pByteSize) {
-  ASSERT(pStr != NULL && iMaxLength > 0);
-  if (m_pStreamImp == NULL) {
+  ASSERT(pStr && iMaxLength > 0);
+  if (!m_pStreamImp)
     return -1;
-  }
+
   int32_t iLen;
   if (m_wCodePage == FX_CODEPAGE_UTF16LE ||
       m_wCodePage == FX_CODEPAGE_UTF16BE) {
-    int32_t iBytes = pByteSize == NULL ? iMaxLength * 2 : *pByteSize;
+    int32_t iBytes = pByteSize ? *pByteSize : iMaxLength * 2;
     iLen = m_pStreamImp->ReadData((uint8_t*)pStr, iBytes);
     iMaxLength = iLen / 2;
     if (sizeof(FX_WCHAR) > 2) {
       FX_UTF16ToWChar(pStr, iMaxLength);
     }
 #if _FX_ENDIAN_ == _FX_BIG_ENDIAN_
     if (m_wCodePage == FX_CODEPAGE_UTF16LE) {
       FX_SwapByteOrder(pStr, iMaxLength);
     }
 #else
     if (m_wCodePage == FX_CODEPAGE_UTF16BE) {
       FX_SwapByteOrder(pStr, iMaxLength);
     }
 #endif
   } else {
     int32_t pos = m_pStreamImp->GetPosition();
-    int32_t iBytes = pByteSize == NULL ? iMaxLength : *pByteSize;
+    int32_t iBytes = pByteSize ? *pByteSize : iMaxLength;
     iBytes = std::min(iBytes, m_pStreamImp->GetLength() - pos);
     if (iBytes > 0) {
-      if (m_pBuf == NULL) {
+      if (!m_pBuf) {
         m_pBuf = FX_Alloc(uint8_t, iBytes);
         m_iBufSize = iBytes;
       } else if (iBytes > m_iBufSize) {
         m_pBuf = FX_Realloc(uint8_t, m_pBuf, iBytes);
         m_iBufSize = iBytes;
       }
       iLen = m_pStreamImp->ReadData(m_pBuf, iBytes);
       int32_t iSrc = iLen;
       int32_t iDecode = FX_DecodeString(m_wCodePage, (const FX_CHAR*)m_pBuf,
                                         &iSrc, pStr, &iMaxLength, TRUE);
       m_pStreamImp->Seek(FX_STREAMSEEK_Current, iSrc - iLen);
       if (iDecode < 1) {
         return -1;
       }
     } else {
       iMaxLength = 0;
     }
   }
   bEOS = m_pStreamImp->IsEOF();
   return iMaxLength;
 }
 int32_t CFX_TextStream::WriteString(const FX_WCHAR* pStr, int32_t iLength) {
-  ASSERT(pStr != NULL && iLength > 0);
+  ASSERT(pStr && iLength > 0);
   if ((m_pStreamImp->GetAccessModes() & FX_STREAMACCESS_Write) == 0) {
     return -1;
   }
   if (m_wCodePage == FX_CODEPAGE_UTF8) {
     int32_t len = iLength;
     CFX_UTF8Encoder encoder;
     while (len-- > 0) {
       encoder.Input(*pStr++);
     }
     CFX_ByteStringC bsResult = encoder.GetResult();
     m_pStreamImp->WriteData((const uint8_t*)bsResult.c_str(),
                             bsResult.GetLength());
   }
   return iLength;
 }
 CFX_Stream::CFX_Stream()
     : m_eStreamType(FX_SREAMTYPE_Unknown),
-      m_pStreamImp(NULL),
+      m_pStreamImp(nullptr),
       m_dwAccess(0),
       m_iTotalSize(0),
       m_iPosition(0),
       m_iStart(0),
       m_iLength(0),
       m_iRefCount(1) {}
 
 CFX_Stream::~CFX_Stream() {
   if (m_eStreamType != FX_STREAMTYPE_Stream)
     delete m_pStreamImp;
@@ skipping 100 matching lines @@
 void CFX_Stream::Release() {
   if (--m_iRefCount < 1) {
     delete this;
   }
 }
 IFX_Stream* CFX_Stream::Retain() {
   m_iRefCount++;
   return this;
 }
 int32_t CFX_Stream::GetLength() const {
-  if (m_pStreamImp == NULL) {
+  if (!m_pStreamImp)
     return -1;
-  }
+
   if (m_eStreamType == FX_STREAMTYPE_File ||
       m_eStreamType == FX_STREAMTYPE_Buffer) {
     return m_pStreamImp->GetLength();
   }
   return m_iLength;
 }
 int32_t CFX_Stream::Seek(FX_STREAMSEEK eSeek, int32_t iOffset) {
-  if (m_pStreamImp == NULL) {
+  if (!m_pStreamImp)
     return -1;
-  }
+
   if (m_eStreamType == FX_STREAMTYPE_File ||
       m_eStreamType == FX_STREAMTYPE_Buffer) {
     return m_iPosition = m_pStreamImp->Seek(eSeek, iOffset);
   }
   int32_t iEnd = m_iStart + m_iLength;
   int32_t iPosition = m_iStart + iOffset;
   if (eSeek == FX_STREAMSEEK_Begin) {
     m_iPosition = iPosition;
   } else if (eSeek == FX_STREAMSEEK_Current) {
     m_iPosition += iOffset;
   } else if (eSeek == FX_STREAMSEEK_End) {
     m_iPosition = iEnd + iOffset;
   }
   if (m_iPosition > iEnd) {
     m_iPosition = iEnd;
   }
   if (m_iPosition < m_iStart) {
     m_iPosition = m_iStart;
   }
   return m_iPosition - m_iStart;
 }
 int32_t CFX_Stream::GetPosition() {
-  if (m_pStreamImp == NULL) {
+  if (!m_pStreamImp)
     return -1;
-  }
+
   if (m_eStreamType == FX_STREAMTYPE_File ||
       m_eStreamType == FX_STREAMTYPE_Buffer) {
     return m_iPosition = m_pStreamImp->GetPosition();
   }
   return m_iPosition - m_iStart;
 }
 FX_BOOL CFX_Stream::IsEOF() const {
-  if (m_pStreamImp == NULL) {
+  if (!m_pStreamImp)
     return TRUE;
-  }
+
   if (m_eStreamType == FX_STREAMTYPE_File ||
       m_eStreamType == FX_STREAMTYPE_Buffer) {
     return m_pStreamImp->IsEOF();
   }
   return m_iPosition >= m_iStart + m_iLength;
 }
 int32_t CFX_Stream::ReadData(uint8_t* pBuffer, int32_t iBufferSize) {
-  ASSERT(pBuffer != NULL && iBufferSize > 0);
-  if (m_pStreamImp == NULL) {
+  ASSERT(pBuffer && iBufferSize > 0);
+  if (!m_pStreamImp)
     return -1;
-  }
+
   int32_t iLen = std::min(m_iStart + m_iLength - m_iPosition, iBufferSize);
   if (iLen <= 0) {
     return 0;
   }
   if (m_pStreamImp->GetPosition() != m_iPosition) {
     m_pStreamImp->Seek(FX_STREAMSEEK_Begin, m_iPosition);
   }
   iLen = m_pStreamImp->ReadData(pBuffer, iLen);
   m_iPosition = m_pStreamImp->GetPosition();
   return iLen;
 }
 int32_t CFX_Stream::ReadString(FX_WCHAR* pStr,
                                int32_t iMaxLength,
                                FX_BOOL& bEOS,
                                int32_t const* pByteSize) {
-  ASSERT(pStr != NULL && iMaxLength > 0);
-  if (m_pStreamImp == NULL) {
+  ASSERT(pStr && iMaxLength > 0);
+  if (!m_pStreamImp)
     return -1;
-  }
+
   int32_t iEnd = m_iStart + m_iLength;
   int32_t iLen = iEnd - m_iPosition;
-  if (pByteSize != NULL) {
+  if (pByteSize)
     iLen = std::min(iLen, *pByteSize);
-  }
+
   iLen = std::min(iEnd / 2, iMaxLength);
   if (iLen <= 0) {
     return 0;
   }
   if (m_pStreamImp->GetPosition() != m_iPosition) {
     m_pStreamImp->Seek(FX_STREAMSEEK_Begin, m_iPosition);
   }
   iLen = m_pStreamImp->ReadString(pStr, iLen, bEOS);
   m_iPosition = m_pStreamImp->GetPosition();
   if (iLen > 0 && m_iPosition >= iEnd) {
     bEOS = TRUE;
   }
   return iLen;
 }
 
 int32_t CFX_Stream::WriteData(const uint8_t* pBuffer, int32_t iBufferSize) {
-  ASSERT(pBuffer != NULL && iBufferSize > 0);
-  if (m_pStreamImp == NULL) {
+  ASSERT(pBuffer && iBufferSize > 0);
+  if (!m_pStreamImp)
     return -1;
-  }
+
   if ((m_dwAccess & FX_STREAMACCESS_Write) == 0) {
     return -1;
   }
   int32_t iLen = iBufferSize;
   if (m_eStreamType == FX_STREAMTYPE_Stream) {
     iLen = std::min(m_iStart + m_iTotalSize - m_iPosition, iBufferSize);
     if (iLen <= 0) {
       return 0;
     }
   }
   int32_t iEnd = m_iStart + m_iLength;
   if (m_pStreamImp->GetPosition() != m_iPosition) {
     m_pStreamImp->Seek(FX_STREAMSEEK_Begin, m_iPosition);
   }
   iLen = m_pStreamImp->WriteData(pBuffer, iLen);
   m_iPosition = m_pStreamImp->GetPosition();
   if (m_iPosition > iEnd) {
     m_iLength = m_iPosition - m_iStart;
   }
   return iLen;
 }
 int32_t CFX_Stream::WriteString(const FX_WCHAR* pStr, int32_t iLength) {
-  ASSERT(pStr != NULL && iLength > 0);
-  if (m_pStreamImp == NULL) {
+  ASSERT(pStr && iLength > 0);
+  if (!m_pStreamImp)
     return -1;
-  }
+
   if ((m_dwAccess & FX_STREAMACCESS_Write) == 0) {
     return -1;
   }
   int32_t iLen = iLength;
   if (m_eStreamType == FX_STREAMTYPE_Stream) {
     iLen = std::min((m_iStart + m_iTotalSize - m_iPosition) / 2, iLength);
     if (iLen <= 0) {
       return 0;
     }
   }
   int32_t iEnd = m_iStart + m_iLength;
   if (m_pStreamImp->GetPosition() != m_iPosition) {
     m_pStreamImp->Seek(FX_STREAMSEEK_Begin, m_iPosition);
   }
   iLen = m_pStreamImp->WriteString(pStr, iLen);
   m_iPosition = m_pStreamImp->GetPosition();
   if (m_iPosition > iEnd) {
     m_iLength = m_iPosition - m_iStart;
   }
   return iLen;
 }
 void CFX_Stream::Flush() {
-  if (m_pStreamImp == NULL) {
+  if (!m_pStreamImp)
     return;
-  }
+
   if ((m_dwAccess & FX_STREAMACCESS_Write) == 0) {
     return;
   }
   m_pStreamImp->Flush();
 }
 FX_BOOL CFX_Stream::SetLength(int32_t iLength) {
-  if (m_pStreamImp == NULL) {
+  if (!m_pStreamImp)
     return FALSE;
-  }
+
   if ((m_dwAccess & FX_STREAMACCESS_Write) == 0) {
     return FALSE;
   }
   return m_pStreamImp->SetLength(iLength);
 }
 int32_t CFX_Stream::GetBOM(uint8_t bom[4]) const {
-  if (m_pStreamImp == NULL) {
+  if (!m_pStreamImp)
     return -1;
-  }
+
   return 0;
 }
 uint16_t CFX_Stream::GetCodePage() const {
 #if _FX_ENDIAN_ == _FX_LITTLE_ENDIAN_
   return FX_CODEPAGE_UTF16LE;
 #else
   return FX_CODEPAGE_UTF16BE;
 #endif
 }
 uint16_t CFX_Stream::SetCodePage(uint16_t wCodePage) {
 #if _FX_ENDIAN_ == _FX_LITTLE_ENDIAN_
   return FX_CODEPAGE_UTF16LE;
 #else
   return FX_CODEPAGE_UTF16BE;
 #endif
 }
 IFX_Stream* CFX_Stream::CreateSharedStream(uint32_t dwAccess,
                                            int32_t iOffset,
                                            int32_t iLength) {
   ASSERT(iLength > 0);
-  if (m_pStreamImp == NULL) {
-    return NULL;
-  }
+  if (!m_pStreamImp)
+    return nullptr;
+
   if ((m_dwAccess & FX_STREAMACCESS_Text) != 0 &&
       (dwAccess & FX_STREAMACCESS_Text) == 0) {
-    return NULL;
+    return nullptr;
   }
   if ((m_dwAccess & FX_STREAMACCESS_Write) == 0 &&
       (dwAccess & FX_STREAMACCESS_Write) != 0) {
-    return NULL;
+    return nullptr;
   }
   int32_t iStart = m_iStart + iOffset;
   int32_t iTotal = m_iStart + m_iLength;
   if (iStart < m_iStart || iStart >= iTotal) {
-    return NULL;
+    return nullptr;
   }
   int32_t iEnd = iStart + iLength;
   if (iEnd < iStart || iEnd > iTotal) {
-    return NULL;
+    return nullptr;
   }
   CFX_Stream* pShared = new CFX_Stream;
   pShared->m_eStreamType = FX_STREAMTYPE_Stream;
   pShared->m_pStreamImp = m_pStreamImp;
   pShared->m_dwAccess = dwAccess;
   pShared->m_iTotalSize = iLength;
   pShared->m_iPosition = iStart;
   pShared->m_iStart = iStart;
   pShared->m_iLength = (dwAccess & FX_STREAMACCESS_Write) != 0 ? 0 : iLength;
   if (dwAccess & FX_STREAMACCESS_Text) {
     return IFX_Stream::CreateTextStream(pShared, TRUE);
   }
   return pShared;
 }
 IFX_FileRead* FX_CreateFileRead(IFX_Stream* pBaseStream,
                                 FX_BOOL bReleaseStream) {
-  ASSERT(pBaseStream != NULL);
+  ASSERT(pBaseStream);
   return new CFGAS_FileRead(pBaseStream, bReleaseStream);
 }
 CFGAS_FileRead::CFGAS_FileRead(IFX_Stream* pStream, FX_BOOL bReleaseStream)
     : m_bReleaseStream(bReleaseStream), m_pStream(pStream) {
-  ASSERT(m_pStream != NULL);
+  ASSERT(m_pStream);
 }
 CFGAS_FileRead::~CFGAS_FileRead() {
   if (m_bReleaseStream) {
     m_pStream->Release();
   }
 }
 FX_FILESIZE CFGAS_FileRead::GetSize() {
   return (FX_FILESIZE)m_pStream->GetLength();
 }
 FX_BOOL CFGAS_FileRead::ReadBlock(void* buffer,
                                   FX_FILESIZE offset,
                                   size_t size) {
   m_pStream->Seek(FX_STREAMSEEK_Begin, (int32_t)offset);
   int32_t iLen = m_pStream->ReadData((uint8_t*)buffer, (int32_t)size);
   return iLen == (int32_t)size;
 }