Get rid of NULLs in xfa/

xfa/fde/tto/fde_textout.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fde/tto/fde_textout.h"
 
 #include <algorithm>
 
 #include "core/fxcrt/include/fx_coordinates.h"
 #include "core/fxcrt/include/fx_system.h"
 #include "xfa/fde/cfde_path.h"
 #include "xfa/fde/fde_gedevice.h"
 #include "xfa/fde/fde_object.h"
 #include "xfa/fgas/crt/fgas_memory.h"
 #include "xfa/fgas/crt/fgas_utils.h"
 #include "xfa/fgas/layout/fgas_textbreak.h"
 
 CFDE_TextOut::CFDE_TextOut()
-    : m_pFont(NULL),
+    : m_pFont(nullptr),
       m_fFontSize(12.0f),
       m_fLineSpace(m_fFontSize),
       m_fLinePos(0.0f),
       m_fTolerance(0.0f),
       m_iAlignment(0),
       m_iTxtBkAlignment(0),
-      m_pCharWidths(NULL),
+      m_pCharWidths(nullptr),
       m_iChars(0),
-      m_pEllCharWidths(NULL),
+      m_pEllCharWidths(nullptr),
       m_iEllChars(0),
       m_wParagraphBkChar(L'\n'),
       m_TxtColor(0xFF000000),
       m_dwStyles(0),
       m_dwTxtBkStyles(0),
       m_bElliChanged(FALSE),
       m_iEllipsisWidth(0),
       m_ttoLines(5),
       m_iCurLine(0),
       m_iCurPiece(0),
       m_iTotalLines(0),
-      m_pCharPos(NULL),
+      m_pCharPos(nullptr),
       m_iCharPosSize(0) {
   m_pTxtBreak = new CFX_TxtBreak(FX_TXTBREAKPOLICY_None);
   m_Matrix.SetIdentity();
   m_rtClip.Reset();
   m_rtLogicClip.Reset();
 }
 CFDE_TextOut::~CFDE_TextOut() {
   delete m_pTxtBreak;
   FX_Free(m_pCharWidths);
   FX_Free(m_pEllCharWidths);
@@ skipping 131 matching lines @@
   CFX_RectF rtText;
   rtText.Set((FX_FLOAT)rect.left, (FX_FLOAT)rect.top, (FX_FLOAT)rect.Width(),
              (FX_FLOAT)rect.Height());
   CalcSize(pwsStr, iLength, rtText);
   rect.Set((int32_t)rtText.left, (int32_t)rtText.top, (int32_t)rtText.Width(),
            (int32_t)rtText.Height());
 }
 void CFDE_TextOut::CalcSize(const FX_WCHAR* pwsStr,
                             int32_t iLength,
                             CFX_RectF& rect) {
-  if (pwsStr == NULL || iLength < 1) {
+  if (!pwsStr || iLength < 1) {
     rect.width = 0.0f;
     rect.height = 0.0f;
   } else {
     CFX_Matrix rm;
     rm.SetReverse(m_Matrix);
     rm.TransformRect(rect);
     CalcTextSize(pwsStr, iLength, rect);
     m_Matrix.TransformRect(rect);
   }
 }
 void CFDE_TextOut::CalcLogicSize(const FX_WCHAR* pwsStr,
                                  int32_t iLength,
                                  CFX_SizeF& size) {
   CFX_RectF rtText;
   rtText.Set(0.0f, 0.0f, size.x, size.y);
   CalcLogicSize(pwsStr, iLength, rtText);
   size.x = rtText.Width();
   size.y = rtText.Height();
 }
 void CFDE_TextOut::CalcLogicSize(const FX_WCHAR* pwsStr,
                                  int32_t iLength,
                                  CFX_RectF& rect) {
-  if (pwsStr == NULL || iLength < 1) {
+  if (!pwsStr || iLength < 1) {
     rect.width = 0.0f;
     rect.height = 0.0f;
   } else {
     CalcTextSize(pwsStr, iLength, rect);
   }
 }
 void CFDE_TextOut::CalcTextSize(const FX_WCHAR* pwsStr,
                                 int32_t iLength,
                                 CFX_RectF& rect) {
-  ASSERT(m_pFont != NULL && m_fFontSize >= 1.0f);
+  ASSERT(m_pFont && m_fFontSize >= 1.0f);
   SetLineWidth(rect);
   m_iTotalLines = 0;
   const FX_WCHAR* pStr = pwsStr;
   FX_BOOL bHotKey = !!(m_dwStyles & FDE_TTOSTYLE_HotKey);
   FX_BOOL bVertical = !!(m_dwStyles & FDE_TTOSTYLE_VerticalLayout);
   FX_FLOAT fWidth = 0.0f;
   FX_FLOAT fHeight = 0.0f;
   FX_FLOAT fStartPos = bVertical ? rect.bottom() : rect.right();
   uint32_t dwBreakStatus = 0;
   FX_WCHAR wPreChar = 0;
@@ skipping 141 matching lines @@
   CFX_RectF rtClip;
   rtClip.Set(m_rtLogicClip.left, m_rtLogicClip.top, m_rtLogicClip.width,
              m_rtLogicClip.height);
   m_Matrix.TransformRect(rtClip);
   DrawText(pwsStr, iLength, rect, rtClip);
 }
 void CFDE_TextOut::DrawText(const FX_WCHAR* pwsStr,
                             int32_t iLength,
                             const CFX_RectF& rect,
                             const CFX_RectF& rtClip) {
-  ASSERT(m_pFont != NULL && m_fFontSize >= 1.0f);
-  if (pwsStr == NULL || iLength < 1) {
+  ASSERT(m_pFont && m_fFontSize >= 1.0f);
+  if (!pwsStr || iLength < 1)
     return;
-  }
+
   if (rect.width < m_fFontSize || rect.height < m_fFontSize) {
     return;
   }
   FX_FLOAT fLineWidth = rect.width;
   if (m_dwStyles & FDE_TTOSTYLE_VerticalLayout) {
     fLineWidth = rect.height;
   }
   m_pTxtBreak->SetLineWidth(fLineWidth);
   m_ttoLines.RemoveAll(TRUE);
   m_wsText.clear();
@@ skipping 21 matching lines @@
       if (!m_pEllCharWidths) {
         m_pEllCharWidths = FX_Alloc(int32_t, iSize);
         m_iEllChars = iSize;
       } else if (m_iEllChars < iSize) {
         m_pEllCharWidths = FX_Realloc(int32_t, m_pEllCharWidths, iSize);
         m_iEllChars = iSize;
       }
       FXSYS_memset(m_pEllCharWidths, 0, iSize * sizeof(int32_t));
       break;
     case 2:
-      if (m_pCharPos == NULL) {
+      if (!m_pCharPos) {
         m_pCharPos = FX_Alloc(FXTEXT_CHARPOS, iSize);
         m_iCharPosSize = iSize;
       } else if (m_iCharPosSize < iSize) {
         m_pCharPos = FX_Realloc(FXTEXT_CHARPOS, m_pCharPos, iSize);
         m_iCharPosSize = iSize;
       }
       break;
   }
 }
 void CFDE_TextOut::LoadEllipsis() {
@@ skipping 61 matching lines @@
   }
   m_hotKeys.RemoveAll();
   int32_t iStartChar = 0;
   int32_t iChars = 0;
   int32_t iPieceWidths = 0;
   uint32_t dwBreakStatus;
   FX_WCHAR wch;
   FX_BOOL bRet = FALSE;
   while (iTxtLength-- > 0) {
     wch = *pwsStr++;
-    if (wch == L'&' && bHotKey && (pStr - 1) != NULL && *(pStr - 1) != L'&') {
+    if (wch == L'&' && bHotKey && pStr - 1 && *(pStr - 1) != L'&') {
       if (iTxtLength > 0) {
         m_hotKeys.Add(iChars);
       }
       continue;
     }
     *pStr++ = wch;
     iChars++;
     dwBreakStatus = m_pTxtBreak->AppendChar(wch);
     if (dwBreakStatus > FX_TXTBREAK_PieceBreak) {
       FX_BOOL bEndofLine =
@@ skipping 31 matching lines @@
                                      FX_BOOL bReload,
                                      const CFX_RectF& rect) {
   FX_BOOL bSingleLine = !!(m_dwStyles & FDE_TTOSTYLE_SingleLine);
   FX_BOOL bLineWrap = !!(m_dwStyles & FDE_TTOSTYLE_LineWrap);
   FX_BOOL bVertical = !!(m_dwStyles & FDE_TTOSTYLE_VerticalLayout);
   FX_FLOAT fLineStep =
       (m_fLineSpace > m_fFontSize) ? m_fLineSpace : m_fFontSize;
   if (bVertical) {
     fLineStep = -fLineStep;
   }
-  CFX_Char* pTC = NULL;
+  CFX_Char* pTC = nullptr;
   FX_BOOL bNeedReload = FALSE;
   FX_FLOAT fLineWidth = bVertical ? rect.Height() : rect.Width();
   int32_t iLineWidth = FXSYS_round(fLineWidth * 20000.0f);
   int32_t iCount = m_pTxtBreak->CountBreakPieces();
   for (int32_t i = 0; i < iCount; i++) {
     const CFX_TxtPiece* pPiece = m_pTxtBreak->GetBreakPiece(i);
     int32_t iPieceChars = pPiece->GetLength();
     int32_t iChar = iStartChar;
     int32_t iWidth = 0;
     int32_t j = 0;
@@ skipping 77 matching lines @@
     CFDE_TTOLine* pLine = m_ttoLines.GetPtrAt(i);
     if (!pLine->m_bNewReload) {
       continue;
     }
     int32_t iEllipsisCharIndex = iLength - 1;
     int32_t iCharWidth = 0;
     int32_t iCharCount = 0;
     int32_t iPiece = pLine->GetSize();
     while (iPiece-- > 0) {
       FDE_TTOPIECE* pPiece = pLine->GetPtrAt(iPiece);
-      if (pPiece == NULL) {
+      if (!pPiece)
         break;
-      }
+
       for (int32_t j = pPiece->iChars - 1; j >= 0; j--) {
         if (iEllipsisCharIndex < 0) {
           break;
         }
         int32_t index = pPiece->iStartChar + j;
         iCharWidth += m_pCharWidths[index];
         iCharCount++;
         if (iCharCount <= iLength) {
           m_wsText.SetAt(index, m_wsEllipsis.GetAt(iEllipsisCharIndex));
           m_pCharWidths[index] = m_pEllCharWidths[iEllipsisCharIndex];
         } else if (iCharWidth <= m_iEllipsisWidth) {
           m_wsText.SetAt(index, 0);
           m_pCharWidths[index] = 0;
         }
         iEllipsisCharIndex--;
       }
       if (iEllipsisCharIndex < 0) {
         break;
       }
     }
   }
 }
 void CFDE_TextOut::Reload(const CFX_RectF& rect) {
   int32_t iCount = m_ttoLines.GetSize();
   for (int32_t i = 0; i < iCount; i++) {
     CFDE_TTOLine* pLine = m_ttoLines.GetPtrAt(i);
-    if (pLine == NULL || !pLine->m_bNewReload) {
+    if (!pLine || !pLine->m_bNewReload)
       continue;
-    }
+
     m_iCurLine = i;
     m_iCurPiece = 0;
     ReloadLinePiece(pLine, rect);
   }
 }
 void CFDE_TextOut::ReloadLinePiece(CFDE_TTOLine* pLine, const CFX_RectF& rect) {
   const FX_WCHAR* pwsStr = m_wsText.c_str();
   FX_BOOL bVertical = !!(m_dwStyles & FDE_TTOSTYLE_VerticalLayout);
   int32_t iPieceWidths = 0;
   FDE_TTOPIECE* pPiece = pLine->GetPtrAt(0);
@@ skipping 59 matching lines @@
 void CFDE_TextOut::OnDraw(const CFX_RectF& rtClip) {
   if (!m_pRenderDevice)
     return;
 
   int32_t iLines = m_ttoLines.GetSize();
   if (iLines < 1)
     return;
 
   CFDE_Brush* pBrush = new CFDE_Brush;
   pBrush->SetColor(m_TxtColor);
-  CFDE_Pen* pPen = NULL;
+  CFDE_Pen* pPen = nullptr;
   m_pRenderDevice->SaveState();
   if (rtClip.Width() > 0.0f && rtClip.Height() > 0.0f) {
     m_pRenderDevice->SetClipRect(rtClip);
   }
   for (int32_t i = 0; i < iLines; i++) {
     CFDE_TTOLine* pLine = m_ttoLines.GetPtrAt(i);
     int32_t iPieces = pLine->GetSize();
     for (int32_t j = 0; j < iPieces; j++) {
       FDE_TTOPIECE* pPiece = pLine->GetPtrAt(j);
-      if (pPiece == NULL) {
+      if (!pPiece)
         continue;
-      }
+
       int32_t iCount = GetDisplayPos(pPiece);
       if (iCount > 0) {
         m_pRenderDevice->DrawString(pBrush, m_pFont, m_pCharPos, iCount,
                                     m_fFontSize, &m_Matrix);
       }
       DrawLine(pPiece, pPen);
     }
   }
   m_pRenderDevice->RestoreState();
   delete pBrush;
@@ skipping 121 matching lines @@
     FDE_TTOPIECE& piece = m_pieces.GetAt(index);
     piece = ttoPiece;
   }
   return index;
 }
 int32_t CFDE_TTOLine::GetSize() const {
   return m_iPieceCount;
 }
 FDE_TTOPIECE* CFDE_TTOLine::GetPtrAt(int32_t index) {
   if (index >= m_iPieceCount) {
-    return NULL;
+    return nullptr;
   }
   return m_pieces.GetPtrAt(index);
 }
 void CFDE_TTOLine::RemoveLast(int32_t iCount) {
   m_pieces.RemoveLast(iCount);
 }
 void CFDE_TTOLine::RemoveAll(FX_BOOL bLeaveMemory) {
   m_pieces.RemoveAll(bLeaveMemory);
 }