Get rid of NULLs in xfa/

xfa/fde/fde_gedevice.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fde/fde_gedevice.h"
 
 #include <algorithm>
 
@@ skipping 41 matching lines @@
                                          (int32_t)FXSYS_ceil(rtClip.right()),
                                          (int32_t)FXSYS_ceil(rtClip.bottom())));
 }
 const CFX_RectF& CFDE_RenderDevice::GetClipRect() {
   return m_rtClip;
 }
 FX_BOOL CFDE_RenderDevice::SetClipPath(const CFDE_Path* pClip) {
   return FALSE;
 }
 CFDE_Path* CFDE_RenderDevice::GetClipPath() const {
-  return NULL;
+  return nullptr;
 }
 FX_FLOAT CFDE_RenderDevice::GetDpiX() const {
   return 96;
 }
 FX_FLOAT CFDE_RenderDevice::GetDpiY() const {
   return 96;
 }
 FX_BOOL CFDE_RenderDevice::DrawImage(CFX_DIBSource* pDib,
                                      const CFX_RectF* pSrcRect,
                                      const CFX_RectF& dstRect,
                                      const CFX_Matrix* pImgMatrix,
                                      const CFX_Matrix* pDevMatrix) {
-  ASSERT(pDib != NULL);
+  ASSERT(pDib);
   CFX_RectF srcRect;
   if (pSrcRect) {
     srcRect = *pSrcRect;
   } else {
     srcRect.Set(0, 0, (FX_FLOAT)pDib->GetWidth(), (FX_FLOAT)pDib->GetHeight());
   }
   if (srcRect.IsEmpty()) {
     return FALSE;
   }
   CFX_Matrix dib2fxdev;
   if (pImgMatrix) {
     dib2fxdev = *pImgMatrix;
   } else {
     dib2fxdev.SetIdentity();
   }
   dib2fxdev.a = dstRect.width;
   dib2fxdev.d = -dstRect.height;
   dib2fxdev.e = dstRect.left;
   dib2fxdev.f = dstRect.bottom();
   if (pDevMatrix) {
     dib2fxdev.Concat(*pDevMatrix);
   }
-  void* handle = NULL;
+  void* handle = nullptr;
   m_pDevice->StartDIBits(pDib, 255, 0, (const CFX_Matrix*)&dib2fxdev, 0,
                          handle);
-  while (m_pDevice->ContinueDIBits(handle, NULL)) {
+  while (m_pDevice->ContinueDIBits(handle, nullptr)) {
   }
   m_pDevice->CancelDIBits(handle);
-  return handle != NULL;
+  return !!handle;
 }
 FX_BOOL CFDE_RenderDevice::DrawString(CFDE_Brush* pBrush,
                                       IFGAS_Font* pFont,
                                       const FXTEXT_CHARPOS* pCharPos,
                                       int32_t iCount,
                                       FX_FLOAT fFontSize,
                                       const CFX_Matrix* pMatrix) {
   ASSERT(pBrush && pFont && pCharPos && iCount > 0);
   CFX_FontCache* pCache = CFX_GEModule::Get()->GetFontCache();
   CFX_Font* pFxFont = pFont->GetDevFont();
   FX_ARGB argb = pBrush->GetColor();
   if ((pFont->GetFontStyles() & FX_FONTSTYLE_Italic) != 0 &&
       !pFxFont->IsItalic()) {
     FXTEXT_CHARPOS* pCP = (FXTEXT_CHARPOS*)pCharPos;
     FX_FLOAT* pAM;
     for (int32_t i = 0; i < iCount; ++i) {
       static const FX_FLOAT mc = 0.267949f;
       pAM = pCP->m_AdjustMatrix;
       pAM[2] = mc * pAM[0] + pAM[2];
       pAM[3] = mc * pAM[1] + pAM[3];
       pCP++;
     }
   }
   FXTEXT_CHARPOS* pCP = (FXTEXT_CHARPOS*)pCharPos;
-  IFGAS_Font* pCurFont = NULL;
-  IFGAS_Font* pSTFont = NULL;
-  FXTEXT_CHARPOS* pCurCP = NULL;
+  IFGAS_Font* pCurFont = nullptr;
+  IFGAS_Font* pSTFont = nullptr;
+  FXTEXT_CHARPOS* pCurCP = nullptr;
   int32_t iCurCount = 0;
 
 #if _FXM_PLATFORM_ != _FXM_PLATFORM_WINDOWS_
   uint32_t dwFontStyle = pFont->GetFontStyles();
   CFX_Font FxFont;
   CFX_SubstFont SubstFxFont;
   FxFont.SetSubstFont(&SubstFxFont);
   SubstFxFont.m_Weight = dwFontStyle & FX_FONTSTYLE_Bold ? 700 : 400;
   SubstFxFont.m_WeightCJK = SubstFxFont.m_Weight;
   SubstFxFont.m_ItalicAngle = dwFontStyle & FX_FONTSTYLE_Italic ? -12 : 0;
@@ skipping 100 matching lines @@
                                     const CFX_Matrix* pMatrix) {
   CFDE_Path path;
   path.AddLine(pt1, pt2);
   return DrawPath(pPen, fPenWidth, &path, pMatrix);
 }
 FX_BOOL CFDE_RenderDevice::DrawPath(CFDE_Pen* pPen,
                                     FX_FLOAT fPenWidth,
                                     const CFDE_Path* pPath,
                                     const CFX_Matrix* pMatrix) {
   CFDE_Path* pGePath = (CFDE_Path*)pPath;
-  if (pGePath == NULL) {
+  if (!pGePath)
     return FALSE;
-  }
+
   CFX_GraphStateData graphState;
   if (!CreatePen(pPen, fPenWidth, graphState)) {
     return FALSE;
   }
   return m_pDevice->DrawPath(&pGePath->m_Path, (const CFX_Matrix*)pMatrix,
                              &graphState, 0, pPen->GetColor(), 0);
 }
 FX_BOOL CFDE_RenderDevice::DrawPolygon(CFDE_Pen* pPen,
                                        FX_FLOAT fPenWidth,
                                        const CFX_PointsF& points,
@@ skipping 58 matching lines @@
                                     const CFX_Matrix* pMatrix) {
   CFDE_Path* pGePath = (CFDE_Path*)pPath;
   if (!pGePath)
     return FALSE;
   if (!pBrush)
     return FALSE;
   return m_pDevice->DrawPath(&pGePath->m_Path, pMatrix, nullptr,
                              pBrush->GetColor(), 0, FXFILL_WINDING);
 }