Get rid of NULLs in xfa/

xfa/fde/css/fde_csssyntax.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fde/css/fde_csssyntax.h"
 
 #include "xfa/fde/css/fde_cssdatatable.h"
 #include "xfa/fgas/crt/fgas_codepage.h"
 
 #ifdef _cplusplus
 extern "C" {
 #endif
 
-inline FX_BOOL FDE_IsSelectorStart(FX_WCHAR wch) {
+FX_BOOL FDE_IsSelectorStart(FX_WCHAR wch) {
   return wch == '.' || wch == '#' || wch == '*' || (wch >= 'a' && wch <= 'z') ||
          (wch >= 'A' && wch <= 'Z');
 }
 
 #ifdef _cplusplus
 };
 #endif
 
 CFDE_CSSSyntaxParser::CFDE_CSSSyntaxParser()
-    : m_pStream(NULL),
+    : m_pStream(nullptr),
       m_iStreamPos(0),
       m_iPlaneSize(0),
       m_iTextDatLen(0),
       m_dwCheck((uint32_t)-1),
       m_eMode(FDE_CSSSYNTAXMODE_RuleSet),
       m_eStatus(FDE_CSSSYNTAXSTATUS_None) {}
 CFDE_CSSSyntaxParser::~CFDE_CSSSyntaxParser() {
   m_TextData.Reset();
   m_TextPlane.Reset();
 }
 FX_BOOL CFDE_CSSSyntaxParser::Init(IFX_Stream* pStream,
                                    int32_t iCSSPlaneSize,
                                    int32_t iTextDataSize,
                                    FX_BOOL bOnlyDeclaration) {
-  ASSERT(pStream != NULL && iCSSPlaneSize > 0 && iTextDataSize > 0);
+  ASSERT(pStream && iCSSPlaneSize > 0 && iTextDataSize > 0);
   Reset(bOnlyDeclaration);
   if (!m_TextData.EstimateSize(iTextDataSize)) {
     return FALSE;
   }
   uint8_t bom[4];
   m_pStream = pStream;
   m_iStreamPos = m_pStream->GetBOM(bom);
   m_iPlaneSize = iCSSPlaneSize;
   return TRUE;
 }
 FX_BOOL CFDE_CSSSyntaxParser::Init(const FX_WCHAR* pBuffer,
                                    int32_t iBufferSize,
                                    int32_t iTextDatSize,
                                    FX_BOOL bOnlyDeclaration) {
-  ASSERT(pBuffer != NULL && iBufferSize > 0 && iTextDatSize > 0);
+  ASSERT(pBuffer && iBufferSize > 0 && iTextDatSize > 0);
   Reset(bOnlyDeclaration);
   if (!m_TextData.EstimateSize(iTextDatSize)) {
     return FALSE;
   }
   return m_TextPlane.AttachBuffer(pBuffer, iBufferSize);
 }
 void CFDE_CSSSyntaxParser::Reset(FX_BOOL bOnlyDeclaration) {
   m_TextPlane.Reset();
   m_TextData.Reset();
-  m_pStream = NULL;
+  m_pStream = nullptr;
   m_iStreamPos = 0;
   m_iTextDatLen = 0;
   m_dwCheck = (uint32_t)-1;
   m_eStatus = FDE_CSSSYNTAXSTATUS_None;
   m_eMode = bOnlyDeclaration ? FDE_CSSSYNTAXMODE_PropertyName
                              : FDE_CSSSYNTAXMODE_RuleSet;
 }
 FDE_CSSSYNTAXSTATUS CFDE_CSSSyntaxParser::DoSyntaxParse() {
   while (m_eStatus >= FDE_CSSSYNTAXSTATUS_None) {
     if (m_TextPlane.IsEOF()) {
-      if (m_pStream == NULL) {
+      if (!m_pStream) {
         if (m_eMode == FDE_CSSSYNTAXMODE_PropertyValue &&
             m_TextData.GetLength() > 0) {
           SaveTextData();
           return m_eStatus = FDE_CSSSYNTAXSTATUS_PropertyValue;
         }
         return m_eStatus = FDE_CSSSYNTAXSTATUS_EOS;
       }
       FX_BOOL bEOS;
       int32_t iLen = m_TextPlane.LoadFromStream(m_pStream, m_iStreamPos,
                                                 m_iPlaneSize, bEOS);
@@ skipping 133 matching lines @@
           switch (wch) {
             case ',':
               m_TextPlane.MoveNext();
               SwitchMode(FDE_CSSSYNTAXMODE_MediaType);
               if (m_iTextDatLen > 0) {
                 return FDE_CSSSYNTAXSTATUS_MediaType;
               }
               break;
             case '{': {
               FDE_CSSSYNTAXMODE* pMode = m_ModeStack.GetTopElement();
-              if (pMode == NULL || *pMode != FDE_CSSSYNTAXMODE_MediaRule) {
+              if (!pMode || *pMode != FDE_CSSSYNTAXMODE_MediaRule)
                 return m_eStatus = FDE_CSSSYNTAXSTATUS_Error;
-              }
+
               if (m_TextData.GetLength() > 0) {
                 SaveTextData();
                 return FDE_CSSSYNTAXSTATUS_MediaType;
               } else {
                 m_TextPlane.MoveNext();
                 *pMode = FDE_CSSSYNTAXMODE_RuleSet;
                 SwitchMode(FDE_CSSSYNTAXMODE_RuleSet);
                 return FDE_CSSSYNTAXSTATUS_DeclOpen;
               }
             } break;
             case ';': {
               FDE_CSSSYNTAXMODE* pMode = m_ModeStack.GetTopElement();
-              if (pMode == NULL || *pMode != FDE_CSSSYNTAXMODE_Import) {
+              if (!pMode || *pMode != FDE_CSSSYNTAXMODE_Import)
                 return m_eStatus = FDE_CSSSYNTAXSTATUS_Error;
-              }
+
               if (m_TextData.GetLength() > 0) {
                 SaveTextData();
                 if (IsImportEnabled()) {
                   return FDE_CSSSYNTAXSTATUS_MediaType;
                 }
               } else {
                 FX_BOOL bEnabled = IsImportEnabled();
                 m_TextPlane.MoveNext();
                 m_ModeStack.Pop();
                 SwitchMode(FDE_CSSSYNTAXMODE_RuleSet);
@@ skipping 10 matching lines @@
                 }
                 break;
               }
             default:
               AppendChar(wch);
               break;
           }
           break;
         case FDE_CSSSYNTAXMODE_URI: {
           FDE_CSSSYNTAXMODE* pMode = m_ModeStack.GetTopElement();
-          if (pMode == NULL || *pMode != FDE_CSSSYNTAXMODE_Import) {
+          if (!pMode || *pMode != FDE_CSSSYNTAXMODE_Import)
             return m_eStatus = FDE_CSSSYNTAXSTATUS_Error;
-          }
+
           if (wch <= ' ' || wch == ';') {
             int32_t iURIStart, iURILength = m_TextData.GetLength();
             if (iURILength > 0 &&
                 FDE_ParseCSSURI(m_TextData.GetBuffer(), iURILength, iURIStart,
                                 iURILength)) {
               m_TextData.Subtract(iURIStart, iURILength);
               SwitchMode(FDE_CSSSYNTAXMODE_MediaType);
               if (IsImportEnabled()) {
                 return FDE_CSSSYNTAXSTATUS_URI;
               } else {
@@ skipping 34 matching lines @@
             }
           }
           break;
         case FDE_CSSSYNTAXMODE_Charset:
           if (wch == ';') {
             m_TextPlane.MoveNext();
             SwitchMode(FDE_CSSSYNTAXMODE_RuleSet);
             if (IsCharsetEnabled()) {
               DisableCharset();
               if (m_iTextDatLen > 0) {
-                if (m_pStream != NULL) {
+                if (m_pStream) {
                   uint16_t wCodePage = FX_GetCodePageFromStringW(
                       m_TextData.GetBuffer(), m_iTextDatLen);
                   if (wCodePage < 0xFFFF &&
                       m_pStream->GetCodePage() != wCodePage) {
                     m_pStream->SetCodePage(wCodePage);
                   }
                 }
                 return FDE_CSSSYNTAXSTATUS_Charset;
               }
             }
@@ skipping 17 matching lines @@
 }
 FX_BOOL CFDE_CSSSyntaxParser::IsImportEnabled() const {
   if ((m_dwCheck & FDE_CSSSYNTAXCHECK_AllowImport) == 0) {
     return FALSE;
   }
   if (m_ModeStack.GetSize() > 1) {
     return FALSE;
   }
   return TRUE;
 }
-inline FX_BOOL CFDE_CSSSyntaxParser::AppendChar(FX_WCHAR wch) {
+FX_BOOL CFDE_CSSSyntaxParser::AppendChar(FX_WCHAR wch) {
   m_TextPlane.MoveNext();
   if (m_TextData.GetLength() > 0 || wch > ' ') {
     m_TextData.AppendChar(wch);
     return TRUE;
   }
   return FALSE;
 }
-inline int32_t CFDE_CSSSyntaxParser::SaveTextData() {
+int32_t CFDE_CSSSyntaxParser::SaveTextData() {
   m_iTextDatLen = m_TextData.TrimEnd();
   m_TextData.Clear();
   return m_iTextDatLen;
 }
-inline void CFDE_CSSSyntaxParser::SwitchMode(FDE_CSSSYNTAXMODE eMode) {
+void CFDE_CSSSyntaxParser::SwitchMode(FDE_CSSSYNTAXMODE eMode) {
   m_eMode = eMode;
   SaveTextData();
 }
-inline int32_t CFDE_CSSSyntaxParser::SwitchToComment() {
+int32_t CFDE_CSSSyntaxParser::SwitchToComment() {
   int32_t iLength = m_TextData.GetLength();
   m_ModeStack.Push(m_eMode);
   SwitchMode(FDE_CSSSYNTAXMODE_Comment);
   return iLength;
 }
-inline FX_BOOL CFDE_CSSSyntaxParser::RestoreMode() {
+FX_BOOL CFDE_CSSSyntaxParser::RestoreMode() {
   FDE_CSSSYNTAXMODE* pMode = m_ModeStack.GetTopElement();
-  if (pMode == NULL) {
+  if (!pMode)
     return FALSE;
-  }
+
   SwitchMode(*pMode);
   m_ModeStack.Pop();
   return TRUE;
 }
 const FX_WCHAR* CFDE_CSSSyntaxParser::GetCurrentString(int32_t& iLength) const {
   iLength = m_iTextDatLen;
   return m_TextData.GetBuffer();
 }
 CFDE_CSSTextBuf::CFDE_CSSTextBuf()
     : m_bExtBuf(FALSE),
-      m_pBuffer(NULL),
+      m_pBuffer(nullptr),
       m_iBufLen(0),
       m_iDatLen(0),
       m_iDatPos(0) {}
 CFDE_CSSTextBuf::~CFDE_CSSTextBuf() {
   Reset();
 }
 void CFDE_CSSTextBuf::Reset() {
   if (!m_bExtBuf) {
     FX_Free(m_pBuffer);
-    m_pBuffer = NULL;
+    m_pBuffer = nullptr;
   }
   m_iDatPos = m_iDatLen = m_iBufLen;
 }
 FX_BOOL CFDE_CSSTextBuf::AttachBuffer(const FX_WCHAR* pBuffer,
                                       int32_t iBufLen) {
   Reset();
   m_pBuffer = const_cast<FX_WCHAR*>(pBuffer);
   m_iDatLen = m_iBufLen = iBufLen;
   return m_bExtBuf = TRUE;
 }
@@ skipping 42 matching lines @@
   if (iLength > m_iDatLen - iStart) {
     iLength = m_iDatLen - iStart;
   }
   if (iLength < 0) {
     iLength = 0;
   } else {
     FXSYS_memmove(m_pBuffer, m_pBuffer + iStart, iLength * sizeof(FX_WCHAR));
   }
   m_iDatLen = iLength;
 }