Get rid of NULLs in xfa/

xfa/fde/css/fde_cssstyleselector.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fde/css/fde_cssstyleselector.h"
 
 #include <algorithm>
 #include <memory>
@@ skipping 10 matching lines @@
   int32_t iCount = m_arrCounterData.GetSize();
   for (int32_t i = 0; i < iCount; i++) {
     if (FXSYS_wcscmp(pszIdentifier, m_arrCounterData.ElementAt(i).m_pszIdent) ==
         0) {
       return i;
     }
   }
   return -1;
 }
 void CFDE_CSSCounterStyle::DoUpdateIndex(IFDE_CSSValueList* pList) {
-  if (pList == NULL) {
+  if (!pList)
     return;
-  }
+
   int32_t iCount = pList->CountValues();
   FX_FLOAT fDefValue = 1.0;
   FX_BOOL bDefIncrement = TRUE;
   if (pList == m_pCounterReset) {
     fDefValue = 0.0;
     bDefIncrement = FALSE;
   }
   for (int32_t i = 0; i < iCount; i++) {
     IFDE_CSSValueList* pCounter = (IFDE_CSSValueList*)pList->GetValue(i);
     int32_t iLen;
@@ skipping 33 matching lines @@
   }
   m_arrCounterData.RemoveAll();
   DoUpdateIndex(m_pCounterInc);
   DoUpdateIndex(m_pCounterReset);
   m_bIndexDirty = FALSE;
 }
 
 FDE_CSSRuleData::FDE_CSSRuleData(CFDE_CSSSelector* pSel,
                                  CFDE_CSSDeclaration* pDecl,
                                  uint32_t dwPos)
-    : pSelector(pSel), pDeclaration(pDecl), dwPriority(dwPos), pNext(NULL) {
+    : pSelector(pSel), pDeclaration(pDecl), dwPriority(dwPos), pNext(nullptr) {
   static const uint32_t s_Specific[5] = {0x00010000, 0x00010000, 0x00100000,
                                          0x00100000, 0x01000000};
-  for (; pSel != NULL; pSel = pSel->GetNextSelector()) {
+  for (; pSel; pSel = pSel->GetNextSelector()) {
     FDE_CSSSELECTORTYPE eType = pSel->GetType();
     if (eType > FDE_CSSSELECTORTYPE_Descendant ||
         pSel->GetNameHash() != FDE_CSSUNIVERSALHASH) {
       dwPriority += s_Specific[eType];
     }
   }
 }
 void CFDE_CSSRuleCollection::Clear() {
   m_IDRules.RemoveAll();
   m_TagRules.RemoveAll();
   m_ClassRules.RemoveAll();
-  m_pUniversalRules = NULL;
-  m_pStaticStore = NULL;
+  m_pUniversalRules = nullptr;
+  m_pStaticStore = nullptr;
   m_iSelectors = 0;
 }
 void CFDE_CSSRuleCollection::AddRulesFrom(const CFDE_CSSStyleSheetArray& sheets,
                                           uint32_t dwMediaList,
                                           IFGAS_FontMgr* pFontMgr) {
   int32_t iSheets = sheets.GetSize();
   for (int32_t i = 0; i < iSheets; ++i) {
     IFDE_CSSStyleSheet* pSheet = sheets.GetAt(i);
     if (uint32_t dwMatchMedia = pSheet->GetMediaList() & dwMediaList) {
       int32_t iRules = pSheet->CountRules();
@@ skipping 61 matching lines @@
     default:
       break;
   }
 }
 void CFDE_CSSRuleCollection::AddRuleTo(CFX_MapPtrToPtr& map,
                                        uint32_t dwKey,
                                        CFDE_CSSSelector* pSel,
                                        CFDE_CSSDeclaration* pDecl) {
   void* pKey = (void*)(uintptr_t)dwKey;
   FDE_CSSRuleData* pData = NewRuleData(pSel, pDecl);
-  FDE_CSSRuleData* pList = NULL;
+  FDE_CSSRuleData* pList = nullptr;
   if (!map.Lookup(pKey, (void*&)pList)) {
     map.SetAt(pKey, pData);
   } else if (AddRuleTo(pList, pData)) {
     map.SetAt(pKey, pList);
   }
 }
 
 FX_BOOL CFDE_CSSRuleCollection::AddRuleTo(FDE_CSSRuleData*& pList,
                                           FDE_CSSRuleData* pData) {
   if (pList) {
     pData->pNext = pList->pNext;
     pList->pNext = pData;
     return FALSE;
   }
 
   pList = pData;
   return TRUE;
 }
 
 FDE_CSSRuleData* CFDE_CSSRuleCollection::NewRuleData(
     CFDE_CSSSelector* pSel,
     CFDE_CSSDeclaration* pDecl) {
   return FXTARGET_NewWith(m_pStaticStore)
       FDE_CSSRuleData(pSel, pDecl, ++m_iSelectors);
 }
 
 CFDE_CSSStyleSelector::CFDE_CSSStyleSelector()
-    : m_pFontMgr(NULL),
+    : m_pFontMgr(nullptr),
       m_fDefFontSize(12.0f),
-      m_pRuleDataStore(NULL),
-      m_pInlineStyleStore(NULL),
-      m_pFixedStyleStore(NULL),
-      m_pAccelerator(NULL) {
+      m_pRuleDataStore(nullptr),
+      m_pInlineStyleStore(nullptr),
+      m_pFixedStyleStore(nullptr),
+      m_pAccelerator(nullptr) {
   m_ePriorities[FDE_CSSSTYLESHEETPRIORITY_High] = FDE_CSSSTYLESHEETGROUP_Author;
   m_ePriorities[FDE_CSSSTYLESHEETPRIORITY_Mid] = FDE_CSSSTYLESHEETGROUP_User;
   m_ePriorities[FDE_CSSSTYLESHEETPRIORITY_Low] =
       FDE_CSSSTYLESHEETGROUP_UserAgent;
 }
 
 CFDE_CSSStyleSelector::~CFDE_CSSStyleSelector() {
   Reset();
   delete m_pInlineStyleStore;
   delete m_pFixedStyleStore;
@@ skipping 30 matching lines @@
     pStyle->m_InheritedData.Reset();
   }
   pStyle->m_NonInheritedData.Reset();
   return pStyle;
 }
 FX_BOOL CFDE_CSSStyleSelector::SetStyleSheet(FDE_CSSSTYLESHEETGROUP eType,
                                              IFDE_CSSStyleSheet* pSheet) {
   ASSERT(eType < FDE_CSSSTYLESHEETGROUP_MAX);
   CFDE_CSSStyleSheetArray& dest = m_SheetGroups[eType];
   dest.RemoveAt(0, dest.GetSize());
-  if (pSheet != NULL) {
+  if (pSheet)
     dest.Add(pSheet);
-  }
   return TRUE;
 }
 FX_BOOL CFDE_CSSStyleSelector::SetStyleSheets(
     FDE_CSSSTYLESHEETGROUP eType,
     const CFDE_CSSStyleSheetArray* pArray) {
   ASSERT(eType < FDE_CSSSTYLESHEETGROUP_MAX);
   CFDE_CSSStyleSheetArray& dest = m_SheetGroups[eType];
-  if (pArray == NULL) {
+  if (pArray)
+    dest.Copy(*pArray);
+  else
     dest.RemoveAt(0, dest.GetSize());
-  } else {
-    dest.Copy(*pArray);
-  }
   return TRUE;
 }
 void CFDE_CSSStyleSelector::SetStylePriority(
     FDE_CSSSTYLESHEETGROUP eType,
     FDE_CSSSTYLESHEETPRIORITY ePriority) {
   m_ePriorities[ePriority] = eType;
 }
 void CFDE_CSSStyleSelector::UpdateStyleIndex(uint32_t dwMediaList) {
   Reset();
   m_pRuleDataStore = IFX_MemoryAllocator::Create(FX_ALLOCTYPE_Static, 1024, 0);
@@ skipping 61 matching lines @@
     if (MatchSelector(pCache, pList->pSelector, ePersudoType))
       m_MatchedRules.push_back(pList);
     pList = pList->pNext;
   }
 }
 
 FX_BOOL CFDE_CSSStyleSelector::MatchSelector(FDE_CSSTagCache* pCache,
                                              CFDE_CSSSelector* pSel,
                                              FDE_CSSPERSUDO ePersudoType) {
   uint32_t dwHash;
-  while (pSel != NULL && pCache != NULL) {
+  while (pSel && pCache) {
     switch (pSel->GetType()) {
       case FDE_CSSSELECTORTYPE_Descendant:
         dwHash = pSel->GetNameHash();
-        while ((pCache = pCache->GetParent()) != NULL) {
+        while ((pCache = pCache->GetParent()) != nullptr) {
           if (dwHash != FDE_CSSUNIVERSALHASH && dwHash != pCache->HashTag()) {
             continue;
           }
           if (MatchSelector(pCache, pSel->GetNextSelector(), ePersudoType)) {
             return TRUE;
           }
         }
         return FALSE;
       case FDE_CSSSELECTORTYPE_ID:
         dwHash = pCache->HashID();
@@ skipping 18 matching lines @@
         if (dwHash != pSel->GetNameHash()) {
           return FALSE;
         }
         break;
       default:
         ASSERT(FALSE);
         break;
     }
     pSel = pSel->GetNextSelector();
   }
-  return pSel == NULL && pCache != NULL;
+  return !pSel && pCache;
 }
 
 void CFDE_CSSStyleSelector::ComputeStyle(
     CXFA_CSSTagProvider* pTag,
     const CFDE_CSSDeclaration** ppDeclArray,
     int32_t iDeclCount,
     IFDE_CSSComputedStyle* pDestStyle) {
   ASSERT(iDeclCount >= 0);
   ASSERT(pDestStyle);
 
@@ skipping 54 matching lines @@
 void CFDE_CSSStyleSelector::ApplyDeclarations(
     FX_BOOL bPriority,
     const CFDE_CSSDeclaration** ppDeclArray,
     int32_t iDeclCount,
     IFDE_CSSComputedStyle* pDestStyle) {
   CFDE_CSSComputedStyle* pComputedStyle = (CFDE_CSSComputedStyle*)pDestStyle;
   IFDE_CSSValue* pVal;
   FX_BOOL bImportant;
   int32_t i;
   if (bPriority) {
-    IFDE_CSSValue *pLastest = NULL, *pImportant = NULL;
+    IFDE_CSSValue *pLastest = nullptr, *pImportant = nullptr;
     for (i = 0; i < iDeclCount; ++i) {
       pVal = ppDeclArray[i]->GetProperty(FDE_CSSPROPERTY_FontSize, bImportant);
-      if (pVal == NULL) {
+      if (!pVal)
         continue;
-      } else if (bImportant) {
+
+      if (bImportant)
         pImportant = pVal;
-      } else {
+      else
         pLastest = pVal;
-      }
     }
     if (pImportant) {
       ApplyProperty(FDE_CSSPROPERTY_FontSize, pImportant, pComputedStyle);
     } else if (pLastest) {
       ApplyProperty(FDE_CSSPROPERTY_FontSize, pLastest, pComputedStyle);
     }
   } else {
     CFDE_CSSDeclarationArray importants;
     const CFDE_CSSDeclaration* pDecl = nullptr;
     FDE_CSSPROPERTY eProp;
     FX_POSITION pos;
     for (i = 0; i < iDeclCount; ++i) {
       pDecl = ppDeclArray[i];
       pos = pDecl->GetStartPosition();
-      while (pos != NULL) {
+      while (pos) {
         pDecl->GetNextProperty(pos, eProp, pVal, bImportant);
         if (eProp == FDE_CSSPROPERTY_FontSize) {
           continue;
         } else if (!bImportant) {
           ApplyProperty(eProp, pVal, pComputedStyle);
         } else if (importants.GetSize() == 0 ||
                    importants[importants.GetUpperBound()] != pDecl) {
           importants.Add(const_cast<CFDE_CSSDeclaration*>(pDecl));
         }
       }
     }
     iDeclCount = importants.GetSize();
     for (i = 0; i < iDeclCount; ++i) {
       pDecl = importants[i];
       pos = pDecl->GetStartPosition();
-      while (pos != NULL) {
+      while (pos) {
         pDecl->GetNextProperty(pos, eProp, pVal, bImportant);
         if (bImportant && eProp != FDE_CSSPROPERTY_FontSize) {
           ApplyProperty(eProp, pVal, pComputedStyle);
         }
       }
     }
     CFX_WideString wsName, wsValue;
     pos = pDecl->GetStartCustom();
     while (pos) {
       pDecl->GetNextCustom(pos, wsName, wsValue);
@@ skipping 414 matching lines @@
       case FDE_CSSPROPERTY_ColumnRuleWidth:
         SetLengthWithPercent(FDE_CSSNONINHERITS.m_ColumnRuleWidth, eType,
                              pPrimitive, FDE_CSSFONTSIZE);
         break;
       case FDE_CSSPROPERTY_ColumnWidth:
         SetLengthWithPercent(FDE_CSSNONINHERITS.m_ColumnWidth, eType,
                              pPrimitive, FDE_CSSFONTSIZE);
         break;
       case FDE_CSSPROPERTY_BackgroundImage:
         if (eType == FDE_CSSPRIMITIVETYPE_Enum) {
-          FDE_CSSNONINHERITS.m_pszBKGImage = NULL;
+          FDE_CSSNONINHERITS.m_pszBKGImage = nullptr;
         } else if (eType == FDE_CSSPRIMITIVETYPE_URI) {
           int32_t iLength;
           FDE_CSSNONINHERITS.m_pszBKGImage = pPrimitive->GetString(iLength);
         }
         break;
       case FDE_CSSPROPERTY_Position:
         if (eType == FDE_CSSPRIMITIVETYPE_Enum) {
           FDE_CSSNONINHERITS.m_ePosition = ToPosition(pPrimitive->GetEnum());
         }
         break;
       case FDE_CSSPROPERTY_Top:
         SetLengthWithPercent(FDE_CSSNONINHERITS.m_Top, eType, pPrimitive,
                              FDE_CSSFONTSIZE);
         break;
       case FDE_CSSPROPERTY_Bottom:
         SetLengthWithPercent(FDE_CSSNONINHERITS.m_Bottom, eType, pPrimitive,
                              FDE_CSSFONTSIZE);
         break;
       case FDE_CSSPROPERTY_Left:
         SetLengthWithPercent(FDE_CSSNONINHERITS.m_Left, eType, pPrimitive,
                              FDE_CSSFONTSIZE);
         break;
       case FDE_CSSPROPERTY_Right:
         SetLengthWithPercent(FDE_CSSNONINHERITS.m_Right, eType, pPrimitive,
                              FDE_CSSFONTSIZE);
         break;
       case FDE_CSSPROPERTY_ListStyleImage:
         if (eType == FDE_CSSPRIMITIVETYPE_Enum) {
-          FDE_CSSINHERITS.m_pszListStyleImage = NULL;
+          FDE_CSSINHERITS.m_pszListStyleImage = nullptr;
         } else if (eType == FDE_CSSPRIMITIVETYPE_URI) {
           int32_t iLength;
           FDE_CSSINHERITS.m_pszListStyleImage = pPrimitive->GetString(iLength);
         }
         break;
       case FDE_CSSPROPERTY_CaptionSide:
         if (eType == FDE_CSSPRIMITIVETYPE_Enum) {
           FDE_CSSINHERITS.m_eCaptionSide = ToCaptionSide(pPrimitive->GetEnum());
         }
         break;
@@ skipping 36 matching lines @@
     int32_t iCount = pList->CountValues();
     if (iCount > 0) {
       switch (eProperty) {
         case FDE_CSSPROPERTY_FontFamily:
           FDE_CSSINHERITS.m_pFontFamily = pList;
           break;
         case FDE_CSSPROPERTY_TextDecoration:
           FDE_CSSNONINHERITS.m_dwTextDecoration = ToTextDecoration(pList);
           break;
         case FDE_CSSPROPERTY_CounterIncrement: {
-          if (FDE_CSSNONINHERITS.m_pCounterStyle == NULL) {
+          if (!FDE_CSSNONINHERITS.m_pCounterStyle)
             FDE_CSSNONINHERITS.m_pCounterStyle = new CFDE_CSSCounterStyle;
-          }
           FDE_CSSNONINHERITS.m_pCounterStyle->SetCounterIncrementList(pList);
         } break;
         case FDE_CSSPROPERTY_CounterReset: {
-          if (FDE_CSSNONINHERITS.m_pCounterStyle == NULL) {
+          if (!FDE_CSSNONINHERITS.m_pCounterStyle)
             FDE_CSSNONINHERITS.m_pCounterStyle = new CFDE_CSSCounterStyle;
-          }
           FDE_CSSNONINHERITS.m_pCounterStyle->SetCounterResetList(pList);
         } break;
         case FDE_CSSPROPERTY_Content:
           FDE_CSSNONINHERITS.m_pContentList = pList;
           break;
         case FDE_CSSPROPERTY_Quotes:
           FDE_CSSINHERITS.m_pQuotes = pList;
           break;
         case FDE_CSSPROPERTY_TextCombine: {
           for (int32_t i = 0; i < pList->CountValues(); i++) {
@@ skipping 711 matching lines @@
       return FDE_CSSTEXTTRANSFORM_LowerCase;
     default:
       return FDE_CSSTEXTTRANSFORM_None;
   }
 }
 FDE_CSSFONTVARIANT CFDE_CSSStyleSelector::ToFontVariant(
     FDE_CSSPROPERTYVALUE eValue) {
   return eValue == FDE_CSSPROPERTYVALUE_SmallCaps ? FDE_CSSFONTVARIANT_SmallCaps
                                                   : FDE_CSSFONTVARIANT_Normal;
 }