Get rid of NULLs in xfa/

xfa/fde/css/fde_cssdatatable.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fde/css/fde_cssdatatable.h"
 
 #include "core/fxcrt/include/fx_ext.h"
 #include "xfa/fgas/crt/fgas_codepage.h"
@@ skipping 19 matching lines @@
       return TRUE;
     default:
       return FALSE;
   }
 }
 CFX_FloatRect FDE_CSSBoundaryToRect(IFDE_CSSBoundaryStyle* pBoundStyle,
                                     FX_FLOAT fContainerWidth,
                                     FX_BOOL bPadding,
                                     FX_BOOL bBorder,
                                     FX_BOOL bMargin) {
-  ASSERT(pBoundStyle != NULL);
   FX_FLOAT fResult;
   const FDE_CSSRECT* pRect;
   CFX_FloatRect rect(0, 0, 0, 0);
   if (bPadding) {
     pRect = pBoundStyle->GetPaddingWidth();
-    if (pRect != NULL) {
+    if (pRect) {
       if (FDE_CSSLengthToFloat(pRect->left, fContainerWidth, fResult)) {
         rect.left += fResult;
       }
       if (FDE_CSSLengthToFloat(pRect->top, fContainerWidth, fResult)) {
         rect.top += fResult;
       }
       if (FDE_CSSLengthToFloat(pRect->right, fContainerWidth, fResult)) {
         rect.right += fResult;
       }
       if (FDE_CSSLengthToFloat(pRect->bottom, fContainerWidth, fResult)) {
         rect.bottom += fResult;
       }
     }
   }
   if (bBorder) {
     pRect = pBoundStyle->GetBorderWidth();
-    if (pRect != NULL) {
+    if (pRect) {
       if (FDE_CSSLengthToFloat(pRect->left, fContainerWidth, fResult)) {
         rect.left += fResult;
       }
       if (FDE_CSSLengthToFloat(pRect->top, fContainerWidth, fResult)) {
         rect.top += fResult;
       }
       if (FDE_CSSLengthToFloat(pRect->right, fContainerWidth, fResult)) {
         rect.right += fResult;
       }
       if (FDE_CSSLengthToFloat(pRect->bottom, fContainerWidth, fResult)) {
         rect.bottom += fResult;
       }
     }
   }
   if (bMargin) {
     pRect = pBoundStyle->GetMarginWidth();
-    if (pRect != NULL) {
+    if (pRect) {
       if (FDE_CSSLengthToFloat(pRect->left, fContainerWidth, fResult)) {
         rect.left += fResult;
       }
       if (FDE_CSSLengthToFloat(pRect->top, fContainerWidth, fResult)) {
         rect.top += fResult;
       }
       if (FDE_CSSLengthToFloat(pRect->right, fContainerWidth, fResult)) {
         rect.right += fResult;
       }
       if (FDE_CSSLengthToFloat(pRect->bottom, fContainerWidth, fResult)) {
         rect.bottom += fResult;
       }
     }
   }
   return rect;
 }
 uint32_t FDE_CSSFontStyleToFDE(IFDE_CSSFontStyle* pFontStyle) {
-  ASSERT(pFontStyle != NULL);
   uint32_t dwFontStyle = FX_FONTSTYLE_Normal;
   if (pFontStyle->GetFontStyle() == FDE_CSSFONTSTYLE_Italic) {
     dwFontStyle |= FX_FONTSTYLE_Italic;
   }
   if (pFontStyle->GetFontWeight() >= 700) {
     dwFontStyle |= FX_FONTSTYLE_Bold;
   }
   return dwFontStyle;
 }
 static const FDE_CSSPROPERTYTABLE g_FDE_CSSProperties[] = {
@@ skipping 446 matching lines @@
     {0xB6D2CF1F, 0xff808000}, {0xD19B5E1C, 0xffffff00},
     {0xDB64391D, 0xff000000}, {0xF616D507, 0xff00ff00},
     {0xF6EFFF31, 0xff008000},
 };
 static const FDE_CSSPERSUDOTABLE g_FDE_CSSPersudoType[] = {
     {FDE_CSSPERSUDO_After, L":after", 0x16EE1FEC},
     {FDE_CSSPERSUDO_Before, L":before", 0x7DCDDE2D},
 };
 FDE_LPCCSSPERSUDOTABLE FDE_GetCSSPersudoByEnum(FDE_CSSPERSUDO ePersudo) {
   return (ePersudo < FDE_CSSPERSUDO_NONE) ? (g_FDE_CSSPersudoType + ePersudo)
-                                          : NULL;
+                                          : nullptr;
 }
 const FDE_CSSPROPERTYTABLE* FDE_GetCSSPropertyByName(
     const CFX_WideStringC& wsName) {
   ASSERT(!wsName.IsEmpty());
   uint32_t dwHash = FX_HashCode_GetW(wsName, true);
   int32_t iEnd = FDE_CSSPROPERTY_MAX - 1;
   int32_t iMid, iStart = 0;
   uint32_t dwMid;
   do {
     iMid = (iStart + iEnd) / 2;
     dwMid = g_FDE_CSSProperties[iMid].dwHash;
     if (dwHash == dwMid) {
       return g_FDE_CSSProperties + iMid;
     } else if (dwHash > dwMid) {
       iStart = iMid + 1;
     } else {
       iEnd = iMid - 1;
     }
   } while (iStart <= iEnd);
-  return NULL;
+  return nullptr;
 }
 const FDE_CSSPROPERTYTABLE* FDE_GetCSSPropertyByEnum(FDE_CSSPROPERTY eName) {
-  return (eName < FDE_CSSPROPERTY_MAX) ? (g_FDE_CSSProperties + eName) : NULL;
+  return (eName < FDE_CSSPROPERTY_MAX) ? (g_FDE_CSSProperties + eName)
+                                       : nullptr;
 }
 const FDE_CSSPROPERTYVALUETABLE* FDE_GetCSSPropertyValueByName(
     const CFX_WideStringC& wsName) {
   ASSERT(!wsName.IsEmpty());
   uint32_t dwHash = FX_HashCode_GetW(wsName, true);
   int32_t iEnd = FDE_CSSPROPERTYVALUE_MAX - 1;
   int32_t iMid, iStart = 0;
   uint32_t dwMid;
   do {
     iMid = (iStart + iEnd) / 2;
     dwMid = g_FDE_CSSPropertyValues[iMid].dwHash;
     if (dwHash == dwMid) {
       return g_FDE_CSSPropertyValues + iMid;
     } else if (dwHash > dwMid) {
       iStart = iMid + 1;
     } else {
       iEnd = iMid - 1;
     }
   } while (iStart <= iEnd);
-  return NULL;
+  return nullptr;
 }
 const FDE_CSSPROPERTYVALUETABLE* FDE_GetCSSPropertyValueByEnum(
     FDE_CSSPROPERTYVALUE eName) {
   return (eName < FDE_CSSPROPERTYVALUE_MAX) ? (g_FDE_CSSPropertyValues + eName)
-                                            : NULL;
+                                            : nullptr;
 }
 FDE_LPCCSSMEDIATYPETABLE FDE_GetCSSMediaTypeByName(
     const CFX_WideStringC& wsName) {
   ASSERT(!wsName.IsEmpty());
   uint16_t wHash = FX_HashCode_GetW(wsName, true);
   int32_t iEnd =
       sizeof(g_FDE_CSSMediaTypes) / sizeof(FDE_CSSMEDIATYPETABLE) - 1;
   int32_t iMid, iStart = 0;
   uint16_t uMid;
   do {
     iMid = (iStart + iEnd) / 2;
     uMid = g_FDE_CSSMediaTypes[iMid].wHash;
     if (wHash == uMid) {
       return g_FDE_CSSMediaTypes + iMid;
     } else if (wHash > uMid) {
       iStart = iMid + 1;
     } else {
       iEnd = iMid - 1;
     }
   } while (iStart <= iEnd);
-  return NULL;
+  return nullptr;
 }
 FDE_LPCCSSLENGTHUNITTABLE FDE_GetCSSLengthUnitByName(
     const CFX_WideStringC& wsName) {
   ASSERT(!wsName.IsEmpty());
   uint16_t wHash = FX_HashCode_GetW(wsName, true);
   int32_t iEnd =
       sizeof(g_FDE_CSSLengthUnits) / sizeof(FDE_CSSLENGTHUNITTABLE) - 1;
   int32_t iMid, iStart = 0;
   uint16_t wMid;
   do {
     iMid = (iStart + iEnd) / 2;
     wMid = g_FDE_CSSLengthUnits[iMid].wHash;
     if (wHash == wMid) {
       return g_FDE_CSSLengthUnits + iMid;
     } else if (wHash > wMid) {
       iStart = iMid + 1;
     } else {
       iEnd = iMid - 1;
     }
   } while (iStart <= iEnd);
-  return NULL;
+  return nullptr;
 }
 FDE_LPCCSSCOLORTABLE FDE_GetCSSColorByName(const CFX_WideStringC& wsName) {
   ASSERT(!wsName.IsEmpty());
   uint32_t dwHash = FX_HashCode_GetW(wsName, true);
   int32_t iEnd = sizeof(g_FDE_CSSColors) / sizeof(FDE_CSSCOLORTABLE) - 1;
   int32_t iMid, iStart = 0;
   uint32_t dwMid;
   do {
     iMid = (iStart + iEnd) / 2;
     dwMid = g_FDE_CSSColors[iMid].dwHash;
     if (dwHash == dwMid) {
       return g_FDE_CSSColors + iMid;
     } else if (dwHash > dwMid) {
       iStart = iMid + 1;
     } else {
       iEnd = iMid - 1;
     }
   } while (iStart <= iEnd);
-  return NULL;
+  return nullptr;
 }
 
 FX_BOOL FDE_ParseCSSNumber(const FX_WCHAR* pszValue,
                            int32_t iValueLen,
                            FX_FLOAT& fValue,
                            FDE_CSSPRIMITIVETYPE& eUnit) {
   ASSERT(pszValue && iValueLen > 0);
   int32_t iUsedLen = 0;
   fValue = FX_wcstof(pszValue, iValueLen, &iUsedLen);
   if (iUsedLen <= 0)
@@ skipping 10 matching lines @@
     if (pUnit)
       eUnit = (FDE_CSSPRIMITIVETYPE)pUnit->wValue;
   }
   return TRUE;
 }
 
 FX_BOOL FDE_ParseCSSString(const FX_WCHAR* pszValue,
                            int32_t iValueLen,
                            int32_t& iOffset,
                            int32_t& iLength) {
-  ASSERT(pszValue != NULL && iValueLen > 0);
+  ASSERT(pszValue && iValueLen > 0);
   iOffset = 0;
   iLength = iValueLen;
   if (iValueLen >= 2) {
     FX_WCHAR first = pszValue[0], last = pszValue[iValueLen - 1];
     if ((first == '\"' && last == '\"') || (first == '\'' && last == '\'')) {
       iOffset = 1, iLength -= 2;
     }
   }
   return iValueLen > 0;
 }
 
 FX_BOOL FDE_ParseCSSURI(const FX_WCHAR* pszValue,
                         int32_t iValueLen,
                         int32_t& iOffset,
                         int32_t& iLength) {
-  ASSERT(pszValue != NULL && iValueLen > 0);
+  ASSERT(pszValue && iValueLen > 0);
   if (iValueLen < 6 || pszValue[iValueLen - 1] != ')' ||
       FX_wcsnicmp(L"url(", pszValue, 4)) {
     return FALSE;
   }
   if (FDE_ParseCSSString(pszValue + 4, iValueLen - 5, iOffset, iLength)) {
     iOffset += 4;
     return TRUE;
   }
   return FALSE;
 }
@@ skipping 158 matching lines @@
     }
     while (iBracketCount > 0 && m_pCur < m_pEnd) {
       if (*m_pCur == ')') {
         iBracketCount--;
       }
       m_pCur++;
     }
   }
   return m_pCur - pStart;
 }