Get rid of NULLs in xfa/

xfa/fde/cfde_txtedtpage.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fde/cfde_txtedtpage.h"
 
 #include <algorithm>
 
@@ skipping 120 matching lines @@
                        pPiece->rtPiece.top > ptF.y)) {
         nEnd = i - 1;
         break;
       } else {
         rtLine.Union(pPiece->rtPiece);
       }
     }
   }
   NormalizePt2Rect(ptF, rtLine, kTolerance);
   int32_t nCaret = 0;
-  FDE_TEXTEDITPIECE* pPiece = NULL;
+  FDE_TEXTEDITPIECE* pPiece = nullptr;
   for (i = nBgn; i <= nEnd; i++) {
     pPiece = m_PieceMassArr.GetPtrAt(i);
     nCaret = m_nPageStart + pPiece->nStart;
     if (pPiece->rtPiece.Contains(ptF)) {
       CFX_RectFArray rectArr;
       m_pTextSet->GetCharRects((FDE_HVISUALOBJ)pPiece, rectArr);
       int32_t nRtCount = rectArr.GetSize();
       for (int32_t j = 0; j < nRtCount; j++) {
         if (rectArr[j].Contains(ptF)) {
           nCaret = m_nPageStart + pPiece->nStart + j;
@@ skipping 34 matching lines @@
 
 int32_t CFDE_TxtEdtPage::GetCharCount() const {
   return m_nCharCount;
 }
 
 int32_t CFDE_TxtEdtPage::GetDisplayPos(const CFX_RectF& rtClip,
                                        FXTEXT_CHARPOS*& pCharPos,
                                        CFX_RectF* pBBox) const {
   pCharPos = FX_Alloc(FXTEXT_CHARPOS, m_nCharCount);
   int32_t nCharPosCount = 0;
-  FDE_HVISUALOBJ hVisualObj = NULL;
+  FDE_HVISUALOBJ hVisualObj = nullptr;
   int32_t nVisualObjCount = m_PieceMassArr.GetSize();
   FXTEXT_CHARPOS* pos = pCharPos;
   CFX_RectF rtObj;
   for (int32_t i = 0; i < nVisualObjCount; i++) {
     hVisualObj = (FDE_HVISUALOBJ)m_PieceMassArr.GetPtrAt(i);
     m_pTextSet->GetRect(hVisualObj, rtObj);
     if (!rtClip.IntersectWith(rtObj)) {
       continue;
     }
     int32_t nCount = m_pTextSet->GetDisplayPos(hVisualObj, pos, FALSE);
@@ skipping 109 matching lines @@
   FX_BOOL bVertial = pParams->dwLayoutStyles & FDE_TEXTEDITLAYOUT_DocVertical;
   FX_BOOL bLineReserve =
       pParams->dwLayoutStyles & FDE_TEXTEDITLAYOUT_LineReserve;
   FX_FLOAT fLineStart =
       bVertial
           ? (bLineReserve ? (pParams->fPlateWidth - pParams->fLineSpace) : 0.0f)
           : 0.0f;
   FX_FLOAT fLineStep =
       (bVertial && bLineReserve) ? (-pParams->fLineSpace) : pParams->fLineSpace;
   FX_FLOAT fLinePos = fLineStart;
-  if (m_pTextSet == NULL) {
+  if (!m_pTextSet)
     m_pTextSet = new CFDE_TxtEdtTextSet(this);
-  }
   m_PieceMassArr.RemoveAll(TRUE);
   uint32_t dwBreakStatus = FX_TXTBREAK_None;
   int32_t nPieceStart = 0;
-  if (m_pCharWidth != NULL) {
-    delete[] m_pCharWidth;
-  }
+  delete[] m_pCharWidth;
   m_pCharWidth = new int32_t[nPageEnd - nPageStart + 1];
   pBreak->EndBreak(FX_TXTBREAK_ParagraphBreak);
   pBreak->ClearBreakPieces();
   m_nPageStart = nPageStart;
   m_nCharCount = nPageEnd - nPageStart + 1;
   FX_BOOL bReload = FALSE;
   FX_FLOAT fDefCharWidth = 0;
   std::unique_ptr<IFX_CharIter> pIter(m_pIter->Clone());
   pIter->SetAt(nPageStart);
   m_pIter->SetAt(nPageStart);
@@ skipping 134 matching lines @@
   }
   m_pIter.reset();
 }
 
 const CFX_RectF& CFDE_TxtEdtPage::GetContentsBox() {
   return m_rtPageContents;
 }
 
 FX_POSITION CFDE_TxtEdtPage::GetFirstPosition(FDE_HVISUALOBJ hCanvas) {
   if (m_PieceMassArr.GetSize() < 1) {
-    return NULL;
+    return nullptr;
   }
   return (FX_POSITION)1;
 }
 
 FDE_HVISUALOBJ CFDE_TxtEdtPage::GetNext(FDE_HVISUALOBJ hCanvas,
                                         FX_POSITION& pos,
                                         IFDE_VisualSet*& pVisualSet) {
-  if (m_pTextSet == NULL) {
-    pos = NULL;
-    return NULL;
+  if (!m_pTextSet) {
+    pos = nullptr;
+    return nullptr;
   }
   int32_t nPos = (int32_t)(uintptr_t)pos;
   pVisualSet = m_pTextSet;
   if (nPos + 1 > m_PieceMassArr.GetSize()) {
-    pos = NULL;
+    pos = nullptr;
   } else {
     pos = (FX_POSITION)(uintptr_t)(nPos + 1);
   }
   return (FDE_HVISUALOBJ)(m_PieceMassArr.GetPtrAt(nPos - 1));
 }
 
 FDE_HVISUALOBJ CFDE_TxtEdtPage::GetParentCanvas(FDE_HVISUALOBJ hCanvas,
                                                 IFDE_VisualSet*& pVisualSet) {
-  return NULL;
+  return nullptr;
 }
 
 FX_WCHAR CFDE_TxtEdtPage::GetChar(void* pIdentity, int32_t index) const {
   int32_t nIndex =
       m_nPageStart + ((FDE_TEXTEDITPIECE*)pIdentity)->nStart + index;
   if (nIndex != m_pIter->GetAt()) {
     m_pIter->SetAt(nIndex);
   }
   FX_WCHAR wChar = m_pIter->GetChar();
   m_pIter->Next();
@@ skipping 16 matching lines @@
     ptF.x = rtF.left;
   } else if (ptF.x >= rtF.right()) {
     ptF.x = rtF.right() - fTolerance;
   }
   if (ptF.y < rtF.top) {
     ptF.y = rtF.top;
   } else if (ptF.y >= rtF.bottom()) {
     ptF.y = rtF.bottom() - fTolerance;
   }
 }