Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 2031873002: [deoptimizer] Support float registers and slots. (Closed)

Created:
4 years, 6 months ago by bbudge
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer, *Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Support float registers and slots. LOG=N BUG=v8:4124 Committed: https://crrev.com/a09fb95bc01063c75ee8db2fc2df1712d909202a Cr-Commit-Position: refs/heads/master@{#36715}

Patch Set 1 #

Patch Set 2 : Add register values for floats. #

Patch Set 3 : Rebase, eliminate TODOs. #

Patch Set 4 : Fix compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -5 lines) Patch
M src/compiler/code-generator.cc View 2 chunks +12 lines, -4 lines 0 comments Download
M src/compiler/code-generator-impl.h View 3 chunks +12 lines, -0 lines 0 comments Download
M src/deoptimizer.h View 1 8 chunks +20 lines, -0 lines 0 comments Download
M src/deoptimizer.cc View 1 2 11 chunks +53 lines, -1 line 0 comments Download
M src/objects.cc View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M src/utils.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
bbudge
I think this is necessary to have floats in frames.
4 years, 6 months ago (2016-06-02 15:18:12 UTC) #2
Benedikt Meurer
LGTM, but Jaro should definitely have a look.
4 years, 6 months ago (2016-06-03 04:38:23 UTC) #5
Jarin
lgtm
4 years, 6 months ago (2016-06-03 09:52:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031873002/40001
4 years, 6 months ago (2016-06-03 13:35:02 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/6726)
4 years, 6 months ago (2016-06-03 13:42:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031873002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031873002/60001
4 years, 6 months ago (2016-06-03 13:47:41 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-03 14:16:23 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 14:17:05 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a09fb95bc01063c75ee8db2fc2df1712d909202a
Cr-Commit-Position: refs/heads/master@{#36715}

Powered by Google App Engine
This is Rietveld 408576698