Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: chrome/install_static/install_util.h

Issue 2031833002: Remove FilePath usage from the CrashReporterClient interface on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix build error Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/install_static/install_util.h
diff --git a/chrome/install_static/install_util.h b/chrome/install_static/install_util.h
index 32f36e9dccc2eac26bcd3b98cd16805dd3d5d326..49368bbb8bfe1fc3261541848548e795c157c7b9 100644
--- a/chrome/install_static/install_util.h
+++ b/chrome/install_static/install_util.h
@@ -23,10 +23,9 @@ enum class ProcessType {
};
// TODO(ananta)
-// http://crbug.com/604923
+// https://crbug.com/604923
// The constants defined in this file are also defined in chrome/installer and
// other places. we need to unify them.
-
extern const wchar_t kChromeChannelUnknown[];
extern const wchar_t kChromeChannelCanary[];
extern const wchar_t kChromeChannelDev[];
@@ -44,6 +43,24 @@ extern const wchar_t kAppGuidCanary[];
extern const wchar_t kAppGuidGoogleChrome[];
extern const wchar_t kAppGuidGoogleBinaries[];
+// TODO(ananta)
+// https://crbug.com/604923
+// Unify these constants with env_vars.h.
+extern const char kHeadless[];
+extern const char kShowRestart[];
+extern const char kRestartInfo[];
+extern const char kRtlLocale[];
+extern const char kLtrLocale[];
+
+// TODO(ananta)
+// https://crbug.com/604923
+// Unify these constants with those defined in content_switches.h.
+extern const char kGpuProcess[];
+extern const char kPpapiPluginProcess[];
+extern const char kRendererProcess[];
+extern const char kUtilityProcess[];
+extern const char kZygoteProcess[];
grt (UTC plus 2) 2016/06/02 12:55:33 this constant is only used on linux, no? is this a
ananta 2016/06/02 20:34:20 It is not. However initially it was. Removed the c
+
// Returns true if |exe_path| points to a Chrome installed in an SxS
// installation.
bool IsSxSChrome(const wchar_t* exe_path);

Powered by Google App Engine
This is Rietveld 408576698