Chromium Code Reviews| Index: content/shell/app/shell_crash_reporter_client.cc |
| diff --git a/content/shell/app/shell_crash_reporter_client.cc b/content/shell/app/shell_crash_reporter_client.cc |
| index 9ede5ebbfffa0b27e56e1f49c68834a3d5cd72d1..fec6540caa7bd046d894f5664184be4859a435c3 100644 |
| --- a/content/shell/app/shell_crash_reporter_client.cc |
| +++ b/content/shell/app/shell_crash_reporter_client.cc |
| @@ -23,7 +23,7 @@ ShellCrashReporterClient::~ShellCrashReporterClient() {} |
| #if defined(OS_WIN) |
| void ShellCrashReporterClient::GetProductNameAndVersion( |
| - const base::FilePath& exe_path, |
| + const base::string16& exe_path, |
| base::string16* product_name, |
| base::string16* version, |
| base::string16* special_build, |
| @@ -48,6 +48,16 @@ base::FilePath ShellCrashReporterClient::GetReporterLogFilename() { |
| } |
| #endif |
| +#if defined(OS_WIN) |
| +bool ShellCrashReporterClient::GetCrashDumpLocation(base::string16* crash_dir) { |
| + if (!base::CommandLine::ForCurrentProcess()->HasSwitch( |
| + switches::kCrashDumpsDir)) |
| + return false; |
| + *crash_dir = base::CommandLine::ForCurrentProcess()->GetSwitchValuePath( |
| + switches::kCrashDumpsDir).value(); |
| + return true; |
| +} |
| +#else |
| bool ShellCrashReporterClient::GetCrashDumpLocation(base::FilePath* crash_dir) { |
| if (!base::CommandLine::ForCurrentProcess()->HasSwitch( |
| switches::kCrashDumpsDir)) |
| @@ -56,6 +66,7 @@ bool ShellCrashReporterClient::GetCrashDumpLocation(base::FilePath* crash_dir) { |
| switches::kCrashDumpsDir); |
|
scottmg
2016/06/02 00:09:30
can you just #if the signature and the .value() in
ananta
2016/06/02 00:22:57
Done.
|
| return true; |
| } |
| +#endif |
| #if defined(OS_ANDROID) |
| int ShellCrashReporterClient::GetAndroidMinidumpDescriptor() { |