Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: components/crash/content/app/crash_keys_win.cc

Issue 2031833002: Remove FilePath usage from the CrashReporterClient interface on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused constant to fix clang Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/content/app/crash_keys_win.cc
diff --git a/components/crash/content/app/crash_keys_win.cc b/components/crash/content/app/crash_keys_win.cc
index 90cb21cdd7c2763474d390075d3351591f9ac16c..a48c7a20b1ae0c389e03e45f9b21477346d437b7 100644
--- a/components/crash/content/app/crash_keys_win.cc
+++ b/components/crash/content/app/crash_keys_win.cc
@@ -8,7 +8,6 @@
#include "base/base_switches.h"
#include "base/command_line.h"
-#include "base/files/file_path.h"
#include "base/logging.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
@@ -69,10 +68,10 @@ void CrashKeysWin::SetPluginPath(const std::wstring& path) {
// Appends the breakpad dump path to |g_custom_entries|.
void CrashKeysWin::SetBreakpadDumpPath(CrashReporterClient* crash_client) {
- base::FilePath crash_dumps_dir_path;
+ base::string16 crash_dumps_dir_path;
if (crash_client->GetAlternativeCrashDumpLocation(&crash_dumps_dir_path)) {
custom_entries_->push_back(google_breakpad::CustomInfoEntry(
- L"breakpad-dump-location", crash_dumps_dir_path.value().c_str()));
+ L"breakpad-dump-location", crash_dumps_dir_path.c_str()));
}
}
@@ -89,7 +88,7 @@ CrashKeysWin::GetCustomInfo(const std::wstring& exe_path,
base::string16 channel_name;
crash_client->GetProductNameAndVersion(
- base::FilePath(exe_path),
+ exe_path,
&product,
&version,
&special_build,
« no previous file with comments | « components/crash/content/app/breakpad_win.cc ('k') | components/crash/content/app/crash_keys_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698