Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5032)

Unified Diff: chrome/installer/setup/installer_crash_reporter_client.h

Issue 2031833002: Remove FilePath usage from the CrashReporterClient interface on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused constant to fix clang Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/installer_crash_reporter_client.h
diff --git a/chrome/installer/setup/installer_crash_reporter_client.h b/chrome/installer/setup/installer_crash_reporter_client.h
index 7e869ba7043680ae07eb904bd9869d0130b16764..84bf3460fda92c7c002dead99d9f0dedc2cf1a1a 100644
--- a/chrome/installer/setup/installer_crash_reporter_client.h
+++ b/chrome/installer/setup/installer_crash_reporter_client.h
@@ -18,8 +18,8 @@ class InstallerCrashReporterClient
// crash_reporter::CrashReporterClient methods:
bool ShouldCreatePipeName(const base::string16& process_type) override;
- bool GetAlternativeCrashDumpLocation(base::FilePath* crash_dir) override;
- void GetProductNameAndVersion(const base::FilePath& exe_path,
+ bool GetAlternativeCrashDumpLocation(base::string16* crash_dir) override;
+ void GetProductNameAndVersion(const base::string16& exe_path,
base::string16* product_name,
base::string16* version,
base::string16* special_build,
@@ -29,10 +29,10 @@ class InstallerCrashReporterClient
bool* is_rtl_locale) override;
bool AboutToRestart() override;
bool GetDeferredUploadsSupported(bool is_per_user_install) override;
- bool GetIsPerUserInstall(const base::FilePath& exe_path) override;
+ bool GetIsPerUserInstall(const base::string16& exe_path) override;
bool GetShouldDumpLargerDumps(bool is_per_user_install) override;
int GetResultCodeRespawnFailed() override;
- bool GetCrashDumpLocation(base::FilePath* crash_dir) override;
+ bool GetCrashDumpLocation(base::string16* crash_dir) override;
size_t RegisterCrashKeys() override;
bool IsRunningUnattended() override;
bool GetCollectStatsConsent() override;
« no previous file with comments | « chrome/install_static/install_util_unittest.cc ('k') | chrome/installer/setup/installer_crash_reporter_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698