Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: chrome/app/chrome_crash_reporter_client_win.h

Issue 2031833002: Remove FilePath usage from the CrashReporterClient interface on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused constant to fix clang Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/chrome_crash_reporter_client_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_crash_reporter_client_win.h
diff --git a/chrome/app/chrome_crash_reporter_client_win.h b/chrome/app/chrome_crash_reporter_client_win.h
index 57bfd407f028dbd4e6a25b29c62298c04ca4adde..6acf53c553448b59bed4ec3dbce99709a611190e 100644
--- a/chrome/app/chrome_crash_reporter_client_win.h
+++ b/chrome/app/chrome_crash_reporter_client_win.h
@@ -14,8 +14,8 @@ class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
~ChromeCrashReporterClient() override;
// crash_reporter::CrashReporterClient implementation.
- bool GetAlternativeCrashDumpLocation(base::FilePath* crash_dir) override;
- void GetProductNameAndVersion(const base::FilePath& exe_path,
+ bool GetAlternativeCrashDumpLocation(base::string16* crash_dir) override;
+ void GetProductNameAndVersion(const base::string16& exe_path,
base::string16* product_name,
base::string16* version,
base::string16* special_build,
@@ -25,11 +25,11 @@ class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
bool* is_rtl_locale) override;
bool AboutToRestart() override;
bool GetDeferredUploadsSupported(bool is_per_user_install) override;
- bool GetIsPerUserInstall(const base::FilePath& exe_path) override;
+ bool GetIsPerUserInstall(const base::string16& exe_path) override;
bool GetShouldDumpLargerDumps(bool is_per_user_install) override;
int GetResultCodeRespawnFailed() override;
- bool GetCrashDumpLocation(base::FilePath* crash_dir) override;
+ bool GetCrashDumpLocation(base::string16* crash_dir) override;
size_t RegisterCrashKeys() override;
« no previous file with comments | « no previous file | chrome/app/chrome_crash_reporter_client_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698