Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: chrome/app/chrome_crash_reporter_client_win.h

Issue 2031833002: Remove FilePath usage from the CrashReporterClient interface on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix build error Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_ 5 #ifndef CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_
6 #define CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_ 6 #define CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "components/crash/content/app/crash_reporter_client.h" 9 #include "components/crash/content/app/crash_reporter_client.h"
10 10
11 class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient { 11 class ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
scottmg 2016/06/02 00:01:13 You're going to have to change all platforms that
12 public: 12 public:
13 ChromeCrashReporterClient(); 13 ChromeCrashReporterClient();
14 ~ChromeCrashReporterClient() override; 14 ~ChromeCrashReporterClient() override;
15 15
16 // crash_reporter::CrashReporterClient implementation. 16 // crash_reporter::CrashReporterClient implementation.
17 bool GetAlternativeCrashDumpLocation(base::FilePath* crash_dir) override; 17 bool GetAlternativeCrashDumpLocation(base::string16* crash_dir) override;
18 void GetProductNameAndVersion(const base::FilePath& exe_path, 18 void GetProductNameAndVersion(const base::string16& exe_path,
19 base::string16* product_name, 19 base::string16* product_name,
20 base::string16* version, 20 base::string16* version,
21 base::string16* special_build, 21 base::string16* special_build,
22 base::string16* channel_name) override; 22 base::string16* channel_name) override;
23 bool ShouldShowRestartDialog(base::string16* title, 23 bool ShouldShowRestartDialog(base::string16* title,
24 base::string16* message, 24 base::string16* message,
25 bool* is_rtl_locale) override; 25 bool* is_rtl_locale) override;
26 bool AboutToRestart() override; 26 bool AboutToRestart() override;
27 bool GetDeferredUploadsSupported(bool is_per_user_install) override; 27 bool GetDeferredUploadsSupported(bool is_per_user_install) override;
28 bool GetIsPerUserInstall(const base::FilePath& exe_path) override; 28 bool GetIsPerUserInstall(const base::string16& exe_path) override;
29 bool GetShouldDumpLargerDumps(bool is_per_user_install) override; 29 bool GetShouldDumpLargerDumps(bool is_per_user_install) override;
30 int GetResultCodeRespawnFailed() override; 30 int GetResultCodeRespawnFailed() override;
31 31
32 bool GetCrashDumpLocation(base::FilePath* crash_dir) override; 32 bool GetCrashDumpLocation(base::string16* crash_dir) override;
33 33
34 size_t RegisterCrashKeys() override; 34 size_t RegisterCrashKeys() override;
35 35
36 bool IsRunningUnattended() override; 36 bool IsRunningUnattended() override;
37 37
38 bool GetCollectStatsConsent() override; 38 bool GetCollectStatsConsent() override;
39 39
40 bool ReportingIsEnforcedByPolicy(bool* breakpad_enabled) override; 40 bool ReportingIsEnforcedByPolicy(bool* breakpad_enabled) override;
41 41
42 bool EnableBreakpadForProcess(const std::string& process_type) override; 42 bool EnableBreakpadForProcess(const std::string& process_type) override;
43 43
44 private: 44 private:
45 DISALLOW_COPY_AND_ASSIGN(ChromeCrashReporterClient); 45 DISALLOW_COPY_AND_ASSIGN(ChromeCrashReporterClient);
46 }; 46 };
47 47
48 #endif // CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_ 48 #endif // CHROME_APP_CHROME_CRASH_REPORTER_CLIENT_WIN_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/app/chrome_crash_reporter_client_win.cc » ('j') | chrome/install_static/install_util.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698