Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Side by Side Diff: components/crash/content/app/breakpad_win.cc

Issue 2031833002: Remove FilePath usage from the CrashReporterClient interface on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused constant to fix clang Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/crash/content/app/breakpad_win.h" 5 #include "components/crash/content/app/breakpad_win.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <shellapi.h> 8 #include <shellapi.h>
9 #include <stddef.h> 9 #include <stddef.h>
10 #include <tchar.h> 10 #include <tchar.h>
(...skipping 11 matching lines...) Expand all
22 #include "base/debug/dump_without_crashing.h" 22 #include "base/debug/dump_without_crashing.h"
23 #include "base/environment.h" 23 #include "base/environment.h"
24 #include "base/files/file_path.h" 24 #include "base/files/file_path.h"
25 #include "base/macros.h" 25 #include "base/macros.h"
26 #include "base/numerics/safe_conversions.h" 26 #include "base/numerics/safe_conversions.h"
27 #include "base/strings/string16.h" 27 #include "base/strings/string16.h"
28 #include "base/strings/string_split.h" 28 #include "base/strings/string_split.h"
29 #include "base/strings/string_util.h" 29 #include "base/strings/string_util.h"
30 #include "base/strings/stringprintf.h" 30 #include "base/strings/stringprintf.h"
31 #include "base/strings/utf_string_conversions.h" 31 #include "base/strings/utf_string_conversions.h"
32 #include "base/synchronization/lock.h"
33 #include "base/win/pe_image.h" 32 #include "base/win/pe_image.h"
34 #include "base/win/registry.h"
35 #include "base/win/win_util.h" 33 #include "base/win/win_util.h"
36 #include "breakpad/src/client/windows/common/ipc_protocol.h" 34 #include "breakpad/src/client/windows/common/ipc_protocol.h"
37 #include "breakpad/src/client/windows/handler/exception_handler.h" 35 #include "breakpad/src/client/windows/handler/exception_handler.h"
38 #include "components/crash/content/app/crash_keys_win.h" 36 #include "components/crash/content/app/crash_keys_win.h"
39 #include "components/crash/content/app/crash_reporter_client.h" 37 #include "components/crash/content/app/crash_reporter_client.h"
40 #include "components/crash/content/app/hard_error_handler_win.h" 38 #include "components/crash/content/app/hard_error_handler_win.h"
41 #include "components/crash/core/common/crash_keys.h" 39 #include "components/crash/core/common/crash_keys.h"
42 #include "content/public/common/result_codes.h" 40 #include "content/public/common/result_codes.h"
43 #include "sandbox/win/src/nt_internals.h" 41 #include "sandbox/win/src/nt_internals.h"
44 #include "sandbox/win/src/sidestep/preamble_patcher.h" 42 #include "sandbox/win/src/sidestep/preamble_patcher.h"
(...skipping 487 matching lines...) Expand 10 before | Expand all | Expand 10 after
532 530
533 base::string16 process_type = base::ASCIIToUTF16(process_type_switch); 531 base::string16 process_type = base::ASCIIToUTF16(process_type_switch);
534 if (process_type.empty()) 532 if (process_type.empty())
535 process_type = L"browser"; 533 process_type = L"browser";
536 534
537 wchar_t exe_path[MAX_PATH]; 535 wchar_t exe_path[MAX_PATH];
538 exe_path[0] = 0; 536 exe_path[0] = 0;
539 GetModuleFileNameW(NULL, exe_path, MAX_PATH); 537 GetModuleFileNameW(NULL, exe_path, MAX_PATH);
540 538
541 bool is_per_user_install = 539 bool is_per_user_install =
542 GetCrashReporterClient()->GetIsPerUserInstall(base::FilePath(exe_path)); 540 GetCrashReporterClient()->GetIsPerUserInstall(exe_path);
543 541
544 // This is intentionally leaked. 542 // This is intentionally leaked.
545 CrashKeysWin* keeper = new CrashKeysWin(); 543 CrashKeysWin* keeper = new CrashKeysWin();
546 544
547 google_breakpad::CustomClientInfo* custom_info = 545 google_breakpad::CustomClientInfo* custom_info =
548 keeper->GetCustomInfo(exe_path, process_type, GetProfileType(), 546 keeper->GetCustomInfo(exe_path, process_type, GetProfileType(),
549 base::CommandLine::ForCurrentProcess(), 547 base::CommandLine::ForCurrentProcess(),
550 GetCrashReporterClient()); 548 GetCrashReporterClient());
551 549
552 #if !defined(COMPONENT_BUILD) 550 #if !defined(COMPONENT_BUILD)
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
730 extern "C" void __declspec(dllexport) __cdecl 728 extern "C" void __declspec(dllexport) __cdecl
731 UnregisterNonABICompliantCodeRange(void* start) { 729 UnregisterNonABICompliantCodeRange(void* start) {
732 ExceptionHandlerRecord* record = 730 ExceptionHandlerRecord* record =
733 reinterpret_cast<ExceptionHandlerRecord*>(start); 731 reinterpret_cast<ExceptionHandlerRecord*>(start);
734 732
735 CHECK(RtlDeleteFunctionTable(&record->runtime_function)); 733 CHECK(RtlDeleteFunctionTable(&record->runtime_function));
736 } 734 }
737 #endif 735 #endif
738 736
739 } // namespace breakpad 737 } // namespace breakpad
OLDNEW
« no previous file with comments | « chrome/installer/setup/installer_crash_reporter_client.cc ('k') | components/crash/content/app/crash_keys_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698