Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 203183002: DevTools: Fix find next shortcut on mac and remove it on linux. (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 9 months ago
Reviewers:
lushnikov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Fix find next shortcut on mac and remove it on linux. This is a fix for a regression introduced in r161635 BUG=353221 R=pfeldman, lushnikov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169458

Patch Set 1 #

Patch Set 2 : Rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/devtools/front_end/SearchableView.js View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lushnikov
lgtm
6 years, 9 months ago (2014-03-18 08:37:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/203183002/1
6 years, 9 months ago (2014-03-18 08:37:42 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 09:58:54 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-18 09:58:55 UTC) #4
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-18 17:01:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/203183002/20001
6 years, 9 months ago (2014-03-18 17:02:13 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 18:56:55 UTC) #7
Message was sent while issue was closed.
Change committed as 169458

Powered by Google App Engine
This is Rietveld 408576698