git_cache.py: Clobber git repos if the config is corrupt

git_cache.py

Index: git_cache.py
diff --git a/git_cache.py b/git_cache.py
index 753ccde34a46c70c24c9748827311ff0138dbc0e..9beef36b6b22334f835deccb356c09b43acc07de 100755
--- a/git_cache.py
+++ b/git_cache.py
@@ -246,7 +246,11 @@ class Mirror(object):
       cwd = self.mirror_path
 
     # Don't run git-gc in a daemon.  Bad things can happen if it gets killed.
-    self.RunGit(['config', 'gc.autodetach', '0'], cwd=cwd)
+    try:
+      self.RunGit(['config', 'gc.autodetach', '0'], cwd=cwd)
+    except subprocess2.CalledProcessError:
+      # Hard error, need to clobber.
+      raise RefsHeadsFailedToFetch

[Paweł Hajdan Jr., 2016/06/06 11:21:52]

It seems hacky to re-use RefsHeadsFailedToFetch exception in this context.

Possible solutions:

a) rename it to something like ClobberNeeded
b) introduce a new one like GCAutodetachFailed and catch it where we catch
RefsHeadsFailedToFetch
c) have a ClobberNeeded exception both RefsHeadsFailedToFetch and
GCAutodetachFailed would inherit from; only catch ClobberNeeded

Also, it seems we should raise RefsHeadsFailedToFetch(), i.e. instantiate the
class.

[Ryan Tseng, 2016/06/07 20:38:02]

Done.

 
     # Don't combine pack files into one big pack file.  It's really slow for
     # repositories, and there's no way to track progress and make sure it's