Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2031763002: Flag for the desktop user menu revamp project (Closed)

Created:
4 years, 6 months ago by Jane
Modified:
4 years, 6 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Creates a flag to be used for the desktop user menu revamp project. Testing was done on the chrome://flags page as well as to use switches::IsRedesignedDesktopUserMenu(). BUG=615893 Committed: https://crrev.com/5601bd63e3623961b7afc85e8cb2e77d60d0c694 Cr-Commit-Position: refs/heads/master@{#397395}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Minor change of title #

Patch Set 3 : Changed name to material design #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M components/signin/core/common/profile_management_switches.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M components/signin/core/common/profile_management_switches.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M components/signin/core/common/signin_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/signin/core/common/signin_switches.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (12 generated)
Jane
As per our discussion, I created a flag to be used in my project. Please ...
4 years, 6 months ago (2016-06-01 20:08:57 UTC) #4
Roger Tawa OOO till Jul 10th
lgtm This needs to done behind a flag... OK, I wasn't really thinking about that. ...
4 years, 6 months ago (2016-06-01 20:40:14 UTC) #5
Jane
On 2016/06/01 20:40:14, Roger Tawa wrote: > lgtm > > This needs to done behind ...
4 years, 6 months ago (2016-06-01 20:46:39 UTC) #6
anthonyvd
On 2016/06/01 at 20:40:14, rogerta wrote: lgtm % minor nit: We tend to stay away ...
4 years, 6 months ago (2016-06-01 20:48:08 UTC) #7
Jane
On 2016/06/01 20:48:08, anthonyvd wrote: > On 2016/06/01 at 20:40:14, rogerta wrote: > > lgtm ...
4 years, 6 months ago (2016-06-01 20:54:32 UTC) #8
anthonyvd
On 2016/06/01 at 20:54:32, janeliulwq wrote: > On 2016/06/01 20:48:08, anthonyvd wrote: > > On ...
4 years, 6 months ago (2016-06-01 20:57:35 UTC) #10
Jane
On 2016/06/01 20:57:35, anthonyvd wrote: > On 2016/06/01 at 20:54:32, janeliulwq wrote: > > On ...
4 years, 6 months ago (2016-06-01 21:17:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031763002/40001
4 years, 6 months ago (2016-06-01 21:18:52 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239029)
4 years, 6 months ago (2016-06-02 01:57:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031763002/40001
4 years, 6 months ago (2016-06-02 02:07:11 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239443)
4 years, 6 months ago (2016-06-02 02:53:37 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031763002/40001
4 years, 6 months ago (2016-06-02 14:30:07 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-02 14:34:23 UTC) #24
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 14:35:54 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5601bd63e3623961b7afc85e8cb2e77d60d0c694
Cr-Commit-Position: refs/heads/master@{#397395}

Powered by Google App Engine
This is Rietveld 408576698