Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2031743002:
Added instructions on how to use code coverage. (Closed)
|
Created:
4 years, 6 months ago by BigBossZhiling Modified:
4 years, 6 months ago CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdded instructions on how to use code coverage.
Added coverage.md file for emma code coverage instructions for both
instrumentation and junit tests.
BUG=608085
Committed: https://crrev.com/1ccac19f89c5bcc7bdd978384520b9cfd218f14f
Cr-Commit-Position: refs/heads/master@{#397474}
Patch Set 1 #
Total comments: 4
Patch Set 2 : fixes #
Total comments: 10
Patch Set 3 : fixes #Messages
Total messages: 23 (11 generated)
Description was changed from ========== Added instructions on how to use code coverage. Added coverage.md file for emma code coverage instructions for both instrumentation and junit tests. BUG=608085 ========== to ========== Added instructions on how to use code coverage. Added coverage.md file for emma code coverage instructions for both instrumentation and junit tests. BUG=608085 ==========
hzl@google.com changed reviewers: + jbudorick@chromium.org
mikecase@chromium.org changed reviewers: + mikecase@chromium.org
https://codereview.chromium.org/2031743002/diff/1/build/android/docs/coverage.md File build/android/docs/coverage.md (right): https://codereview.chromium.org/2031743002/diff/1/build/android/docs/coverage... build/android/docs/coverage.md:14: 1. Make sure that 'emma_coverage = true' is in your gn args. Should these be ` instead of '? https://codereview.chromium.org/2031743002/diff/1/build/android/docs/coverage... build/android/docs/coverage.md:16: file) Can probably combine the first steps into something like this. 1. Build your APK with the GN arg emma_coverage=true. ``` gn args out/Debug > target_os = "android" > emma_coverage = true ```
https://codereview.chromium.org/2031743002/diff/1/build/android/docs/coverage.md File build/android/docs/coverage.md (right): https://codereview.chromium.org/2031743002/diff/1/build/android/docs/coverage... build/android/docs/coverage.md:14: 1. Make sure that 'emma_coverage = true' is in your gn args. On 2016/06/01 20:28:01, mikecase wrote: > Should these be ` instead of '? Done. https://codereview.chromium.org/2031743002/diff/1/build/android/docs/coverage... build/android/docs/coverage.md:16: file) On 2016/06/01 20:28:01, mikecase wrote: > Can probably combine the first steps into something like this. > > > 1. Build your APK with the GN arg emma_coverage=true. > ``` > gn args out/Debug > > target_os = "android" > > emma_coverage = true > ``` Done.
lgtm with some remaining nits. https://codereview.chromium.org/2031743002/diff/20001/build/android/docs/cove... File build/android/docs/coverage.md (right): https://codereview.chromium.org/2031743002/diff/20001/build/android/docs/cove... build/android/docs/coverage.md:7: ## How emma coverage works nit: everywhere s/emma/EMMA https://codereview.chromium.org/2031743002/diff/20001/build/android/docs/cove... build/android/docs/coverage.md:9: In order to use emma code coverage, we need to create build time .em file and run time nit: s/run time/runtime https://codereview.chromium.org/2031743002/diff/20001/build/android/docs/cove... build/android/docs/coverage.md:10: .ec file. Then we need to merge them to become a readable html file. nit: everywhere............ s/.ec/**.ec** s/.em/**.em** to make it easier to read. Also, instead of using the word "merge" you might want to replace it with something like "process then using the build/android/generate_emma_html.py script" https://codereview.chromium.org/2031743002/diff/20001/build/android/docs/cove... build/android/docs/coverage.md:12: ## Steps to make use of code coverage nit: s/Steps to make use of code coverage/How to collect EMMA coverage data https://codereview.chromium.org/2031743002/diff/20001/build/android/docs/cove... build/android/docs/coverage.md:29: Then an example.html containing coverage info will be create: nit: s/create/created
https://codereview.chromium.org/2031743002/diff/20001/build/android/docs/cove... File build/android/docs/coverage.md (right): https://codereview.chromium.org/2031743002/diff/20001/build/android/docs/cove... build/android/docs/coverage.md:7: ## How emma coverage works On 2016/06/01 21:59:20, mikecase wrote: > nit: everywhere s/emma/EMMA > Done. https://codereview.chromium.org/2031743002/diff/20001/build/android/docs/cove... build/android/docs/coverage.md:9: In order to use emma code coverage, we need to create build time .em file and run time On 2016/06/01 21:59:20, mikecase wrote: > nit: s/run time/runtime Done. https://codereview.chromium.org/2031743002/diff/20001/build/android/docs/cove... build/android/docs/coverage.md:10: .ec file. Then we need to merge them to become a readable html file. On 2016/06/01 21:59:20, mikecase wrote: > nit: everywhere............ > > s/.ec/**.ec** > s/.em/**.em** > > to make it easier to read. > > > Also, instead of using the word "merge" you might want to replace it with > something like "process then using the build/android/generate_emma_html.py > script" Done. https://codereview.chromium.org/2031743002/diff/20001/build/android/docs/cove... build/android/docs/coverage.md:12: ## Steps to make use of code coverage On 2016/06/01 21:59:20, mikecase wrote: > nit: s/Steps to make use of code coverage/How to collect EMMA coverage data Done. https://codereview.chromium.org/2031743002/diff/20001/build/android/docs/cove... build/android/docs/coverage.md:29: Then an example.html containing coverage info will be create: On 2016/06/01 21:59:20, mikecase wrote: > nit: s/create/created Done.
The CQ bit was checked by hzl@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from mikecase@chromium.org Link to the patchset: https://codereview.chromium.org/2031743002/#ps40001 (title: "fixes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031743002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031743002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hzl@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031743002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031743002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hzl@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031743002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031743002/40001
Message was sent while issue was closed.
Description was changed from ========== Added instructions on how to use code coverage. Added coverage.md file for emma code coverage instructions for both instrumentation and junit tests. BUG=608085 ========== to ========== Added instructions on how to use code coverage. Added coverage.md file for emma code coverage instructions for both instrumentation and junit tests. BUG=608085 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Added instructions on how to use code coverage. Added coverage.md file for emma code coverage instructions for both instrumentation and junit tests. BUG=608085 ========== to ========== Added instructions on how to use code coverage. Added coverage.md file for emma code coverage instructions for both instrumentation and junit tests. BUG=608085 Committed: https://crrev.com/1ccac19f89c5bcc7bdd978384520b9cfd218f14f Cr-Commit-Position: refs/heads/master@{#397474} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1ccac19f89c5bcc7bdd978384520b9cfd218f14f Cr-Commit-Position: refs/heads/master@{#397474} |
