Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 2031673003: WebRTC: Remove webrtc_perf_tests from trybots and Debug commit bots. (Closed)

Created:
4 years, 6 months ago by kjellander_chromium
Modified:
4 years, 6 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

WebRTC: Remove webrtc_perf_tests from trybots and Debug commit bots. The webrtc_perf_tests test has grown to become a major bottleneck for our CQ trybots since it's execution time has slowly increased over time. It currently consumes 30-50% of the total build time for the trybots that run tests on Android devices. It's even worse on Mac, Windows and Linux: around 70% of the cycle time is consumed. Given that failures only caught by this test is rare, it makes sense to remove it from all bots that don't produce perf data (i.e. Release commit bots). I also added perf tracking for the not-yet-deployed Android devices that currently runs in client.webrtc.fyi. This is one step on the way to move all perf tests into a separate waterfall. BUG=586238 Committed: https://chromium.googlesource.com/chromium/tools/build/+/4334fd38d9dc0898b5d8e5f33b6130779bcc071e

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -214 lines) Patch
M scripts/slave/recipe_modules/webrtc/builders.py View 3 chunks +9 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/webrtc/steps.py View 2 chunks +21 lines, -20 lines 1 comment Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__dbg_.json View 1 1 chunk +0 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus7_2__dbg_.json View 1 1 chunk +0 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_asan__l_nexus6_.json View 1 1 chunk +0 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__j_nexus4_.json View 1 1 chunk +22 lines, -6 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__k_nexus5_.json View 1 1 chunk +22 lines, -6 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__l_nexus6_.json View 1 1 chunk +22 lines, -6 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json View 1 1 chunk +0 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json View 1 1 chunk +0 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_n6.json View 1 1 chunk +0 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json View 1 1 chunk +0 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_baremetal.json View 1 chunk +0 lines, -24 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_baremetal.json View 1 chunk +0 lines, -23 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_baremetal.json View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
kjellander_chromium
This should largely speed up our slowest trybots. I feel stupid not thinking about this ...
4 years, 6 months ago (2016-06-01 19:05:14 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031673003/1
4 years, 6 months ago (2016-06-01 19:05:28 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/5105) Build ...
4 years, 6 months ago (2016-06-01 19:07:01 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031673003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031673003/20001
4 years, 6 months ago (2016-06-01 19:53:41 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-01 20:00:12 UTC) #10
phoglund_chromium
lgtm https://codereview.chromium.org/2031673003/diff/20001/scripts/slave/recipe_modules/webrtc/steps.py File scripts/slave/recipe_modules/webrtc/steps.py (right): https://codereview.chromium.org/2031673003/diff/20001/scripts/slave/recipe_modules/webrtc/steps.py#newcode160 scripts/slave/recipe_modules/webrtc/steps.py:160: 'Perf tests should only be run with Release ...
4 years, 6 months ago (2016-06-02 07:55:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031673003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031673003/20001
4 years, 6 months ago (2016-06-02 08:08:40 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 08:12:18 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/4334fd38d9dc0898b5d8...

Powered by Google App Engine
This is Rietveld 408576698