Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: fpdfsdk/jsapi/fxjs_v8.cpp

Issue 2031653003: Get rid of NULLs in fpdfsdk/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@nullptr_core
Patch Set: Fix bad search/replace Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: fpdfsdk/jsapi/fxjs_v8.cpp
diff --git a/fpdfsdk/jsapi/fxjs_v8.cpp b/fpdfsdk/jsapi/fxjs_v8.cpp
index f8c2a3dd6d5997976fe8b074b15bd56a991b6bc4..bd69951795b7380d8a629d8aefe438b1ef4f13af 100644
--- a/fpdfsdk/jsapi/fxjs_v8.cpp
+++ b/fpdfsdk/jsapi/fxjs_v8.cpp
@@ -314,7 +314,7 @@ void FXJS_InitializeRuntime(
v8::Isolate::Scope isolate_scope(pIsolate);
v8::HandleScope handle_scope(pIsolate);
v8::Local<v8::Context> v8Context =
- v8::Context::New(pIsolate, NULL, GetGlobalObjectTemplate(pIsolate));
+ v8::Context::New(pIsolate, nullptr, GetGlobalObjectTemplate(pIsolate));
v8::Context::Scope context_scope(v8Context);
FXJS_PerIsolateData::SetUp(pIsolate);
@@ -514,7 +514,7 @@ void FXJS_Error(v8::Isolate* pIsolate, const CFX_WideString& message) {
const wchar_t* FXJS_GetTypeof(v8::Local<v8::Value> pObj) {
if (pObj.IsEmpty())
- return NULL;
+ return nullptr;
if (pObj->IsString())
return kFXJSValueNameString;
if (pObj->IsNumber())
@@ -529,7 +529,7 @@ const wchar_t* FXJS_GetTypeof(v8::Local<v8::Value> pObj) {
return kFXJSValueNameNull;
if (pObj->IsUndefined())
return kFXJSValueNameUndefined;
- return NULL;
+ return nullptr;
}
void FXJS_SetPrivate(v8::Isolate* pIsolate,
@@ -573,7 +573,7 @@ void FXJS_FreePrivate(v8::Local<v8::Object> pObj) {
if (pObj.IsEmpty() || !pObj->InternalFieldCount())
return;
FXJS_FreePrivate(pObj->GetAlignedPointerFromInternalField(0));
- pObj->SetAlignedPointerInInternalField(0, NULL);
+ pObj->SetAlignedPointerInInternalField(0, nullptr);
}
v8::Local<v8::String> FXJS_WSToJSString(v8::Isolate* pIsolate,

Powered by Google App Engine
This is Rietveld 408576698