fpdfsdk/javascript/JS_Object.cpp - Issue 2031653003: Get rid of NULLs in fpdfsdk/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/JS_Object.cpp

Issue 2031653003: Get rid of NULLs in fpdfsdk/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@nullptr_core

Patch Set: Fix bad search/replace Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/JS_Object.cpp

diff --git a/fpdfsdk/javascript/JS_Object.cpp b/fpdfsdk/javascript/JS_Object.cpp

index 7dc91a7291fa6c824b1ce8bd4df08103fd37e9f9..6339bb7359828a53f46543e81865192ec9fafd8c 100644

--- a/fpdfsdk/javascript/JS_Object.cpp

+++ b/fpdfsdk/javascript/JS_Object.cpp

@@ -31,7 +31,7 @@ int FXJS_MsgBox(CPDFDoc_Environment* pApp,

CJS_EmbedObj::CJS_EmbedObj(CJS_Object* pJSObject) : m_pJSObject(pJSObject) {}

CJS_EmbedObj::~CJS_EmbedObj() {

- m_pJSObject = NULL;

+ m_pJSObject = nullptr;

}

int CJS_EmbedObj::MsgBox(CPDFDoc_Environment* pApp,

@@ -87,7 +87,7 @@ void CJS_Object::Alert(CJS_Context* pContext, const FX_WCHAR* swMsg) {

if (pContext->IsMsgBoxEnabled()) {

CPDFDoc_Environment* pApp = pContext->GetReaderApp();

if (pApp)

- pApp->JS_appAlert(swMsg, NULL, 0, 3);

+ pApp->JS_appAlert(swMsg, nullptr, 0, 3);

}