fpdfsdk/fpdfdoc_embeddertest.cpp - Issue 2031653003: Get rid of NULLs in fpdfsdk/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfdoc_embeddertest.cpp

Issue 2031653003: Get rid of NULLs in fpdfsdk/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@nullptr_core

Patch Set: Fix bad search/replace Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfdoc_embeddertest.cpp

diff --git a/fpdfsdk/fpdfdoc_embeddertest.cpp b/fpdfsdk/fpdfdoc_embeddertest.cpp

index e0880deca57e5dfb41c3cf990d40dad8549d5a6e..fb695dc6f580a3ec39b58ae5e24828a8d43272a1 100644

--- a/fpdfsdk/fpdfdoc_embeddertest.cpp

+++ b/fpdfsdk/fpdfdoc_embeddertest.cpp

@@ -18,7 +18,7 @@ class FPDFDocEmbeddertest : public EmbedderTest {};

TEST_F(FPDFDocEmbeddertest, DestGetPageIndex) {

EXPECT_TRUE(OpenDocument("named_dests.pdf"));

- // NULL FPDF_DEST case.

+ // nullptr FPDF_DEST case.

Tom Sepez 2016/06/02 20:26:26 NULL preferred in comment, I think.

Lei Zhang 2016/06/07 08:03:13 Done.

EXPECT_EQ(0U, FPDFDest_GetPageIndex(document(), nullptr));

// Page number directly in item from Dests NameTree.