Get rid of NULLs in fpdfsdk/

fpdfsdk/fsdk_annothandler.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/include/fsdk_annothandler.h"
 
 #include <algorithm>
 #include <vector>
@@ skipping 70 matching lines @@
 CPDFSDK_Annot* CPDFSDK_AnnotHandlerMgr::NewAnnot(CXFA_FFWidget* pAnnot,
                                                  CPDFSDK_PageView* pPageView) {
   ASSERT(pAnnot);
   ASSERT(pPageView);
 
   if (IPDFSDK_AnnotHandler* pAnnotHandler =
           GetAnnotHandler(FSDK_XFAWIDGET_TYPENAME)) {
     return pAnnotHandler->NewAnnot(pAnnot, pPageView);
   }
 
-  return NULL;
+  return nullptr;
 }
 #endif  // PDF_ENABLE_XFA
 
 void CPDFSDK_AnnotHandlerMgr::ReleaseAnnot(CPDFSDK_Annot* pAnnot) {
   if (IPDFSDK_AnnotHandler* pAnnotHandler = GetAnnotHandler(pAnnot)) {
     pAnnotHandler->OnRelease(pAnnot);
     pAnnotHandler->ReleaseAnnot(pAnnot);
   } else {
     delete (CPDFSDK_Annot*)pAnnot;
   }
@@ skipping 258 matching lines @@
       return pAnnotHandler->HitTest(pPageView, pAnnot, point);
   }
   return FALSE;
 }
 
 CPDFSDK_Annot* CPDFSDK_AnnotHandlerMgr::GetNextAnnot(CPDFSDK_Annot* pSDKAnnot,
                                                      FX_BOOL bNext) {
 #ifdef PDF_ENABLE_XFA
   CPDFSDK_PageView* pPageView = pSDKAnnot->GetPageView();
   CPDFXFA_Page* pPage = pPageView->GetPDFXFAPage();
-  if (pPage == NULL)
-    return NULL;
+  if (!pPage)
+    return nullptr;
   if (pPage->GetPDFPage()) {  // for pdf annots.
     CBA_AnnotIterator ai(pSDKAnnot->GetPageView(), pSDKAnnot->GetType(), "");
     CPDFSDK_Annot* pNext =
         bNext ? ai.GetNextAnnot(pSDKAnnot) : ai.GetPrevAnnot(pSDKAnnot);
     return pNext;
   }
   // for xfa annots
   std::unique_ptr<IXFA_WidgetIterator> pWidgetIterator(
       pPage->GetXFAPageView()->CreateWidgetIterator(
           XFA_TRAVERSEWAY_Tranvalse, XFA_WidgetStatus_Visible |
@@ skipping 52 matching lines @@
   CPDF_InterForm* pPDFInterForm = pInterForm->GetInterForm();
   if (pPDFInterForm && pPDFInterForm->NeedConstructAP())
     pWidget->ResetAppearance(nullptr, FALSE);
 
   return pWidget;
 }
 
 #ifdef PDF_ENABLE_XFA
 CPDFSDK_Annot* CPDFSDK_BFAnnotHandler::NewAnnot(CXFA_FFWidget* hWidget,
                                                 CPDFSDK_PageView* pPage) {
-  return NULL;
+  return nullptr;
 }
 #endif  // PDF_ENABLE_XFA
 
 void CPDFSDK_BFAnnotHandler::ReleaseAnnot(CPDFSDK_Annot* pAnnot) {
   ASSERT(pAnnot);
 
   if (m_pFormFiller)
     m_pFormFiller->OnDelete(pAnnot);
 
   CPDFSDK_Widget* pWidget = (CPDFSDK_Widget*)pAnnot;
@@ skipping 191 matching lines @@
       m_pFormFiller->OnCreate(pAnnot);
   }
 }
 
 void CPDFSDK_BFAnnotHandler::OnLoad(CPDFSDK_Annot* pAnnot) {
   if (pAnnot->GetSubType() == BFFT_SIGNATURE)
     return;
 
   CPDFSDK_Widget* pWidget = (CPDFSDK_Widget*)pAnnot;
   if (!pWidget->IsAppearanceValid())
-    pWidget->ResetAppearance(NULL, FALSE);
+    pWidget->ResetAppearance(nullptr, FALSE);
 
   int nFieldType = pWidget->GetFieldType();
   if (nFieldType == FIELDTYPE_TEXTFIELD || nFieldType == FIELDTYPE_COMBOBOX) {
     FX_BOOL bFormated = FALSE;
     CFX_WideString sValue = pWidget->OnFormat(bFormated);
     if (bFormated && nFieldType == FIELDTYPE_COMBOBOX) {
       pWidget->ResetAppearance(sValue.c_str(), FALSE);
     }
   }
 
@@ skipping 62 matching lines @@
 CPDFSDK_Annot* CPDFSDK_XFAAnnotHandler::NewAnnot(CXFA_FFWidget* pAnnot,
                                                  CPDFSDK_PageView* pPage) {
   CPDFSDK_Document* pSDKDoc = m_pApp->GetSDKDocument();
   CPDFSDK_InterForm* pInterForm = (CPDFSDK_InterForm*)pSDKDoc->GetInterForm();
   CPDFSDK_XFAWidget* pWidget = new CPDFSDK_XFAWidget(pAnnot, pPage, pInterForm);
   pInterForm->AddXFAMap(pAnnot, pWidget);
   return pWidget;
 }
 
 FX_BOOL CPDFSDK_XFAAnnotHandler::CanAnswer(CPDFSDK_Annot* pAnnot) {
-  return pAnnot->GetXFAWidget() != NULL;
+  return !!pAnnot->GetXFAWidget();
 }
 
 void CPDFSDK_XFAAnnotHandler::OnDraw(CPDFSDK_PageView* pPageView,
                                      CPDFSDK_Annot* pAnnot,
                                      CFX_RenderDevice* pDevice,
                                      CFX_Matrix* pUser2Device,
                                      uint32_t dwFlags) {
-  ASSERT(pPageView != NULL);
-  ASSERT(pAnnot != NULL);
+  ASSERT(pPageView);
+  ASSERT(pAnnot);
 
   CPDFSDK_Document* pSDKDoc = pPageView->GetSDKDocument();
   CXFA_FFWidgetHandler* pWidgetHandler = GetXFAWidgetHandler(pAnnot);
 
   CFX_Graphics gs;
   gs.Create(pDevice);
 
   CFX_Matrix mt;
   mt = *(CFX_Matrix*)pUser2Device;
 
@@ skipping 216 matching lines @@
   return TRUE;
 }
 
 FX_BOOL CPDFSDK_XFAAnnotHandler::OnKillFocus(CPDFSDK_Annot* pAnnot,
                                              uint32_t nFlag) {
   return TRUE;
 }
 
 FX_BOOL CPDFSDK_XFAAnnotHandler::OnXFAChangedFocus(CPDFSDK_Annot* pOldAnnot,
                                                    CPDFSDK_Annot* pNewAnnot) {
-  CXFA_FFWidgetHandler* pWidgetHandler = NULL;
+  CXFA_FFWidgetHandler* pWidgetHandler = nullptr;
 
   if (pOldAnnot)
     pWidgetHandler = GetXFAWidgetHandler(pOldAnnot);
   else if (pNewAnnot)
     pWidgetHandler = GetXFAWidgetHandler(pNewAnnot);
 
   if (pWidgetHandler) {
     FX_BOOL bRet = TRUE;
-    CXFA_FFWidget* hWidget = pNewAnnot ? pNewAnnot->GetXFAWidget() : NULL;
+    CXFA_FFWidget* hWidget = pNewAnnot ? pNewAnnot->GetXFAWidget() : nullptr;
     if (hWidget) {
       CXFA_FFPageView* pXFAPageView = hWidget->GetPageView();
       if (pXFAPageView) {
         bRet = pXFAPageView->GetDocView()->SetFocus(hWidget);
         if (pXFAPageView->GetDocView()->GetFocusWidget() == hWidget)
           bRet = TRUE;
       }
     }
     return bRet;
   }
 
   return TRUE;
 }
 
 CXFA_FFWidgetHandler* CPDFSDK_XFAAnnotHandler::GetXFAWidgetHandler(
     CPDFSDK_Annot* pAnnot) {
   if (!pAnnot)
-    return NULL;
+    return nullptr;
 
   CPDFSDK_PageView* pPageView = pAnnot->GetPageView();
   if (!pPageView)
-    return NULL;
+    return nullptr;
 
   CPDFSDK_Document* pSDKDoc = pPageView->GetSDKDocument();
   if (!pSDKDoc)
-    return NULL;
+    return nullptr;
 
   CPDFXFA_Document* pDoc = pSDKDoc->GetXFADocument();
   if (!pDoc)
-    return NULL;
+    return nullptr;
 
   CXFA_FFDocView* pDocView = pDoc->GetXFADocView();
   if (!pDocView)
-    return NULL;
+    return nullptr;
 
   return pDocView->GetWidgetHandler();
 }
 
 #define FWL_KEYFLAG_Ctrl (1 << 0)
 #define FWL_KEYFLAG_Alt (1 << 1)
 #define FWL_KEYFLAG_Shift (1 << 2)
 #define FWL_KEYFLAG_LButton (1 << 3)
 #define FWL_KEYFLAG_RButton (1 << 4)
 #define FWL_KEYFLAG_MButton (1 << 5)
@@ skipping 52 matching lines @@
 
 CPDFSDK_Annot* CPDFSDK_AnnotIterator::PrevAnnot() {
   if (m_pos < m_iteratorAnnotList.size())
     return m_iteratorAnnotList[m_iteratorAnnotList.size() - ++m_pos];
   return nullptr;
 }
 
 CPDFSDK_Annot* CPDFSDK_AnnotIterator::Next() {
   return m_bReverse ? PrevAnnot() : NextAnnot();
 }