Get rid of NULLs in fpdfsdk/

fpdfsdk/fsdk_baseform.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/include/fsdk_baseform.h"
 
 #include <algorithm>
 #include <map>
@@ skipping 23 matching lines @@
 
 CPDFSDK_Widget::CPDFSDK_Widget(CPDF_Annot* pAnnot,
                                CPDFSDK_PageView* pPageView,
                                CPDFSDK_InterForm* pInterForm)
     : CPDFSDK_BAAnnot(pAnnot, pPageView),
       m_pInterForm(pInterForm),
       m_nAppAge(0),
       m_nValueAge(0)
 #ifdef PDF_ENABLE_XFA
       ,
-      m_hMixXFAWidget(NULL),
-      m_pWidgetHandler(NULL)
+      m_hMixXFAWidget(nullptr),
+      m_pWidgetHandler(nullptr)
 #endif  // PDF_ENABLE_XFA
 {
 }
 
 CPDFSDK_Widget::~CPDFSDK_Widget() {}
 
 #ifdef PDF_ENABLE_XFA
 CXFA_FFWidget* CPDFSDK_Widget::GetMixXFAWidget() const {
   CPDFSDK_Document* pSDKDoc = m_pPageView->GetSDKDocument();
   CPDFXFA_Document* pDoc = pSDKDoc->GetXFADocument();
   if (pDoc->GetDocType() == DOCTYPE_STATIC_XFA) {
     if (!m_hMixXFAWidget) {
       if (CXFA_FFDocView* pDocView = pDoc->GetXFADocView()) {
         CFX_WideString sName;
         if (GetFieldType() == FIELDTYPE_RADIOBUTTON) {
           sName = GetAnnotName();
           if (sName.IsEmpty())
             sName = GetName();
         } else {
           sName = GetName();
         }
 
         if (!sName.IsEmpty())
           m_hMixXFAWidget = pDocView->GetWidgetByName(sName);
       }
     }
     return m_hMixXFAWidget;
   }
 
-  return NULL;
+  return nullptr;
 }
 
 CXFA_FFWidget* CPDFSDK_Widget::GetGroupMixXFAWidget() {
   CPDFSDK_Document* pSDKDoc = m_pPageView->GetSDKDocument();
   CPDFXFA_Document* pDoc = pSDKDoc->GetXFADocument();
   if (pDoc->GetDocType() == DOCTYPE_STATIC_XFA) {
     if (CXFA_FFDocView* pDocView = pDoc->GetXFADocView()) {
       CFX_WideString sName = GetName();
       if (!sName.IsEmpty())
         return pDocView->GetWidgetByName(sName);
     }
   }
 
   return nullptr;
 }
 
 CXFA_FFWidgetHandler* CPDFSDK_Widget::GetXFAWidgetHandler() const {
   CPDFSDK_Document* pSDKDoc = m_pPageView->GetSDKDocument();
   CPDFXFA_Document* pDoc = pSDKDoc->GetXFADocument();
   if (pDoc->GetDocType() == DOCTYPE_STATIC_XFA) {
     if (!m_pWidgetHandler) {
       if (CXFA_FFDocView* pDocView = pDoc->GetXFADocView()) {
         m_pWidgetHandler = pDocView->GetWidgetHandler();
       }
     }
     return m_pWidgetHandler;
   }
 
-  return NULL;
+  return nullptr;
 }
 
 static XFA_EVENTTYPE GetXFAEventType(PDFSDK_XFAAActionType eXFAAAT) {
   XFA_EVENTTYPE eEventType = XFA_EVENT_Unknown;
 
   switch (eXFAAAT) {
     case PDFSDK_XFA_Click:
       eEventType = XFA_EVENT_Click;
       break;
     case PDFSDK_XFA_Full:
@@ skipping 652 matching lines @@
 
 CFX_WideString CPDFSDK_Widget::OnFormat(FX_BOOL& bFormated) {
   CPDF_FormField* pFormField = GetFormField();
   ASSERT(pFormField);
   return m_pInterForm->OnFormat(pFormField, bFormated);
 }
 
 void CPDFSDK_Widget::ResetFieldAppearance(FX_BOOL bValueChanged) {
   CPDF_FormField* pFormField = GetFormField();
   ASSERT(pFormField);
-  m_pInterForm->ResetFieldAppearance(pFormField, NULL, bValueChanged);
+  m_pInterForm->ResetFieldAppearance(pFormField, nullptr, bValueChanged);
 }
 
 void CPDFSDK_Widget::DrawAppearance(CFX_RenderDevice* pDevice,
                                     const CFX_Matrix* pUser2Device,
                                     CPDF_Annot::AppearanceMode mode,
                                     const CPDF_RenderOptions* pOptions) {
   int nFieldType = GetFieldType();
 
   if ((nFieldType == FIELDTYPE_CHECKBOX ||
        nFieldType == FIELDTYPE_RADIOBUTTON) &&
@@ skipping 137 matching lines @@
   if (pControl->HasMKEntry("CA")) {
     csNormalCaption = pControl->GetNormalCaption();
   }
   if (pControl->HasMKEntry("RC")) {
     csRolloverCaption = pControl->GetRolloverCaption();
   }
   if (pControl->HasMKEntry("AC")) {
     csDownCaption = pControl->GetDownCaption();
   }
 
-  CPDF_Stream* pNormalIcon = NULL;
-  CPDF_Stream* pRolloverIcon = NULL;
-  CPDF_Stream* pDownIcon = NULL;
+  CPDF_Stream* pNormalIcon = nullptr;
+  CPDF_Stream* pRolloverIcon = nullptr;
+  CPDF_Stream* pDownIcon = nullptr;
 
   if (pControl->HasMKEntry("I")) {
     pNormalIcon = pControl->GetNormalIcon();
   }
   if (pControl->HasMKEntry("RI")) {
     pRolloverIcon = pControl->GetRolloverIcon();
   }
   if (pControl->HasMKEntry("IX")) {
     pDownIcon = pControl->GetDownIcon();
   }
@@ skipping 616 matching lines @@
   pEdit->Initialize();
 
   if (sValue)
     pEdit->SetText(sValue);
   else
     pEdit->SetText(pField->GetValue().c_str());
 
   CFX_FloatRect rcContent = pEdit->GetContentRect();
 
   CFX_ByteString sEdit = CPWL_Utils::GetEditAppStream(
-      pEdit, CFX_FloatPoint(0.0f, 0.0f), NULL, !bCharArray, subWord);
+      pEdit, CFX_FloatPoint(0.0f, 0.0f), nullptr, !bCharArray, subWord);
 
   if (sEdit.GetLength() > 0) {
     sBody << "/Tx BMC\n"
           << "q\n";
     if (rcContent.Width() > rcClient.Width() ||
         rcContent.Height() > rcClient.Height()) {
       sBody << rcClient.left << " " << rcClient.bottom << " "
             << rcClient.Width() << " " << rcClient.Height() << " re\nW\nn\n";
     }
     CPWL_Color crText = GetTextPWLColor();
@@ skipping 895 matching lines @@
   uint8_t* pBuffer = FdfBuffer.GetBuffer();
   FX_STRSIZE nBufSize = FdfBuffer.GetLength();
 
   if (bUrlEncoded) {
     if (!FDFToURLEncodedData(pBuffer, nBufSize))
       return FALSE;
   }
 
   pEnv->JS_docSubmitForm(pBuffer, nBufSize, sDestination.c_str());
 
-  if (bUrlEncoded) {
+  if (bUrlEncoded)
     FX_Free(pBuffer);
-    pBuffer = NULL;
-  }
 
   return TRUE;
 }
 
 FX_BOOL CPDFSDK_InterForm::ExportFormToFDFTextBuf(CFX_ByteTextBuf& textBuf) {
   CFDF_Document* pFDF =
       m_pInterForm->ExportToFDF(m_pDocument->GetPath().AsStringC());
   if (!pFDF)
     return FALSE;
 
@@ skipping 75 matching lines @@
 
   if (!OnValidate(pField, csValue))
     return -1;
 
   return 1;
 }
 
 void CPDFSDK_InterForm::AfterSelectionChange(CPDF_FormField* pField) {
   if (pField->GetFieldType() == FIELDTYPE_LISTBOX) {
     OnCalculate(pField);
-    ResetFieldAppearance(pField, NULL, TRUE);
+    ResetFieldAppearance(pField, nullptr, TRUE);
     UpdateField(pField);
   }
 }
 
 void CPDFSDK_InterForm::AfterCheckedStatusChange(CPDF_FormField* pField) {
   int nType = pField->GetFieldType();
   if (nType == FIELDTYPE_CHECKBOX || nType == FIELDTYPE_RADIOBUTTON) {
     OnCalculate(pField);
     UpdateField(pField);
   }
@@ skipping 206 matching lines @@
       break;
     }
   }
 }
 
 CFX_FloatRect CBA_AnnotIterator::GetAnnotRect(const CPDFSDK_Annot* pAnnot) {
   CFX_FloatRect rcAnnot;
   pAnnot->GetPDFAnnot()->GetRect(rcAnnot);
   return rcAnnot;
 }