Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: fpdfsdk/fpdfdoc.cpp

Issue 2031653003: Get rid of NULLs in fpdfsdk/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@nullptr_core
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/fpdf_sysfontinfo.cpp ('k') | fpdfsdk/fpdfeditimg.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "public/fpdf_doc.h" 7 #include "public/fpdf_doc.h"
8 8
9 #include <set> 9 #include <set>
10 10
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 // If this bookmark is not directly associated with a dest, we try to get 123 // If this bookmark is not directly associated with a dest, we try to get
124 // action 124 // action
125 CPDF_Action action = bookmark.GetAction(); 125 CPDF_Action action = bookmark.GetAction();
126 if (!action.GetDict()) 126 if (!action.GetDict())
127 return nullptr; 127 return nullptr;
128 return action.GetDest(pDoc).GetObject(); 128 return action.GetDest(pDoc).GetObject();
129 } 129 }
130 130
131 DLLEXPORT FPDF_ACTION STDCALL FPDFBookmark_GetAction(FPDF_BOOKMARK pDict) { 131 DLLEXPORT FPDF_ACTION STDCALL FPDFBookmark_GetAction(FPDF_BOOKMARK pDict) {
132 if (!pDict) 132 if (!pDict)
133 return NULL; 133 return nullptr;
134 CPDF_Bookmark bookmark(ToDictionary(static_cast<CPDF_Object*>(pDict))); 134 CPDF_Bookmark bookmark(ToDictionary(static_cast<CPDF_Object*>(pDict)));
135 return bookmark.GetAction().GetDict(); 135 return bookmark.GetAction().GetDict();
136 } 136 }
137 137
138 DLLEXPORT unsigned long STDCALL FPDFAction_GetType(FPDF_ACTION pDict) { 138 DLLEXPORT unsigned long STDCALL FPDFAction_GetType(FPDF_ACTION pDict) {
139 if (!pDict) 139 if (!pDict)
140 return PDFACTION_UNSUPPORTED; 140 return PDFACTION_UNSUPPORTED;
141 141
142 CPDF_Action action(ToDictionary(static_cast<CPDF_Object*>(pDict))); 142 CPDF_Action action(ToDictionary(static_cast<CPDF_Object*>(pDict)));
143 CPDF_Action::ActionType type = action.GetType(); 143 CPDF_Action::ActionType type = action.GetType();
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
356 return 0; 356 return 0;
357 CFX_WideString text = pInfo->GetUnicodeTextBy(tag); 357 CFX_WideString text = pInfo->GetUnicodeTextBy(tag);
358 // Use UTF-16LE encoding 358 // Use UTF-16LE encoding
359 CFX_ByteString encodedText = text.UTF16LE_Encode(); 359 CFX_ByteString encodedText = text.UTF16LE_Encode();
360 unsigned long len = encodedText.GetLength(); 360 unsigned long len = encodedText.GetLength();
361 if (buffer && buflen >= len) { 361 if (buffer && buflen >= len) {
362 FXSYS_memcpy(buffer, encodedText.c_str(), len); 362 FXSYS_memcpy(buffer, encodedText.c_str(), len);
363 } 363 }
364 return len; 364 return len;
365 } 365 }
OLDNEW
« no previous file with comments | « fpdfsdk/fpdf_sysfontinfo.cpp ('k') | fpdfsdk/fpdfeditimg.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698