build/linux/check_return_value - Issue 203163003: Use the system provided harfbuzz on chromeos

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/linux/check_return_value

Issue 203163003: Use the system provided harfbuzz on chromeos (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	1 #!/bin/bash

1 # Copyright 2014 The Chromium Authors. All rights reserved.	2 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	3 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	4 # found in the LICENSE file.

4	5

5 from telemetry import decorators	6 # This program wraps an arbitrary command and prints "1" if the command ran

	7 # successfully.

6	8

7	9 if "$@"; then
	Nico 2014/03/18 15:12:13 Why not just "$@" echo $? ? Or import subproces Why not just "$@" echo $? ? Or import subprocess import sys print subprocess.call(sys.argv[1:]) then it runs on windows too and can be in just build/ jochen (gone - plz use gerrit) 2014/03/18 15:39:37 Converted to python. I left the magic in to transl Show quoted text On 2014/03/18 15:12:13, Nico (on GMT time Mar 15 - 24) wrote: > Why not just > > "$@" > echo $? > > ? Or > > import subprocess > import sys > print subprocess.call(sys.argv[1:]) > > then it runs on windows too and can be in just build/ Converted to python. I left the magic in to translate shell success to 1
8 Disabled = decorators.Disabled	10 echo 1

9 Enabled = decorators.Enabled	11 else

	12 echo 0

	13 fi

OLD	NEW