tests/standalone/io/secure_server_socket_test.dart - Issue 20316002: dart:io | Fix handling of exceptions from onBadCertificate callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/standalone/io/secure_server_socket_test.dart

Issue 20316002: dart:io | Fix handling of exceptions from onBadCertificate callback. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: try again Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tests/standalone/io/secure_bad_certificate_test.dart ('k') | tests/standalone/io/secure_socket_bad_certificate_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/standalone/io/secure_server_socket_test.dart

diff --git a/tests/standalone/io/secure_server_socket_test.dart b/tests/standalone/io/secure_server_socket_test.dart

index f7892e685370d53eb1ea38366e20f7e470930ba4..fe838aa18d4f6ba4f793539fba5e215388d77f9c 100644

--- a/tests/standalone/io/secure_server_socket_test.dart

+++ b/tests/standalone/io/secure_server_socket_test.dart

@@ -84,7 +84,8 @@ void testSimpleConnectFail(String certificate, bool cancelOnError) {

Expect.fail("No client connection expected.");

})

.catchError((error) {

- Expect.isTrue(error is HandshakeException);

+ Expect.isTrue(error is HandshakeException ||

+ error is SocketException);

});

server.listen((serverEnd) {

Expect.fail("No server connection expected.");