Chromium Code Reviews

Issue 2031593002: [turbofan] Make sure binop results do not overwrite deoptimization inputs on arm. (Closed)

Created:
4 years, 6 months ago by Jarin
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make sure binop results do not overwrite deoptimization inputs on arm. Committed: https://crrev.com/e60c4053c7f9d6e44b995c77ab3ec561aec83c9c Cr-Commit-Position: refs/heads/master@{#36658}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+8 lines, -1 line)
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +8 lines, -1 line 0 comments

Messages

Total messages: 8 (3 generated)
Jarin
Benedikt, did you have something like this in mind (to avoid binops stomping over deopt ...
4 years, 6 months ago (2016-06-01 15:47:54 UTC) #2
Benedikt Meurer
Yep, that should do the trick. LGTM.
4 years, 6 months ago (2016-06-01 18:31:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031593002/1
4 years, 6 months ago (2016-06-01 20:04:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 20:07:29 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 20:08:32 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e60c4053c7f9d6e44b995c77ab3ec561aec83c9c
Cr-Commit-Position: refs/heads/master@{#36658}

Powered by Google App Engine