Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2031543002:
Updated description for Managed Bookmarks policy. (Closed)
|
Created:
4 years, 6 months ago by Ivan Šandrk Modified:
4 years, 6 months ago CC:
chromium-reviews, tnagel+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdated description for Managed Bookmarks policy.
Added an example for how to set the toplevel folder name.
BUG=614831
Committed: https://crrev.com/aad9ffcc1a4085a3be07caba583de10aa3af6460
Cr-Commit-Position: refs/heads/master@{#398514}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Added toplevel_name to example section #
Total comments: 2
Patch Set 3 : Improved readability. #Messages
Total messages: 21 (9 generated)
isandrk@chromium.org changed reviewers: + atwilson@chromium.org
ptal
Description was changed from ========== Updated description for Managed Bookmarks policy Added an example for how to set the toplevel folder name BUG=614831 ========== to ========== Updated description for Managed Bookmarks policy Added an example for how to set the toplevel folder name BUG=614831 ==========
isandrk@chromium.org changed reviewers: + tnagel@chromium.org
https://codereview.chromium.org/2031543002/diff/1/components/policy/resources... File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2031543002/diff/1/components/policy/resources... components/policy/resources/policy_templates.json:7553: The folder name for the bookmarks is customizable by adding a {"toplevel_name": "some name"} list item, eg. set the policy value to [{"toplevel_name": "My managed bookmarks"}, {"url": "google.com", "name": "Google"}, {"url": "youtube.com", "name": "Youtube"}, {"name": "Chrome links", "children": [{"url": "chromium.org", "name": "Chromium"}, {"url": "dev.chromium.org", "name": "Chromium Developers"}]}]. This functionality is available starting from release 51.''', Why don't you add toplevel_name to the example section? That would seem more appropriate than adding the example to the description.
https://codereview.chromium.org/2031543002/diff/1/components/policy/resources... File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2031543002/diff/1/components/policy/resources... components/policy/resources/policy_templates.json:7553: The folder name for the bookmarks is customizable by adding a {"toplevel_name": "some name"} list item, eg. set the policy value to [{"toplevel_name": "My managed bookmarks"}, {"url": "google.com", "name": "Google"}, {"url": "youtube.com", "name": "Youtube"}, {"name": "Chrome links", "children": [{"url": "chromium.org", "name": "Chromium"}, {"url": "dev.chromium.org", "name": "Chromium Developers"}]}]. This functionality is available starting from release 51.''', On 2016/06/06 18:39:32, Thiemo Nagel wrote: > Why don't you add toplevel_name to the example section? That would seem more > appropriate than adding the example to the description. Done.
Commit message: Please end sentences with a punctuation mark and please leave a blank line between headline and description. https://codereview.chromium.org/2031543002/diff/20001/components/policy/resou... File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2031543002/diff/20001/components/policy/resou... components/policy/resources/policy_templates.json:7555: The folder name for the bookmarks is customizable by adding a {"toplevel_name": "some name"} list item. This functionality is available starting from release 51.''', Much better than before! Still I think readability could be improved by merging the two sentences, eg. "Starting with release 51, the folder name for the bookmarks is customizable ..."
Description was changed from ========== Updated description for Managed Bookmarks policy Added an example for how to set the toplevel folder name BUG=614831 ========== to ========== Updated description for Managed Bookmarks policy. Added an example for how to set the toplevel folder name. BUG=614831 ==========
https://codereview.chromium.org/2031543002/diff/20001/components/policy/resou... File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2031543002/diff/20001/components/policy/resou... components/policy/resources/policy_templates.json:7555: The folder name for the bookmarks is customizable by adding a {"toplevel_name": "some name"} list item. This functionality is available starting from release 51.''', On 2016/06/07 12:14:07, Thiemo Nagel wrote: > Much better than before! Still I think readability could be improved by merging > the two sentences, eg. "Starting with release 51, the folder name for the > bookmarks is customizable ..." Done.
On 2016/06/07 13:06:09, Ivan Šandrk wrote: > https://codereview.chromium.org/2031543002/diff/20001/components/policy/resou... > File components/policy/resources/policy_templates.json (right): > > https://codereview.chromium.org/2031543002/diff/20001/components/policy/resou... > components/policy/resources/policy_templates.json:7555: The folder name for the > bookmarks is customizable by adding a {"toplevel_name": "some name"} list item. > This functionality is available starting from release 51.''', > On 2016/06/07 12:14:07, Thiemo Nagel wrote: > > Much better than before! Still I think readability could be improved by > merging > > the two sentences, eg. "Starting with release 51, the folder name for the > > bookmarks is customizable ..." > > Done. Awesome. LGTM!
The CQ bit was checked by isandrk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031543002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by isandrk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031543002/40001
Message was sent while issue was closed.
Description was changed from ========== Updated description for Managed Bookmarks policy. Added an example for how to set the toplevel folder name. BUG=614831 ========== to ========== Updated description for Managed Bookmarks policy. Added an example for how to set the toplevel folder name. BUG=614831 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Updated description for Managed Bookmarks policy. Added an example for how to set the toplevel folder name. BUG=614831 ========== to ========== Updated description for Managed Bookmarks policy. Added an example for how to set the toplevel folder name. BUG=614831 Committed: https://crrev.com/aad9ffcc1a4085a3be07caba583de10aa3af6460 Cr-Commit-Position: refs/heads/master@{#398514} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/aad9ffcc1a4085a3be07caba583de10aa3af6460 Cr-Commit-Position: refs/heads/master@{#398514} |
