src/heap/incremental-marking.cc - Issue 2031533002: [dictionaries] Use IsKey(Isolate* i, Object* o) everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/incremental-marking.cc

Issue 2031533002: [dictionaries] Use IsKey(Isolate* i, Object* o) everywhere (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: use new IsTheHole Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/incremental-marking.cc

diff --git a/src/heap/incremental-marking.cc b/src/heap/incremental-marking.cc

index e75bf7e57e8a9e95f3bccb2681038bbb3fcd5688..35b8508472ad2ed8b2fbbf5d06910c3d74228761 100644

--- a/src/heap/incremental-marking.cc

+++ b/src/heap/incremental-marking.cc

@@ -473,9 +473,10 @@ static void PatchIncrementalMarkingRecordWriteStubs(

UnseededNumberDictionary* stubs = heap->code_stubs();

int capacity = stubs->Capacity();

+ Isolate* isolate = heap->isolate();

for (int i = 0; i < capacity; i++) {

Object* k = stubs->KeyAt(i);

- if (stubs->IsKey(k)) {

+ if (stubs->IsKey(isolate, k)) {

uint32_t key = NumberToUint32(k);

if (CodeStub::MajorKeyFromKey(key) == CodeStub::RecordWrite) {

« no previous file with comments | « src/elements.cc ('k') | src/heap/mark-compact.cc » ('j') | no next file with comments »