Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2031533002: [dictionaries] Use IsKey(Isolate* i, Object* o) everywhere (Closed)

Created:
4 years, 6 months ago by Camillo Bruni
Modified:
4 years, 6 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[dictionaries] Use IsKey(Isolate* i, Object* o) everywhere Using the isolate to check for IsUndefined and IsTheHole is roughly at least 20% faster in the worst-case and up to a factor 2x in the best case. BUG= Committed: https://crrev.com/764d4e6103404a18156f9916b277b999a43580f8 Cr-Commit-Position: refs/heads/master@{#36787}

Patch Set 1 #

Patch Set 2 : rebasing #

Patch Set 3 : fixes #

Patch Set 4 : use new IsTheHole #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -122 lines) Patch
M src/api.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M src/bootstrapper.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins.cc View 1 4 chunks +9 lines, -12 lines 0 comments Download
M src/elements.cc View 1 4 chunks +11 lines, -30 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/mark-compact.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/objects.cc View 1 2 3 30 chunks +64 lines, -57 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 5 chunks +6 lines, -4 lines 0 comments Download
M src/runtime/runtime-collections.cc View 1 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Camillo Bruni
Continuing my cleanup... hpayer@ PTAL heap/.* yangguo@ PTAL the rest
4 years, 6 months ago (2016-06-07 08:48:42 UTC) #2
Yang
lgtm
4 years, 6 months ago (2016-06-07 10:49:39 UTC) #3
Hannes Payer (out of office)
lgtm
4 years, 6 months ago (2016-06-07 11:52:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031533002/60001
4 years, 6 months ago (2016-06-07 11:53:28 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-07 12:22:02 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 12:22:55 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/764d4e6103404a18156f9916b277b999a43580f8
Cr-Commit-Position: refs/heads/master@{#36787}

Powered by Google App Engine
This is Rietveld 408576698