Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2031503002: Convert media-captions-* and media-constants-* tests to testharness.js (Closed)

Created:
4 years, 6 months ago by Srirama
Modified:
4 years, 6 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert media-captions-* and media-constants-* tests to testharness.js Cleaning up media-captions-* and media-constants-* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/7e922c0fed45d80e06317de5e07dfdce653de85a Cr-Commit-Position: refs/heads/master@{#397377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -123 lines) Patch
M third_party/WebKit/LayoutTests/media/media-captions-no-controls.html View 1 chunk +31 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-captions-no-controls-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/media-constants.html View 1 chunk +20 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-constants-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Srirama
PTAL
4 years, 6 months ago (2016-06-01 11:38:32 UTC) #3
fs
lgtm
4 years, 6 months ago (2016-06-01 13:24:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031503002/1
4 years, 6 months ago (2016-06-02 10:37:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 12:53:53 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 12:56:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e922c0fed45d80e06317de5e07dfdce653de85a
Cr-Commit-Position: refs/heads/master@{#397377}

Powered by Google App Engine
This is Rietveld 408576698