Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: src/arm64/macro-assembler-arm64.cc

Issue 2031493002: Revert of Provide a tagged allocation top pointer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/code-stubs-arm64.cc ('k') | src/code-stub-assembler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm64/macro-assembler-arm64.cc
diff --git a/src/arm64/macro-assembler-arm64.cc b/src/arm64/macro-assembler-arm64.cc
index 0c3f231a3f17e382cbe33350150ec777922f2416..0490c388d9bbbb8c79a01639edd58a75abb338a8 100644
--- a/src/arm64/macro-assembler-arm64.cc
+++ b/src/arm64/macro-assembler-arm64.cc
@@ -3097,6 +3097,9 @@
// The top pointer is not updated for allocation folding dominators.
Str(result_end, MemOperand(top_address));
}
+
+ // Tag the object.
+ ObjectTag(result, result);
}
@@ -3166,7 +3169,7 @@
if (emit_debug_code()) {
Tst(result_end, kObjectAlignmentMask);
- Check(ne, kUnalignedAllocationInNewSpace);
+ Check(eq, kUnalignedAllocationInNewSpace);
}
Ccmp(result_end, alloc_limit, NoFlag, cc);
@@ -3176,6 +3179,9 @@
// The top pointer is not updated for allocation folding dominators.
Str(result_end, MemOperand(top_address));
}
+
+ // Tag the object.
+ ObjectTag(result, result);
}
void MacroAssembler::FastAllocate(int object_size, Register result,
@@ -3208,6 +3214,8 @@
// Calculate new top and write it back.
Adds(result_end, result, object_size);
Str(result_end, MemOperand(top_address));
+
+ ObjectTag(result, result);
}
void MacroAssembler::FastAllocate(Register object_size, Register result,
@@ -3241,8 +3249,10 @@
if (emit_debug_code()) {
Tst(result_end, kObjectAlignmentMask);
- Check(ne, kUnalignedAllocationInNewSpace);
- }
+ Check(eq, kUnalignedAllocationInNewSpace);
+ }
+
+ ObjectTag(result, result);
}
void MacroAssembler::AllocateTwoByteString(Register result,
« no previous file with comments | « src/arm64/code-stubs-arm64.cc ('k') | src/code-stub-assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698