Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2031463002: Add WTF::WeakPtr::operator*() (Closed)

Created:
4 years, 6 months ago by tzik
Modified:
4 years, 6 months ago
Reviewers:
Yuta Kitamura
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add WTF::WeakPtr::operator*() Add missing operator* to WeakPtr, so that its instance can be dereferenced uniformly. Committed: https://crrev.com/d0a365b9aebc47e65c70b0000c0c731431048408 Cr-Commit-Position: refs/heads/master@{#397118}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M third_party/WebKit/Source/wtf/WeakPtr.h View 1 3 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
tzik
PTAL
4 years, 6 months ago (2016-06-01 08:16:31 UTC) #2
Yuta Kitamura
lgtm
4 years, 6 months ago (2016-06-01 08:22:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031463002/1
4 years, 6 months ago (2016-06-01 08:23:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/145987) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 6 months ago (2016-06-01 08:48:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031463002/20001
4 years, 6 months ago (2016-06-01 10:56:22 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 13:00:06 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 13:01:19 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d0a365b9aebc47e65c70b0000c0c731431048408
Cr-Commit-Position: refs/heads/master@{#397118}

Powered by Google App Engine
This is Rietveld 408576698