Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2031443002: Add ReloadPageLoadMetricsObserver to have a metrics variant only reloads (Closed)

Created:
4 years, 6 months ago by Takashi Toyoshima
Modified:
4 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Add ReloadPageLoadMetricsObserver to have a metrics variant only reloads To measure reload experiments impact, this change adds ReloadPageLoadMetricsObserver to report TTFCP variants only for reload-related page loadings. BUG=607063 TBR=isherman@chromium.org, bmcquade@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2008233002 Cr-Commit-Position: refs/heads/master@{#396395} (cherry picked from commit d056525caaa71451d25f6113895b376e47177f6e)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -0 lines) Patch
A chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.h View 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_initialize.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031443002/1
4 years, 6 months ago (2016-06-01 07:22:10 UTC) #4
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 6 months ago (2016-06-01 07:22:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031443002/1
4 years, 6 months ago (2016-06-01 07:26:04 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 07:27:38 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698