chrome/browser/ui/views/omnibox/omnibox_view_views.h - Issue 2031433002: Views::Textfield: Decouple handling of menu and text editing commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.h

Issue 2031433002: Views::Textfield: Decouple handling of menu and text editing commands. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor2_virtual_calls

Patch Set: Address review comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.h

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.h b/chrome/browser/ui/views/omnibox/omnibox_view_views.h

index b12098d3e296bf865ad06f843b5990c5e8b9d5e6..2ee5f226abf1e7f1d8c168f51294589cc8c65bbf 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.h

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.h

@@ -179,6 +179,8 @@ class OmniboxViewViews

bool IsCommandIdEnabled(int command_id) const override;

base::string16 GetSelectionClipboardText() const override;

void DoInsertChar(base::char16 ch) override;

+ bool IsEditCommandEnabled(int command_id) const override;

+ void ExecuteEditCommand(int command_id) override;

// chromeos::input_method::InputMethodManager::CandidateWindowObserver:

#if defined(OS_CHROMEOS)

« no previous file with comments | « no previous file | chrome/browser/ui/views/omnibox/omnibox_view_views.cc » ('j') | no next file with comments »