Simplify EventTarget bindings generation (2)

Source/bindings/templates/methods.cpp

 {##############################################################################}
 {% macro generate_method(method, world_suffix) %}
 {% filter conditional(method.conditional_string) %}
 static void {{method.name}}{{method.overload_index}}Method{{world_suffix}}(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     {% if method.has_exception_state %}
     ExceptionState exceptionState(ExceptionState::ExecutionContext, "{{method.name}}", "{{interface_name}}", info.Holder(), info.GetIsolate());
     {% endif %}
     {% if method.number_of_required_arguments %}
     if (UNLIKELY(info.Length() < {{method.number_of_required_arguments}})) {
@@ skipping 19 matching lines @@
     }
     {% endif %}
     {% if method.is_check_security_for_node %}
     if (!BindingSecurity::shouldAllowAccessToNode(info.GetIsolate(), impl->{{method.name}}(exceptionState), exceptionState)) {
         v8SetReturnValueNull(info);
         exceptionState.throwIfNeeded();
         return;
     }
     {% endif %}
     {# Call method #}
-    {% if interface_name == 'EventTarget' and

[Nils Barth (inactive), 2014/03/18 07:20:36]

Moved down, so now arguments are always generated normally.

-          method.name in ['addEventListener', 'removeEventListener'] %}
-    {{add_event_listener_remove_event_listener_method(method.name) | indent}}
-    {% else %}
     {% for argument in method.arguments %}
     {{generate_argument(method, argument, world_suffix) | indent}}
     {% endfor %}
+    {% if interface_name == 'EventTarget' and
+          method.name in ['addEventListener', 'removeEventListener'] %}
+    {# FIXME: can we move this |listener| check into Blink and
+       hidden_dependency_action? I.e., "if (!listener) return;" in Blink
+       and "if (listener && !impl->toNode())" in hidden_dependency_action} #}
+    if (!listener)
+        return;
+    {% endif %}
     {% if world_suffix %}
     {{cpp_method_call(method, method.v8_set_return_value_for_main_world, method.cpp_value) | indent}}
     {% else %}
     {{cpp_method_call(method, method.v8_set_return_value, method.cpp_value) | indent}}
     {% endif %}
-    {% endif %}{# addEventListener, removeEventListener #}
+    {% if interface_name == 'EventTarget' and
+          method.name in ['addEventListener', 'removeEventListener'] %}
+    {{hidden_dependency_action(method.name) | indent}}
+    {% endif %}
 }
 {% endfilter %}
 {% endmacro %}
 
 
 {######################################}
 {% macro event_target_check_security_for_frame() %}
 {# FIXME: use the existing shouldAllowAccessToFrame check if possible. #}
 if (DOMWindow* window = impl->toDOMWindow()) {
     if (!BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), window->frame(), exceptionState)) {
         exceptionState.throwIfNeeded();
         return;
     }
     if (!window->document())
         return;
 }
 {% endmacro %}
 
 
 {######################################}
-{% macro add_event_listener_remove_event_listener_method(method_name) %}
-{# Set template values for addEventListener vs. removeEventListener #}
-{% set listener_lookup_type, listener, hidden_dependency_action =
-    ('ListenerFindOrCreate', 'listener', 'addHiddenValueToArray')
-    if method_name == 'addEventListener' else
-    ('ListenerFindOnly', 'listener.get()', 'removeHiddenValueFromArray')
-%}
-RefPtr<EventListener> listener = V8EventListenerList::getEventListener(info[1], false, {{listener_lookup_type}});
-if (listener) {
-    V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithNullCheck>, eventName, info[0]);
-    impl->{{method_name}}(eventName, {{listener}}, info[2]->BooleanValue());
-    if (!impl->toNode())
-        {{hidden_dependency_action}}(info.Holder(), info[1], {{v8_class}}::eventListenerCacheIndex, info.GetIsolate());
-}
+{% macro hidden_dependency_action(method_name) %}

[Nils Barth (inactive), 2014/03/18 07:20:36]

Much simpler, because now only the really special behavior.

+if (!impl->toNode())
+    {% if method_name == 'addEventListener' %}
+    addHiddenValueToArray(info.Holder(), info[1], {{v8_class}}::eventListenerCacheIndex, info.GetIsolate());
+    {% else %}{# method_name == 'removeEventListener' #}
+    removeHiddenValueFromArray(info.Holder(), info[1], {{v8_class}}::eventListenerCacheIndex, info.GetIsolate());
+    {% endif %}
 {% endmacro %}
 
 
 {######################################}
 {% macro generate_argument(method, argument, world_suffix) %}
 {% if argument.is_optional and not argument.has_default and
       argument.idl_type != 'Dictionary' and
       not argument.is_callback_interface %}
 {# Optional arguments without a default value generate an early call with
    fewer arguments if they are omitted.
    Optional Dictionary arguments default to empty dictionary. #}
 if (UNLIKELY(info.Length() <= {{argument.index}})) {
+    {% if interface_name == 'EventTarget' %}
+    {# FIXME: can we move this |listener| check into Blink? (see above) #}
+    if (!listener)
+        return;
+    {% endif %}
     {% if world_suffix %}
     {{cpp_method_call(method, argument.v8_set_return_value_for_main_world, argument.cpp_value) | indent}}
     {% else %}
     {{cpp_method_call(method, argument.v8_set_return_value, argument.cpp_value) | indent}}
     {% endif %}
+    {% if interface_name == 'EventTarget' %}
+    {{hidden_dependency_action(method.name) | indent}}
+    {% endif %}
     return;
 }
 {% endif %}
 {% if method.is_strict_type_checking and argument.is_wrapper_type %}
 {# Type checking for wrapper interface types (if interface not implemented,
    throw TypeError), per http://www.w3.org/TR/WebIDL/#es-interface #}
 if (info.Length() > {{argument.index}} && {% if argument.is_nullable %}!isUndefinedOrNull(info[{{argument.index}}]) && {% endif %}!V8{{argument.idl_type}}::hasInstance(info[{{argument.index}}], info.GetIsolate())) {
     {{throw_type_error(method, '"parameter %s is not of type \'%s\'."' %
                                (argument.index + 1, argument.idl_type)) | indent}}
     return;
@@ skipping 35 matching lines @@
 {% elif argument.is_variadic_wrapper_type %}
 {{argument.vector_type}}<{{argument.cpp_type}} > {{argument.name}};
 for (int i = {{argument.index}}; i < info.Length(); ++i) {
     if (!V8{{argument.idl_type}}::hasInstance(info[i], info.GetIsolate())) {
         {{throw_type_error(method, '"parameter %s is not of type \'%s\'."' %
                                    (argument.index + 1, argument.idl_type)) | indent(8)}}
         return;
     }
     {{argument.name}}.append(V8{{argument.idl_type}}::toNative(v8::Handle<v8::Object>::Cast(info[i])));
 }
+{# FIXME: remove EventListener special case

[Nils Barth (inactive), 2014/03/18 07:20:36]

This is really ugly, and it's all because we want to pass in
ListenerFindOnly for removeEventListener;
otherwise it would be easy to handle in v8_types.
I'd like to eliminate this ASAP.

+    (just for ListenerFindOrCreate/ListenerFindOnly argument) #}
+{% elif argument.idl_type == 'EventListener' and
+        interface_name == 'EventTarget' and
+        method.name == 'addEventListener' %}
+V8TRYCATCH_VOID(RefPtr<EventListener>, {{argument.name}}, V8EventListenerList::getEventListener(info[{{argument.index}}], false, ListenerFindOrCreate));
+{% elif argument.idl_type == 'EventListener' and
+        interface_name == 'EventTarget' and
+        method.name == 'removeEventListener' %}
+V8TRYCATCH_VOID(RefPtr<EventListener>, {{argument.name}}, V8EventListenerList::getEventListener(info[{{argument.index}}], false, ListenerFindOnly));
 {% else %}
 {{argument.v8_value_to_local_cpp_value}};
 {% endif %}
 {% if argument.enum_validation_expression %}
 {# Methods throw on invalid enum values: http://www.w3.org/TR/WebIDL/#idl-enums #}
 String string = {{argument.name}};
 if (!({{argument.enum_validation_expression}})) {
     {{throw_type_error(method,
           '"parameter %s (\'" + string + "\') is not a valid enum value."' %
               (argument.index + 1)) | indent}}
@@ skipping 266 matching lines @@
     v8::Handle<v8::Object> wrapper = info.Holder();
     {% if is_constructor_raises_exception %}
     if (exceptionState.throwIfNeeded())
         return;
     {% endif %}
 
     V8DOMWrapper::associateObjectWithWrapper<{{v8_class}}>(impl.release(), &{{v8_class}}Constructor::wrapperTypeInfo, wrapper, info.GetIsolate(), WrapperConfiguration::Dependent);
     v8SetReturnValue(info, wrapper);
 }
 {% endmacro %}