💳 target_cpu -> current_cpu in gpu/vulkan/BUILD.gn

target_cpu -> current_cpu in gpu/vulkan/BUILD.gn

and gpu/tools/compositor_model_bench/BUILD.gn

target_cpu does not differ based on the current toolchain,
so it should basically never be used.

BUG=616819
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/f0a841cc69c359dc2bb39d7fcd33e972c100c030
Cr-Commit-Position: refs/heads/master@{#398570}

[agrieve, 2016-06-03 17:06:39]

Description was changed from

==========
target_cpu -> current_cpu in gpu/vulkan/BUILD.gn

and gpu/tools/compositor_model_bench/BUILD.gn

BUG=616819
==========

to

==========
target_cpu -> current_cpu in gpu/vulkan/BUILD.gn

and gpu/tools/compositor_model_bench/BUILD.gn

BUG=616819
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[agrieve, 2016-06-03 17:17:38]

agrieve@chromium.org changed reviewers:
+ sievers@chromium.org

[no sievers, 2016-06-03 18:23:12]

lgtm. can you put a comment in the cl description regarding what you explained
offline i.e. taget_cpu is what's set in 'gn args'/gyp env, while current_cpu can
be overriden through a module dependency and the toolchain it wants to use.

[agrieve, 2016-06-03 18:45:34]

Description was changed from

==========
target_cpu -> current_cpu in gpu/vulkan/BUILD.gn

and gpu/tools/compositor_model_bench/BUILD.gn

BUG=616819
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
target_cpu -> current_cpu in gpu/vulkan/BUILD.gn

and gpu/tools/compositor_model_bench/BUILD.gn

target_cpu does not differ based on the current toolchain,
so it should basically never be used.

BUG=616819
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[agrieve, 2016-06-03 18:46:15]

On 2016/06/03 18:23:12, sievers wrote:
> lgtm. can you put a comment in the cl description regarding what you explained
> offline i.e. taget_cpu is what's set in 'gn args'/gyp env, while current_cpu
can
> be overriden through a module dependency and the toolchain it wants to use.

Updated it. And also have a change to make the docs more clear:
https://codereview.chromium.org/2038733003

[agrieve, 2016-06-08 14:40:39]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-06-08 14:41:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031403002/1

[commit-bot: I haz the power, 2016-06-08 15:49:07]

Description was changed from

==========
target_cpu -> current_cpu in gpu/vulkan/BUILD.gn

and gpu/tools/compositor_model_bench/BUILD.gn

target_cpu does not differ based on the current toolchain,
so it should basically never be used.

BUG=616819
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
target_cpu -> current_cpu in gpu/vulkan/BUILD.gn

and gpu/tools/compositor_model_bench/BUILD.gn

target_cpu does not differ based on the current toolchain,
so it should basically never be used.

BUG=616819
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-06-08 15:49:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-08 15:52:03]

Description was changed from

==========
target_cpu -> current_cpu in gpu/vulkan/BUILD.gn

and gpu/tools/compositor_model_bench/BUILD.gn

target_cpu does not differ based on the current toolchain,
so it should basically never be used.

BUG=616819
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
target_cpu -> current_cpu in gpu/vulkan/BUILD.gn

and gpu/tools/compositor_model_bench/BUILD.gn

target_cpu does not differ based on the current toolchain,
so it should basically never be used.

BUG=616819
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/f0a841cc69c359dc2bb39d7fcd33e972c100c030
Cr-Commit-Position: refs/heads/master@{#398570}
==========

[commit-bot: I haz the power, 2016-06-08 15:52:04]

Patchset 1 (id:??) landed as
https://crrev.com/f0a841cc69c359dc2bb39d7fcd33e972c100c030
Cr-Commit-Position: refs/heads/master@{#398570}