third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp - Issue 2031393003: WebAudio: record whether user gesture was available and provided.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

Issue 2031393003: WebAudio: record whether user gesture was available and provided. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AudioContext.cpp » ('j') | third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

index c1ff657683969e77b6d366583016fa35740e166f..bb0d054df5b6e31cdcfac26f36e3576d697a2b72 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

@@ -441,6 +441,8 @@ void AudioBufferSourceHandler::startSource(double when, double grainOffset, doub

{

ASSERT(isMainThread());

+ context()->recordUserGestureState();

Raymond Toy 2016/06/06 15:10:08 Probably want this after all of the code that coul

mlamouri (slow - plz ping) 2016/06/06 16:14:13 WebKit puts it exactly here actually :(

if (playbackState() != UNSCHEDULED_STATE) {

exceptionState.throwDOMException(

InvalidStateError,