Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: third_party/WebKit/Source/platform/fonts/linux/FontCacheLinux.cpp

Issue 2031363002: Use a FontPlatformData pointer for FontDataCache's key (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Crashes, lifecycle issues fixed Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/linux/FontCacheLinux.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/linux/FontCacheLinux.cpp b/third_party/WebKit/Source/platform/fonts/linux/FontCacheLinux.cpp
index 9402edee7ccc79a777437bc763abf59ecbb499a0..630fb24d207c9570cc1839ffd86d7f53352b8b31 100644
--- a/third_party/WebKit/Source/platform/fonts/linux/FontCacheLinux.cpp
+++ b/third_party/WebKit/Source/platform/fonts/linux/FontCacheLinux.cpp
@@ -134,10 +134,11 @@ PassRefPtr<SimpleFontData> FontCache::fallbackFontForCharacter(
FontPlatformData* substitutePlatformData = getFontPlatformData(description, creationParams);
if (!substitutePlatformData)
return nullptr;
- FontPlatformData platformData = FontPlatformData(*substitutePlatformData);
- platformData.setSyntheticBold(shouldSetSyntheticBold);
- platformData.setSyntheticItalic(shouldSetSyntheticItalic);
- return fontDataFromFontPlatformData(&platformData, DoNotRetain);
+
+ std::unique_ptr<FontPlatformData> platformData(new FontPlatformData(*substitutePlatformData));
+ platformData->setSyntheticBold(shouldSetSyntheticBold);
+ platformData->setSyntheticItalic(shouldSetSyntheticItalic);
+ return fontDataFromFontPlatformData(platformData.get(), DoNotRetain);
}
#endif // !OS(ANDROID)

Powered by Google App Engine
This is Rietveld 408576698