Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGFELightElement.cpp

Issue 2031353002: SVGFE{Spot,Distant,Point}LightElement can have non-SVGFE*Lighting parent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/filters/feLight-non-lighting-parent-crash-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * Copyright (C) 2005 Oliver Hunt <oliver@nerget.com> 4 * Copyright (C) 2005 Oliver Hunt <oliver@nerget.com>
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 || attrName == SVGNames::limitingConeAngleAttr) { 98 || attrName == SVGNames::limitingConeAngleAttr) {
99 ContainerNode* parent = parentNode(); 99 ContainerNode* parent = parentNode();
100 if (!parent) 100 if (!parent)
101 return; 101 return;
102 102
103 LayoutObject* layoutObject = parent->layoutObject(); 103 LayoutObject* layoutObject = parent->layoutObject();
104 if (!layoutObject || !layoutObject->isSVGResourceFilterPrimitive()) 104 if (!layoutObject || !layoutObject->isSVGResourceFilterPrimitive())
105 return; 105 return;
106 106
107 SVGElement::InvalidationGuard invalidationGuard(this); 107 SVGElement::InvalidationGuard invalidationGuard(this);
108 if (isSVGFEDiffuseLightingElement(*parent)) { 108 if (isSVGFEDiffuseLightingElement(*parent))
109 toSVGFEDiffuseLightingElement(*parent).lightElementAttributeChanged( this, attrName); 109 toSVGFEDiffuseLightingElement(*parent).lightElementAttributeChanged( this, attrName);
110 return; 110 else if (isSVGFESpecularLightingElement(*parent))
111 }
112 if (isSVGFESpecularLightingElement(*parent)) {
113 toSVGFESpecularLightingElement(*parent).lightElementAttributeChanged (this, attrName); 111 toSVGFESpecularLightingElement(*parent).lightElementAttributeChanged (this, attrName);
114 return;
115 }
116 112
117 ASSERT_NOT_REACHED(); 113 return;
118 } 114 }
119 115
120 SVGElement::svgAttributeChanged(attrName); 116 SVGElement::svgAttributeChanged(attrName);
121 } 117 }
122 118
123 void SVGFELightElement::childrenChanged(const ChildrenChange& change) 119 void SVGFELightElement::childrenChanged(const ChildrenChange& change)
124 { 120 {
125 SVGElement::childrenChanged(change); 121 SVGElement::childrenChanged(change);
126 122
127 if (!change.byParser) { 123 if (!change.byParser) {
128 if (ContainerNode* parent = parentNode()) { 124 if (ContainerNode* parent = parentNode()) {
129 LayoutObject* layoutObject = parent->layoutObject(); 125 LayoutObject* layoutObject = parent->layoutObject();
130 if (layoutObject && layoutObject->isSVGResourceFilterPrimitive()) 126 if (layoutObject && layoutObject->isSVGResourceFilterPrimitive())
131 markForLayoutAndParentResourceInvalidation(layoutObject); 127 markForLayoutAndParentResourceInvalidation(layoutObject);
132 } 128 }
133 } 129 }
134 } 130 }
135 131
136 } // namespace blink 132 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/filters/feLight-non-lighting-parent-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698