Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 203133003: Require gcc 4.8 for debug fission (Closed)

Created:
6 years, 9 months ago by mithro-old
Modified:
6 years, 9 months ago
Reviewers:
Lei Zhang, Nico
CC:
chromium-reviews, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

GCC didn't officially add -gsplit-dwarf until version 4.8 I tested with gcc 4.8 and then believed the internet when it said 4.7 had support. Someone was wrong on the internet, inconceivable! Confirmed not supported on 4.7 via GCC release notes at http://gcc.gnu.org/onlinedocs/gcc-4.7.0/gcc/Debugging-Options.html#Debugging-Options Confirmed supported on 4.8 via GCC release notes at http://gcc.gnu.org/onlinedocs/gcc-4.8.0/gcc/Debugging-Options.html#Debugging-Options Issue reported by sigbjornf@opera.com BUG=352046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257861

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
mithro-old
Hi, Fixing an issue reported by sof about his build failing on gcc 4.7 Tim
6 years, 9 months ago (2014-03-18 14:01:56 UTC) #1
Nico
lgtm
6 years, 9 months ago (2014-03-18 14:02:44 UTC) #2
mithro-old
The CQ bit was checked by mithro@mithis.com
6 years, 9 months ago (2014-03-18 14:04:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/203133003/1
6 years, 9 months ago (2014-03-18 14:05:16 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 16:03:48 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 9 months ago (2014-03-18 16:03:53 UTC) #6
mithro-old
The CQ bit was checked by mithro@mithis.com
6 years, 9 months ago (2014-03-18 16:05:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/203133003/1
6 years, 9 months ago (2014-03-18 16:07:34 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 20:47:50 UTC) #9
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-18 20:47:50 UTC) #10
mithro-old
The CQ bit was checked by mithro@mithis.com
6 years, 9 months ago (2014-03-19 01:28:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/203133003/1
6 years, 9 months ago (2014-03-19 01:30:05 UTC) #12
commit-bot: I haz the power
Change committed as 257861
6 years, 9 months ago (2014-03-19 06:06:01 UTC) #13
dshwang
Hi, can I ask a question? Are you working on distributed build system? After your ...
6 years, 9 months ago (2014-03-19 10:33:19 UTC) #14
Nico
6 years, 9 months ago (2014-03-19 10:37:08 UTC) #15
Message was sent while issue was closed.
On 2014/03/19 10:33:19, dshwang wrote:
> Hi, can I ask a question?
> 
> Are you working on distributed build system? After your debug build
> optimization, icecc debug build was broken.
> 
> FAILED: c++ -MMD -MF
> obj/third_party/angle/src/compiler/preprocessor/preprocessor.MacroExpander.o.d
> /* many options /*
> obj/third_party/angle/src/compiler/preprocessor/preprocessor.MacroExpander.o
> g++: error trying to exec 'objcopy': execvp: No such file or directory
> 
> I guess icecc cannot deal with objcopy, so I filed icecc bug;
> https://github.com/icecc/icecream/issues/86
> anyway, I'm curious that others are in trouble like me, and what is the best
> solution for my problem.

You can set GYP_DEFINES=binutils_version=0 to disable fission. Note that using
fission will make linking two to three times as fast, so you might instead
consider not using icecc until the bug in icecc is fixed. (You'll have slower
full builds, but much faster incremental builds. At least I do incremental
builds much more often than full builds.)

Powered by Google App Engine
This is Rietveld 408576698